From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7D823C8D3 for ; Fri, 6 Jun 2025 23:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749251101; cv=none; b=nIpYVIdGWWZ/YP8dPknCVyAHFJfw2IfIERputG4QAQHnu8bCEIkiR7Gx2QlNtOHmP6s54mShA1wEceVdHRiMB6VxSlyv0lWFt4TRSkwt67Vs9I3bdfjugMnVcqUwIMuDkVu2yqRdNozSif0A7qBlC97SBHC3pnuavkd1P+SePc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749251101; c=relaxed/simple; bh=QOivU9cCWOuD6+qnCQXHqwXBoofn756k+BYeNjlbNGU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=m/bQ1UTwbgQnGgJNKnIMYTACfszW40+BwgFhRKIW2Ye4hvXjcZMWeCMvACLbn9emKujk4nIT0XjJMR/EK3hYuUaTQ/TePNymX4Nh8woNE9p1h+d++yKMzXOm7g+xz9Dk2OtB4GAX31I6dILyVZqNOYd1dj0rbt9nsJuSiWzWtvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b=Dne/0Q5q; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b="Dne/0Q5q" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3121aed2435so2702568a91.2 for ; Fri, 06 Jun 2025 16:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20230601.gappssmtp.com; s=20230601; t=1749251099; x=1749855899; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=8FCwWKZSt8jlO+Nh8PWh4qO6V0jK1RFpZe2Cr7kkzR4=; b=Dne/0Q5qqaKrbXz7KduXx2zlzMNmN96B2q+Vin2OC0P4VIo0cmaoDMzAl+gtw0yBAH rNOedtEqBGRos+Ofv2R8YdHTWT/2YO2gwjfXRdoOoN4ZrUwUvEbJG4vgRR7lJtX7O9o4 WJ4/OI/Gm+odswFbLQRdW7D3eIbOyjuGzLXbXjRtPdIVEvFQZKs21nMGJrLlbcO24DTB lfeMf2ecidmiv4VBPYfKPe2li6Ju/BI0/8Rf97rmqmblgYsoEd5ZS7j2Y3r7T/XUE5N/ mB/gvBJnJu+GaG1bOVNHnOrH5nhNpDjznwi8P3+sYbJ2GKF9Yf8iILcLiJ3EZ1w5qi4X bckA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749251099; x=1749855899; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8FCwWKZSt8jlO+Nh8PWh4qO6V0jK1RFpZe2Cr7kkzR4=; b=Uybl6/2hZAdJCWxrCz78/S6ORyOm8xxBzO1gwyadrc1zSekJSSScB6K31j3DwV48Sk pkpWIBxEeVyRloOjF2S03eicGJpeahmiUI5KPX41ODSY5j3VG4ApG3lorZxCIFv4NeH6 WQr7axfws0ZZ+vBVp5lbsQ0trEtBxEPN76+SYNGGWBOczDH9/No3Gt4fVFarlf1sPCyn SwqYbehUxCeeLaJdgxaXJxl6pHAPu3+ClJdXK25NRnXj+YxtQxlJFY3VQm/aDKD7n9P6 E05xDLqEgKzG6NrpvXaJ71JnfS34c4lJqNDvCXOOuGr920epfwgcZzGSfrC39loPadTs pdeA== X-Forwarded-Encrypted: i=1; AJvYcCWYYUvUqeCk1bfg8BerzUlsWqqB3PrMH5nVHiLeoNeuuLp1kaIyGu4Mx/9FGZ8MfEYRkmz7p3RaT7JImjk=@vger.kernel.org X-Gm-Message-State: AOJu0YwqMELiP+SfHsloZzaZ4zmQRCYHi4ouxpD8SXcxhHNkNGXmEkn7 BbFj6fKx8z4P+yJiaQEkCttmDI93wYlteYBBwSnH3JmfdUMe/N8rb8lQAgAgRrOR0Iw= X-Gm-Gg: ASbGnctD1jXhS4yxUpQBNLqPAQIpn7Uem+VFIQ5xRdma9HoIyS0NOOK9tQyE7EfIhtd z57ap6/+m5RdE9xwUzWfWmxlhPY2FvEuhE6bNc+jX1msVxAsCZfxKAlqEl5mc1E/xwobIpja669 KlqLnLm7QJ4LJD1lei5sGyzOu6SYqi1qJr4rfvZ37dCp+OJyJ4Buf0E7F/5/mb+GtgAXwX1uq7F Rn1lFqWpPs6XO+09OjCeozspIFFaAJab9KB/8ub3oquSdf5s9U7ZdBkQDZ0cxY9jRir5RHhS88a mF+1p5XGqAQPAJQRqUDjqfblGpQAZtl6h+G4aE/LS6kS3U8fo2MJFTuJFXrzeWBl12ZCrf/4Put CQvUYY0rOdhDw9alq/WM1 X-Google-Smtp-Source: AGHT+IG64ChHlIEnH7AGZWP1roW4oYFooio9dxXqOSvuAYjcY7yPJNcaadXJ+ghoASQqymoWgh+a0A== X-Received: by 2002:a17:90b:4e83:b0:312:f54e:ba28 with SMTP id 98e67ed59e1d1-31347057c9amr8210172a91.24.1749251098933; Fri, 06 Jun 2025 16:04:58 -0700 (PDT) Received: from ?IPv6:2600:1700:6476:1430:77a3:4e60:32de:3fd? ([2600:1700:6476:1430:77a3:4e60:32de:3fd]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31349f32cc6sm1829579a91.11.2025.06.06.16.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 16:04:58 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/2] hfs: make splice write available again From: Viacheslav Dubeyko To: Christian Brauner Cc: "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Viacheslav Dubeyko , "frank.li@vivo.com" , "glaubitz@physik.fu-berlin.de" , "viro@zeniv.linux.org.uk" , "kees@kernel.org" Date: Fri, 06 Jun 2025 16:04:57 -0700 In-Reply-To: <604cca238cdecbbe3dee499b8363f31ddd9e63bc.camel@ibm.com> References: <20250529140033.2296791-1-frank.li@vivo.com> <20250529140033.2296791-2-frank.li@vivo.com> <604cca238cdecbbe3dee499b8363f31ddd9e63bc.camel@ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Christian, Could you please pick up the patch? Thanks, Slava. On Thu, 2025-05-29 at 18:28 +0000, Viacheslav Dubeyko wrote: > On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote: > > Since 5.10, splice() or sendfile() return EINVAL. This was > > caused by commit 36e2c7421f02 ("fs: don't allow splice read/write > > without explicit ops"). > >=20 > > This patch initializes the splice_write field in file_operations, > > like > > most file systems do, to restore the functionality. > >=20 > > Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without > > explicit ops") > > Signed-off-by: Yangtao Li > > --- > > =C2=A0fs/hfs/inode.c | 1 + > > =C2=A01 file changed, 1 insertion(+) > >=20 > > diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c > > index a81ce7a740b9..451115360f73 100644 > > --- a/fs/hfs/inode.c > > +++ b/fs/hfs/inode.c > > @@ -692,6 +692,7 @@ static const struct file_operations > > hfs_file_operations =3D { > > =C2=A0 .write_iter =3D generic_file_write_iter, > > =C2=A0 .mmap =3D generic_file_mmap, > > =C2=A0 .splice_read =3D filemap_splice_read, > > + .splice_write =3D iter_file_splice_write, > > =C2=A0 .fsync =3D hfs_file_fsync, > > =C2=A0 .open =3D hfs_file_open, > > =C2=A0 .release =3D hfs_file_release, >=20 > Makes sense. >=20 > Reviewed-by: Viacheslav Dubeyko >=20 > Thanks, > Slava.