From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbcIAIab (ORCPT ); Thu, 1 Sep 2016 04:30:31 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:52917 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbcIAIa3 (ORCPT ); Thu, 1 Sep 2016 04:30:29 -0400 Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards To: Bartlomiej Zolnierkiewicz References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com> <1472645679-5696-2-git-send-email-javier@osg.samsung.com> <3638650.aebblMKNhB@amdc1976> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Krzysztof Kozlowski From: Javier Martinez Canillas Message-ID: Date: Thu, 1 Sep 2016 10:30:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <3638650.aebblMKNhB@amdc1976> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Bartlomiej, On 08/31/2016 07:22 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote: >> The skeleton.dtsi file was removed in ARM64 for different reasons as >> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi"). >> >> These also applies to ARM and it will also allow to get rid of the >> following DTC warnings in the future: >> >> "Node /memory has a reg or ranges property, but no unit name" >> >> But these boards don't have a memory node defined, so removing the >> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the >> compiled DTB. Add a dummy memory node so the compiled DTB doesn't >> change if the skeleton.dtsi is removed from exynos4.dtsi. >> >> Eventually the correct starting addresses and sizes should be used >> but I didn't find that information. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> arch/arm/boot/dts/exynos5440-sd5v1.dts | 5 +++++ >> arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts >> index a98501bab6fc..333db4ff373a 100644 >> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts >> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts >> @@ -20,6 +20,11 @@ >> bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200"; >> }; >> >> + memory { >> + device_type = "memory"; >> + reg = <0 0>; >> + }; > > I think that this node deserves a FIXME comment. > Agreed. I'll add one in v2 for both nodes. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America