From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v1 2/3] thermal/debugfs: Pass cooling device state to thermal_debug_cdev_add()
Date: Thu, 25 Apr 2024 11:02:44 +0100 [thread overview]
Message-ID: <e9be06af-48bf-45ec-8d6d-6147d20b6780@arm.com> (raw)
In-Reply-To: <2181352.irdbgypaU6@kreacher>
Hi Rafael,
On 4/23/24 19:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If cdev_dt_seq_show() runs before the first state transition of a cooling
> device, it will not print any state residency information for it, even
> though it might be reasonably expected to print residency information for
> the initial state of the cooling device.
>
> For this reason, rearrange the code to get the initial state of a cooling
> device at the registration time and pass it to thermal_debug_cdev_add(),
> so that the latter can create a duration record for that state which will
> allow cdev_dt_seq_show() to print its residency information.
>
> Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information")
> Reported-by: Lukasz Luba <lukasz.luba@arm.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/thermal/thermal_core.c | 9 +++++++--
> drivers/thermal/thermal_debugfs.c | 12 ++++++++++--
> drivers/thermal/thermal_debugfs.h | 4 ++--
> 3 files changed, 19 insertions(+), 6 deletions(-)
>
I'm trying to test it on my board and do the review, but faced issue.
For some reason I couldn't apply that patch on the latest bleeding-edge
branch.
Could you help me in this please? Is there something missing in the
patch set (like one more fist patch)?
Regards,
Lukasz
next prev parent reply other threads:[~2024-04-25 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 17:29 [PATCH v1 0/3] thermal/debugfs: Fix handling of cdev states and mitigation episodes in progress Rafael J. Wysocki
2024-04-23 17:59 ` [PATCH v1 1/3] thermal/debugfs: Create records for cdev states as they get used Rafael J. Wysocki
2024-04-23 18:00 ` [PATCH v1 2/3] thermal/debugfs: Pass cooling device state to thermal_debug_cdev_add() Rafael J. Wysocki
2024-04-25 10:02 ` Lukasz Luba [this message]
2024-04-25 12:36 ` Rafael J. Wysocki
2024-04-25 13:00 ` Rafael J. Wysocki
2024-04-25 18:42 ` Lukasz Luba
2024-04-25 18:53 ` Rafael J. Wysocki
2024-04-25 18:55 ` Lukasz Luba
2024-04-25 19:10 ` Rafael J. Wysocki
2024-04-23 18:02 ` [PATCH v1 3/3] thermal/debugfs: Avoid printing zero duration for mitigation episodes in progress Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9be06af-48bf-45ec-8d6d-6147d20b6780@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®