From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sb1000: fix a couple of indentation issues
Date: Wed, 16 Jan 2019 16:20:59 -0800 [thread overview]
Message-ID: <e9c1698dcf0ef40eb15035cfb32d9b3456f197d6.camel@perches.com> (raw)
In-Reply-To: <20190117001301.29948-1-colin.king@canonical.com>
On Thu, 2019-01-17 at 00:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
[]
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
> if ((status = card_send_command(ioaddr, name, Command1, st)))
> return status;
> if (st[3] != 0xf1) {
> - if ((status = sb1000_start_get_set_command(ioaddr, name)))
> + if ((status = sb1000_start_get_set_command(ioaddr, name)))
Probably better to remove the assignment in the if at the same time.
status = sb1000_start_get_set_command(ioaddr, name);
if (status)
> return status;
> return -EIO;
> }
> udelay(1000);
> - return sb1000_start_get_set_command(ioaddr, name);
> + return sb1000_start_get_set_command(ioaddr, name);
> }
>
> /* get SB1000 firmware version */
next prev parent reply other threads:[~2019-01-17 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 0:13 Colin King
2019-01-17 0:20 ` Joe Perches [this message]
2019-01-18 5:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c1698dcf0ef40eb15035cfb32d9b3456f197d6.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®