From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012041.outbound.protection.outlook.com [40.107.209.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32A163537D2 for ; Thu, 5 Mar 2026 23:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.41 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772754746; cv=fail; b=u83NsS3nbvYteQ2UDE9dNJR003Fx1oiExDHp86ge01veJq1h2Gyek3NdHX4nzXF39qdGonRBSCdb35lZBe7ZlccCwi5DJUfKTNh0rrXaegXqLBskzYM+bB5xe1OpsUsqvEzv1Re2XNp2iVLkfpntQG6SsjOqO118TCofjAIoXbw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772754746; c=relaxed/simple; bh=PZvOvApeeYDfeXWLrBNTe3+CTMDU4v6xVGu2BMVkO00=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=pJrt3qkKjWHHAKSGqb56oGV21fNqaSMrea3Pxjm98U3h0uCr8v21YbKbrVIBebLZnYOP8jjPnsVrzI5wOUdzvc0KIdcW4cibOLNkxcs7qs+ifNK+WzEcTGjxa/0laSj+FDYR1OBa5tHME/nwwoFsR68kceXIAfCHgVuwPm4Khww= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cBaRtvLx; arc=fail smtp.client-ip=40.107.209.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cBaRtvLx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rPUwrC6GgcCj0lNKO31Rt1jXrx31xuU8e7MVa4q6rRH0RMs97PvfStdvg12HVyyZkpO3ZNVFft+TIt7pm0vvMN69r8WY0rvpkt49QKmGFftMTaWUJU5F5AgoSQEV6RTgtCWp3s8oCSEW4roAqIXTs3AW6kDmklzaYRH40ZDwecCFtSCMTXuVFhY74+dPczn+Px7FhW/ow0jWbJXuWkIajg94omYbzyMY83m4nlOibKRRDi4PD8+IGC+zAX1gGsHP6ybjKGsotYnKvbItljK8LLN1f0nNE7noYsE6DqRNL6AqBjITN+Qj12gNi9OoKd2Q+0w0qPKmvgA6idTI19/XMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=suuBH03UWr2oq3kN6HXjMu0dcI2L0V8Jf563QzI9caU=; b=ZKbUPSnoRqfsgli0bG5DH3lmymLFp/4RshOblVRqlbh6Tr51IGP5yTMWkFbCu/E0j2ymCfod9So75V2a3Y46KqMymr1vhC3S0ANw8I3/BKam0HimMMFD6QsmYeSRZhbSIa/zX2UOFse1AhW+rH1AapebVR0Z2etxJQoWQmLFRuvdQ+l+Oinn3m8vPGpb54uykd+abdGVpFivfdoTffaqFHtRAhchZUEjgXFoD3dwd4dgesgDwVzfjecRIHOWz7JE5K7BsoK7YnM7DZzdthbX6OK+zHkJ0P5L8py9+s+lX7xFZa8DNy4UV5CODbhb1C77/mYSVyNJMuDfooS7h+zryw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=suuBH03UWr2oq3kN6HXjMu0dcI2L0V8Jf563QzI9caU=; b=cBaRtvLxFPT+VFtaHVTz2pkaWy9VPAXMI0zXLfrkILmU1cBubvR/SxM47TUWiFqf+ebZdg2c+yyarim4gt2U0R763FiUrvM3Tv+RNfePnKeKdmfd7q58WSBc7zR1EuNZR1e5F6p/J5jFUCHuqzjiLuXTg0Qd6Uoh+1p0Hx14i1A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB8476.namprd12.prod.outlook.com (2603:10b6:8:17e::15) by BL3PR12MB6547.namprd12.prod.outlook.com (2603:10b6:208:38e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18; Thu, 5 Mar 2026 23:52:21 +0000 Received: from DM4PR12MB8476.namprd12.prod.outlook.com ([fe80::2d79:122f:c62b:1cd8]) by DM4PR12MB8476.namprd12.prod.outlook.com ([fe80::2d79:122f:c62b:1cd8%6]) with mapi id 15.20.9678.017; Thu, 5 Mar 2026 23:52:20 +0000 Message-ID: Date: Thu, 5 Mar 2026 16:52:18 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2] drm/amdgpu: Fix kernel-doc comments for some LUT properties To: Melissa Wen , Cristian Ciocaltea , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Harry Wentland Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260305-amdgpu-fix-kdoc-lut-v2-1-37947aca68e8@collabora.com> Content-Language: en-US From: Alex Hung In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR04CA0224.namprd04.prod.outlook.com (2603:10b6:303:87::19) To DM4PR12MB8476.namprd12.prod.outlook.com (2603:10b6:8:17e::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB8476:EE_|BL3PR12MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: a03387b4-2be3-4013-b0b1-08de7b123d3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: oUwCTyEHmoBjgFxFFnTt9NSrkkcOnqvdbfzzNi+2cXH0YEaWld45R6E3kBrZ5vl2cKwwMXe5WyDRTvzSjMGA55OFGldgopB50an/IcCAnmeKxxNTIHAEdzRqqZBlpEXtIfaUhU55CkfXrjZXWIMAmM+oXxHEuht1684giRTqYxJeaSC0D+pOuPPvpsI6hSWhqzRQQl0M6553OxqODQK+mMkhCsSlACT4rbUNEF8zghXBfTYibQONBSGerJtQH+/JOH/OfRzexy6zpZYgiZBRz9JjlmwHcRiG9DtQQ8lr7/3FjnKBDpDjLsU/F12e0zrXizbwwqevmbqUAtJrXJB29Gmk61zAnE2d7stMJXukBHIlbLaXX9WlVV+ydxkjjmD8CR/cK4yc4mFloFnxn2Fbp9EfC8FziqXsQhtfzOzO4lqdM1s08AlrOtJkLse/vvdfAaj2+rDrYgqsWSNCKF9GXx3yNCeA7irrZU7bGns6v38yPZNxbS0paDmLuPKiukFU1zlKk9KPkw3pOY3Rbg+poqpex/6aa8K7fkHRRIu69SARVx0r8x/rpfNo19ldS/O+f08hKYC0bqAmGXxCu9QVWddY/6mHx5lNLAJC++O6bmDcq4XD39U4uj6cKowhqav4phVkRxeph2P+0/3d6jqlVzqV6Vd79WE3mgES1s/fbUcsDOMYhCetyV5/ewoGWuUn7DdX74nghk1556R9WsuJknEj2JmJOpakGqjWKFPjruvYXB1hWT/8zDr+X3r8m77q X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB8476.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFk3WUdDKzZIbmU4aWJ5NS9VbVNocTRnbEF4eEhkV2NHUEJrMHBmMTA2clhU?= =?utf-8?B?S24wN3pVOFU4QWFzSkVublo5Tm9uQzZNT2lwMXdkckcrTUdGTVBmUGkvRmFk?= =?utf-8?B?WmVXYi91YnJCZU1wOXVwWHEydXFvRE1pL0lLTUhtbE1haEU2dWNtVnl5RUZ6?= =?utf-8?B?VU1XNUNocDhxYXh2RnFIaFFLZm9PRFNRLzRrQ1NzUlhOTGdDU1owZVg5RG5p?= =?utf-8?B?dnRjQ0ZxdFRJWkxUbzhEdkJmVjYvcVV2SmkzT1lJUE9IZU9YN0pMd0k0S3Z6?= =?utf-8?B?M3ZVQktTa3Y0bzVNWXBzUG5vRFV3bU9TYmVsQkhzNHUvSW5Lay9nVmRuWkk0?= =?utf-8?B?cEZLMld2N2t2N010aDZnQ2pTQ1NDaWMzb3VxNUZ3Mzg0OWZPTzRSUHZFTkhn?= =?utf-8?B?Q2RLSG5MMmhOR1dOdG93WTkxYmVvR0FmVXlSM3dFVURSWU5EbFJmNzBIenhP?= =?utf-8?B?dy91eFVPWjQwRDNiMWQydXJFUkJHUGZRWUxQUEx4ek1SSEdYYXFRa2h3em1E?= =?utf-8?B?UlNsM3U4QVRiRFg4S0JFZ1gySVVIbHY3OSsvUnVvSEFUbURKYnlyOTczaGcx?= =?utf-8?B?eFJoRjRqSmRtVDl3RlppRSt5cVR0MFpGTmdOajVBS1JoUUdaR3dNRWNPTEpC?= =?utf-8?B?STRQRGRab0xHOTYzQXRUQ29FOGsvbiswdDlDamxGVTRmc3lUNmM2dzFiU3FU?= =?utf-8?B?a09CNERlWExwVytnTmZDT24wUzFadkJZZjFOb3dhUUpVdytrTEJVekk5ZC9u?= =?utf-8?B?czlIcmxic1RJN09GSXNTVldyRlI2TEpDVnVGaTloNTllNnZ1dkQwWnJzU1M5?= =?utf-8?B?WU9VWUdRSU4vMGV4bXlGWWRSekw2SmMzZWlVeGJMNmJ1c1BQdi9qWHVtVmNa?= =?utf-8?B?TzVHdktOZTdyOS8reHdack1vRFN6bU5nbjQ2aEtsY0dlZ1lWVTM3MGlmblEv?= =?utf-8?B?MTNOVHBWWVcyWjNiRzViNzV6Ky9WaklxbnR1TXNhelIyY1NHdDIvamthWTFF?= =?utf-8?B?UXloVjJSYXFONTNncHlQaGR3UnVYbjQ5N09Xa0RuNVc5dE53dHVhOW9vY2Ex?= =?utf-8?B?d1A4dmJOalgzMVExZFA3ZVlENHdZZ21VNHZubFp4dzE1V3RnME9FWitqR0xZ?= =?utf-8?B?YXoyUHZiMlVYWDluTTU5dnNpSTBXUjVTTnhDSmlJT0EyRzdoSmRqOVFxUHo4?= =?utf-8?B?UGN0Z0UzbDF1WWdrekFSTTROWTREYk9vYnBBU1JrMmNUM0JDSjBibDNKS0Y4?= =?utf-8?B?QXhXNU4xSFdTUHl5NlZ5a0MxMlJBaHNZVk0xcUFnLytaZGh6NVVjV3BML3BB?= =?utf-8?B?NDdzdkxQRXhpSnZrSFVxTDRnRHNsd2V1RVNNMlFRRTNPT2xaRElPSjJNSmE0?= =?utf-8?B?S2NyREFKNTF0VXJpcjJvL0pFQjZYOEpnZHg5TWJWdW9ZRjI3MEF3NE1sd2Fv?= =?utf-8?B?UUFxZ2tmRDlWd2k4QnUvcXFWVkRmK2xETXBDQTdDWnIwMGVmc3BvVlEvRlRi?= =?utf-8?B?U0pPZmpkcDZpRWpyK0d3eTFQUVBKWVBNRlROUzJHdk5PV3dwOHJ1MWM4ME91?= =?utf-8?B?TU9XVnFCYnQzb0pBZ3VaTlNuZHJqYkN4dEU4YlNNenM1MHJJWW1xbnBCYUZs?= =?utf-8?B?cFVTSUk3d0UzSXc1OFpDcGQ5eUZESU5sekpTRzFjb3RvajNoVU92bHZ5K2k1?= =?utf-8?B?dG9YYjVNUTN2djdnNURlaUhoOVRnSVJ3TlZyeU1QdzQ1SGN4UTQxUW8rbFZT?= =?utf-8?B?RHhhZ1BHZEN4cmEyWkRtMFpyeXcyaWtmZm1sTm14b3NhSjhmV0EvVVhXbS9Q?= =?utf-8?B?cXVCWEZVQ1d0YTZ4OXhwRWYrWmF1aGt5ZmlJN3RQOHNNb3hGT3BDZkY1dkNO?= =?utf-8?B?M2Y3T3JobGtnMytqWFBKdXpoZmJaZUhraTJMQndPSnY2eSsyQmdDS2VPb1ZL?= =?utf-8?B?YllTUFU3YUkzbGt4M1l0cFJxWSt3b0o3aHNOcTFOTytDckVvZkdnYXZtdHBM?= =?utf-8?B?ajhsUW1vbEk0eEJFd2s0eUNKaVNWem9LZm84cHF0MnA1OVFnQmFGODk5M2lq?= =?utf-8?B?cmdrdFZEeTFWcTZraGlHcCtVZ3lvWU1uSExXendiMFNFNTdHWXFJQjlCQTFJ?= =?utf-8?B?TGRtM3U4aVozT0k2UlVxS0s4bTV2NVJoSjJWY0NWeDZ2RXMrbS9ISWpGTzlz?= =?utf-8?B?dW9zUnpCU1ZDcVo0N2lFbkRPb2JCVExPZ2FmZDluOVJTeFozMHJVdUEyMnMr?= =?utf-8?B?MFkrdTZKYk9BVFRwUGt2QjRsVmVFSHRjbEhad3h2NjNCbXpkMlhKMmRYQmZU?= =?utf-8?Q?upE0XL81eR0y8POyEl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a03387b4-2be3-4013-b0b1-08de7b123d3e X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB8476.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2026 23:52:20.1742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EW+spGpeerMHvXoCrWQP6T4permZV8FtXEDtJ3S+CA+D5uYAY4jkR+t0fb/qOluJg47dsmNjPvorZNCc6AO0dA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6547 Applied. Thanks for the fixes. On 3/5/26 11:00, Melissa Wen wrote: > + cc: Alex Hung > > Hi Alex H., > > Can you apply this patch? > > Thanks, > > Melissa > > On 05/03/2026 08:16, Cristian Ciocaltea wrote: >> The following members of struct amdgpu_mode_info do not have valid >> references in the related kernel-doc sections: >> >>   - plane_shaper_lut_property >>   - plane_shaper_lut_size_property, >>   - plane_lut3d_size_property >> >> Correct all affected comment blocks. >> >> Fixes: f545d82479b4 ("drm/amd/display: add plane shaper LUT and TF >> driver-specific properties") >> Fixes: 671994e3bf33 ("drm/amd/display: add plane 3D LUT driver- >> specific properties") >> Reviewed-by: Melissa Wen >> Signed-off-by: Cristian Ciocaltea >> --- >> Changes in v2: >> - Collected R-b tag from Melissa >> - Rebased onto latest drm-misc-next >> - Link to v1: https://lore.kernel.org/r/20250823-amdgpu-fix-kdoc-lut- >> v1-1-306bcad41267@collabora.com >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 16 ++++++++-------- >>   1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/ >> drm/amd/amdgpu/amdgpu_mode.h >> index dc8d2f52c7d6..e244c12ceb23 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h >> @@ -368,15 +368,15 @@ struct amdgpu_mode_info { >>       struct drm_property *plane_ctm_property; >>       /** >> -     * @shaper_lut_property: Plane property to set pre-blending >> shaper LUT >> -     * that converts color content before 3D LUT. If >> -     * plane_shaper_tf_property != Identity TF, AMD color module will >> +     * @plane_shaper_lut_property: Plane property to set pre-blending >> +     * shaper LUT that converts color content before 3D LUT. >> +     * If plane_shaper_tf_property != Identity TF, AMD color module will >>        * combine the user LUT values with pre-defined TF into the LUT >>        * parameters to be programmed. >>        */ >>       struct drm_property *plane_shaper_lut_property; >>       /** >> -     * @shaper_lut_size_property: Plane property for the size of >> +     * @plane_shaper_lut_size_property: Plane property for the size of >>        * pre-blending shaper LUT as supported by the driver (read-only). >>        */ >>       struct drm_property *plane_shaper_lut_size_property; >> @@ -400,10 +400,10 @@ struct amdgpu_mode_info { >>        */ >>       struct drm_property *plane_lut3d_property; >>       /** >> -     * @plane_degamma_lut_size_property: Plane property to define the >> max >> -     * size of 3D LUT as supported by the driver (read-only). The max >> size >> -     * is the max size of one dimension and, therefore, the max >> number of >> -     * entries for 3D LUT array is the 3D LUT size cubed; >> +     * @plane_lut3d_size_property: Plane property to define the max size >> +     * of 3D LUT as supported by the driver (read-only). The max size is >> +     * the max size of one dimension and, therefore, the max number of >> +     * entries for 3D LUT array is the 3D LUT size cubed. >>        */ >>       struct drm_property *plane_lut3d_size_property; >>       /** >> >> --- >> base-commit: be4cd2a13a31496c7fb9e46a244c4391b8b7cf31 >> change-id: 20250823-amdgpu-fix-kdoc-lut-357db8b57fee >