mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dan Williams" <dan.j.williams@intel.com>
To: "Zhang Wei" <Wei.Zhang@freescale.com>
Cc: linux-kernel@vger.kernel.org,
	"Zhu Ebony" <ebony.zhu@freescale.com>,
	galak@kernel.crashing.org
Subject: Re: [PATCH v2] Add DMA engine driver for Freescale MPC85xx processors.
Date: Thu, 10 Jan 2008 11:21:47 -0700	[thread overview]
Message-ID: <e9c3a7c20801101021n7aa37bdrd6255245a773546e@mail.gmail.com> (raw)

On Jan 10, 2008 3:10 AM, Zhang Wei <Wei.Zhang@freescale.com> wrote:
> I think your patch is good. What should I do next?
>
> Cheers!
> Wei.
>

I do not think all the review comments have been addressed, for
example my earlier comments about GFP_ATOMIC and spin_lock_irqsave
[1].  We have two options to take this forward:

1/ Continue to carry this in the async-tx tree and get an
Acked-by/Reviewed-by tag from Kumar.
2/ Move this to Kumar's tree, and coordinate our pull requests to have
the async-tx updates hit first.

I prefer option 1, but I will defer to Kumar.

Thanks,
Dan

[1] http://marc.info/?l=linux-kernel&m=118936050531240&w=2

             reply	other threads:[~2008-01-10 18:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 18:21 Dan Williams [this message]
2008-01-22  8:25 ` Zhang Wei
2008-02-07 17:16   ` Timur Tabi
  -- strict thread matches above, loose matches on Subject: below --
2007-10-30  9:25 Zhang Wei
2008-01-10  0:55 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20801101021n7aa37bdrd6255245a773546e@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=Wei.Zhang@freescale.com \
    --cc=ebony.zhu@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®