From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761539AbYDNXqR (ORCPT ); Mon, 14 Apr 2008 19:46:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756946AbYDNXp7 (ORCPT ); Mon, 14 Apr 2008 19:45:59 -0400 Received: from yw-out-2324.google.com ([74.125.46.28]:24988 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662AbYDNXp6 (ORCPT ); Mon, 14 Apr 2008 19:45:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=QsQ9I1uK2xNnJlqz0y/425c4hnOBdJV/+V8WZbB5QwfH9EqwrkZgBg2kCNveErJ0W15lRhsAta+TllV/THcfXspSYyI6m0WQ8fvB+zjCzKNoiQI/Gq8M7VDO6A+o31bI/BaHdzJo71ggKoDWNRpjw1Bmxe/1cBE0YknaiVRWYNk= Message-ID: Date: Mon, 14 Apr 2008 16:45:37 -0700 From: "Dan Williams" To: "Mike Frysinger" Subject: Re: [2.6 patch] add include/asm-avr32/xor.h Cc: "Adrian Bunk" , "Sebastian Siewior" , hskinnemoen@atmel.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@intel.com In-Reply-To: <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080414141632.GA6695@cs181133002.pp.htv.fi> <20080414181140.GA813@Chamillionaire.breakpoint.cc> <20080414181536.GZ6695@cs181133002.pp.htv.fi> <20080414214640.GA2282@Chamillionaire.breakpoint.cc> <20080414220129.GH26885@cs181133002.pp.htv.fi> <8bd0f97a0804141511o28385fcfl11923148f7fe701a@mail.gmail.com> <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com> X-Google-Sender-Auth: b1615b83e77545b5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 14, 2008 at 3:30 PM, Mike Frysinger wrote: > On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams wrote: > > "arches" did not have to go through and figure out the fun little stub > > file for xor.h. Adrian already made your "life easier". > > actually he didnt. he posted a fix for avr32. i dont care about > avr32, i'm a blackfin guy. he also wouldnt have had to do anything at > all if everything was handled with indirection in linux/xor.h. > > your point also is irrelevant in the case of new architectures. poor > microblaze for example. > Don't get me wrong I see the pain-reducing-value in codifying all the features that have architecture specific aspects with HAVE_* config variables. But in this case I think a 6 line patch per new arch gets the immediate job done. Regards, Dan