From: "Dan Williams" <dan.j.williams@intel.com>
To: "Maciej Sosnowski" <maciej.sosnowski@intel.com>
Cc: shannon.nelson@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] I/OAT: tcp_dma_copybreak default value dependant on I/OAT version
Date: Fri, 11 Jul 2008 12:20:15 -0700 [thread overview]
Message-ID: <e9c3a7c20807111220q432e712q734e075e6d533e5c@mail.gmail.com> (raw)
In-Reply-To: <20080711113703.337.72444.stgit@linux.site>
On Fri, Jul 11, 2008 at 4:37 AM, Maciej Sosnowski
<maciej.sosnowski@intel.com> wrote:
> I/OAT DMA performance tuning showed different optimal values
> of tcp_dma_copybreak for different I/OAT versions
> (4096 for 1.2 and 2048 for 2.0).
> This patch lets ioatdma driver set tcp_dma_copybreak value
> according to these results.
>
> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
> ---
>
> drivers/dma/dmaengine.c | 3 +++
> drivers/dma/ioat_dma.c | 15 +++++++++++++++
> include/linux/dmaengine.h | 2 ++
> 3 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 97b329e..d57365a 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -70,6 +70,7 @@ #include <linux/percpu.h>
> #include <linux/rcupdate.h>
> #include <linux/mutex.h>
> #include <linux/jiffies.h>
> +#include <net/tcp.h>
>
> static DEFINE_MUTEX(dma_list_mutex);
> static LIST_HEAD(dma_device_list);
> @@ -402,6 +403,8 @@ int dma_async_device_register(struct dma
> list_add_tail(&device->global_node, &dma_device_list);
> mutex_unlock(&dma_list_mutex);
>
> + sysctl_tcp_dma_copybreak = device->tcp_dma_copybreak;
> +
Hi Maciej,
When NET_DMA is not enabled this breaks the build. Also, given that
NET_DMA is only beneficial on architectures with i/o coherent caches
this fix up should be done directly in the driver, not passed up to
the common core.
Regards,
Dan
next prev parent reply other threads:[~2008-07-11 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 11:36 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-11 11:36 ` [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver Maciej Sosnowski
2008-07-11 20:07 ` Dan Williams
2008-07-18 15:53 ` Sosnowski, Maciej
2008-07-11 11:37 ` [PATCH 2/2] I/OAT: tcp_dma_copybreak default value dependant on I/OAT version Maciej Sosnowski
2008-07-11 19:20 ` Dan Williams [this message]
2008-07-18 15:55 ` Sosnowski, Maciej
2008-07-14 13:23 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-14 13:25 ` [PATCH 2/2] I/OAT: tcp_dma_copybreak default value dependant on I/OAT version Maciej Sosnowski
2008-07-14 13:27 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-14 13:28 ` [PATCH 2/2] I/OAT: tcp_dma_copybreak default value dependant on I/OAT version Maciej Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c20807111220q432e712q734e075e6d533e5c@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®