mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dan Williams" <dan.j.williams@intel.com>
To: "Brice Goglin" <Brice.Goglin@inria.fr>
Cc: "Maciej Sosnowski" <maciej.sosnowski@intel.com>,
	shannon.nelson@intel.com, linux-kernel@vger.kernel.org,
	net-dev@vger.kernel.org
Subject: Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver
Date: Fri, 18 Jul 2008 11:16:38 -0700	[thread overview]
Message-ID: <e9c3a7c20807181116s49982f98p8d56a6e5e8264e6e@mail.gmail.com> (raw)
In-Reply-To: <487B6004.6090801@inria.fr>

On Mon, Jul 14, 2008 at 7:17 AM, Brice Goglin <Brice.Goglin@inria.fr> wrote:
> Maciej Sosnowski wrote:
>> Due to occasional DMA channel hangs observed for I/OAT versions 1.2 and 2.0
>> a watchdog has been introduced to check every 2 seconds
>> if all channels progress normally.
>> If stuck channel is detected, driver resets it.
>> The reset is done in two parts. The second part is scheduled
>> by the first one to reinitialize the channel after the restart.
>>
>
> Is all this transparent to the caller? Are you reposting all copies to
> the hardware after the reset? Or are we going to get some DMA_ERROR
> return values ?
>
>> Sleep time in self_test has been increased to 10ms
>> since in some cases 1ms appeared not to be enough
>
> Thanks Maciej, this helps a lot here.
>

Can I interpret this as a "Tested-by" for the watchdog and/or the self_test fix?

> Brice

Thanks,
Dan

  parent reply	other threads:[~2008-07-18 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 13:23 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-14 13:24 ` [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver Maciej Sosnowski
2008-07-14 14:17   ` Brice Goglin
2008-07-18 16:06     ` Sosnowski, Maciej
2008-07-18 18:16     ` Dan Williams [this message]
2008-07-18 21:51       ` Brice Goglin
2008-07-22 23:27         ` Dan Williams
2008-07-14 13:25 ` [PATCH 2/2] I/OAT: tcp_dma_copybreak default value dependant on I/OAT version Maciej Sosnowski
  -- strict thread matches above, loose matches on Subject: below --
2008-07-14 13:27 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-14 13:28 ` [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver Maciej Sosnowski
2008-07-11 11:36 [PATCH 0/2] I/OAT: watchdog/reset and tcp_dma_copybreak Maciej Sosnowski
2008-07-11 11:36 ` [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver Maciej Sosnowski
2008-07-11 20:07   ` Dan Williams
2008-07-18 15:53     ` Sosnowski, Maciej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20807181116s49982f98p8d56a6e5e8264e6e@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=Brice.Goglin@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    --cc=net-dev@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®