From: "Dan Williams" <dan.j.williams@intel.com>
To: "Timur Tabi" <timur@freescale.com>
Cc: linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
leoli@freescale.com
Subject: Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module
Date: Tue, 23 Sep 2008 13:46:44 -0700 [thread overview]
Message-ID: <e9c3a7c20809231346q264cc764s703af8b9e386e445@mail.gmail.com> (raw)
In-Reply-To: <48D8074F.9030106@freescale.com>
On Mon, Sep 22, 2008 at 1:59 PM, Timur Tabi <timur@freescale.com> wrote:
> Dan Williams wrote:
>
>> The last three hunks should be broken out into a separate 'fix' patch
>> with its own changelog.
>
> Can you be more specific? I can see how "return 0" -> "return -ENOMEM" could be
> separated out, but the Kconfig hunk is integral to the patch, and the "if
> (fsl_chan->desc_pool) return 1;" is needed to prevent a memory leak if the
> module is unloaded.
>
Sorry, I miscounted. I was indeed referring to the just the "return 0
--> return -ENOMEM" fix.
--
Dan
next prev parent reply other threads:[~2008-09-23 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 16:24 Timur Tabi
2008-09-20 21:32 ` Dan Williams
2008-09-22 20:59 ` Timur Tabi
2008-09-23 20:46 ` Dan Williams [this message]
2008-09-19 15:11 Timur Tabi
2008-09-24 18:30 ` Kumar Gala
2008-09-24 18:31 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c20809231346q264cc764s703af8b9e386e445@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®