From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757499AbYKURRu (ORCPT ); Fri, 21 Nov 2008 12:17:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755490AbYKURRi (ORCPT ); Fri, 21 Nov 2008 12:17:38 -0500 Received: from wf-out-1314.google.com ([209.85.200.171]:2823 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755116AbYKURRh (ORCPT ); Fri, 21 Nov 2008 12:17:37 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=lnnYKBnVmS5D/+/8CTdCPxeJOlBHBpB0Axd6zqa8KwV4eviPx5hAZd45cnAWnhVN+6 6N01AKxRneZG0ivKHflxRzMb//50DBdLAgAtpzCJBRkmIMQhCI2tTq0cCGotoy2O/FzI YDlHI6BJad1H1vURddtcftfOdjwdoDeFKNWBQ= Message-ID: Date: Fri, 21 Nov 2008 10:17:36 -0700 From: "Dan Williams" To: "Alexander Beregalov" Subject: Re: next-20081121:WARNING: at drivers/dma/dmaengine.c:665 dma_async_device_unregister() Cc: linux-next@vger.kernel.org, LKML , maciej.sosnowski@intel.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: 29d2ad07a0fbc90a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 21, 2008 at 3:40 AM, Alexander Beregalov wrote: > Hi > > It occured during shutdown process: > > sd 0:2:0:0: [sda] Synchronizing SCSI cache > ioatdma 0000:00:08.0: Removing dma and dca services > ------------[ cut here ]------------ > WARNING: at drivers/dma/dmaengine.c:665 dma_async_device_unregister+0x90/0xd0() > dma_async_device_unregister called while 1 clients hold a reference > Modules linked in: > Pid: 12246, comm: reboot Tainted: G W 2.6.28-rc5-next-20081121 #8 > Call Trace: > [] warn_slowpath+0xae/0xd5 > [] ? add_partial+0x1a/0x50 > [] ? dma_async_device_unregister+0x22/0xd0 > [] ? trace_hardirqs_on_caller+0x1f/0x153 > [] ? __mutex_lock_common+0x371/0x3be > [] ? dma_async_device_unregister+0x22/0xd0 > [] ? trace_hardirqs_on_caller+0x1f/0x153 > [] ? trace_hardirqs_on+0xd/0xf > [] ? __mutex_unlock_slowpath+0x13c/0x145 > [] dma_async_device_unregister+0x90/0xd0 > [] ioat_dma_remove+0x1c/0xd0 > [] ioat_shutdown_functionality+0x66/0x74 > [] pci_device_shutdown+0x24/0x38 > [] device_shutdown+0x50/0x99 > [] kernel_restart_prepare+0x27/0x2e > [] kernel_restart+0x11/0x44 > [] sys_reboot+0x11d/0x149 > [] ? hrtimer_nanosleep+0x104/0x119 > [] ? hrtimer_wakeup+0x0/0x21 > [] ? do_nanosleep+0x50/0xb6 > [] ? trace_hardirqs_on_caller+0x1f/0x153 > [] ? trace_hardirqs_on_thunk+0x3a/0x3f > [] system_call_fastpath+0x16/0x1b > ---[ end trace 4eaa2a86a8e2da22 ]--- Looks like the network stack needs to drop its reference to dmaengine at shutdown. Need to investigate if netdev_exit is the proper location for this... > ------------[ cut here ]------------ > WARNING: at drivers/base/core.c:122 device_release+0x66/0x68() > Device 'dma0chan0' does not have a release() function, it is broken and must be > fixed. > Modules linked in: > Pid: 12246, comm: reboot Tainted: G W 2.6.28-rc5-next-20081121 #8 > Call Trace: > [] warn_slowpath+0xae/0xd5 > [] ? release_sysfs_dirent+0x7d/0x9d > [] ? __sysfs_put+0x18/0x1a > [] ? sysfs_addrm_finish+0x233/0x27b > [] ? ifind+0x2c/0x84 > [] ? trace_hardirqs_on+0xd/0xf > [] ? mutex_trylock+0x146/0x15a > [] ? sysfs_addrm_start+0x78/0xa5 > [] ? sysfs_addrm_start+0x78/0xa5 > [] ? kobj_kset_leave+0x1e/0x57 > [] device_release+0x66/0x68 > [] kobject_release+0x52/0x68 > [] ? kobject_release+0x0/0x68 > [] kref_put+0x43/0x4f > [] kobject_put+0x47/0x4b > [] put_device+0x15/0x17 > [] device_unregister+0x19/0x1e > [] dma_async_device_unregister+0xa4/0xd0 > [] ioat_dma_remove+0x1c/0xd0 > [] ioat_shutdown_functionality+0x66/0x74 > [] pci_device_shutdown+0x24/0x38 > [] device_shutdown+0x50/0x99 > [] kernel_restart_prepare+0x27/0x2e > [] kernel_restart+0x11/0x44 > [] sys_reboot+0x11d/0x149 > [] ? hrtimer_nanosleep+0x104/0x119 > [] ? hrtimer_wakeup+0x0/0x21 > [] ? do_nanosleep+0x50/0xb6 > [] ? trace_hardirqs_on_caller+0x1f/0x153 > [] ? trace_hardirqs_on_thunk+0x3a/0x3f > [] system_call_fastpath+0x16/0x1b > ---[ end trace 4eaa2a86a8e2da22 ]--- With the old reference counting scheme we apparently never released the dma class devices. I'll address this. Strange that this did not trigger on my iop13xx platform... Thanks for the report, Dan