From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761453AbZBYVzA (ORCPT ); Wed, 25 Feb 2009 16:55:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757372AbZBYVyv (ORCPT ); Wed, 25 Feb 2009 16:54:51 -0500 Received: from rv-out-0506.google.com ([209.85.198.226]:19453 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757300AbZBYVyu convert rfc822-to-8bit (ORCPT ); Wed, 25 Feb 2009 16:54:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=lmGegasZFE8W7vbh0Jf/7Cg4Q6shwMPBapEs9ATMVgv2bloMRsn08PRMiAARsfA46j jI4t+xONPBRYTu+BFgKAJ2mJ/b0FnNJbdTMDoaBkiFk8YVgbOdpyhsKgF/EqXXAbaL3z yM7aFflmcu4Y8PvuaYryOymXuoZtC+RIUKRGo= MIME-Version: 1.0 In-Reply-To: <1235068604.18650.16.camel@dwillia2-linux.ch.intel.com> References: <4974F208.3020407@intel.com> <1235068604.18650.16.camel@dwillia2-linux.ch.intel.com> Date: Wed, 25 Feb 2009 14:54:48 -0700 X-Google-Sender-Auth: d5aa2764baf53147 Message-ID: Subject: Re: [PATCH 3/4 v9] i.MX31: framebuffer driver From: Dan Williams To: Sascha Hauer Cc: Guennadi Liakhovetski , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 19, 2009 at 11:36 AM, Dan Williams wrote: > On Thu, 2009-02-19 at 07:41 -0700, Guennadi Liakhovetski wrote: >> Please, oh, please, wake me up if I'm dreaming... In the patch below all >> the indentation in _both_ mx3fb.h and mx3fb.c is with TABs (ok, didn't >> check all, a couple). Nun im Linus' git-tree - _ALL_ (that I checked) >> indentation is with... BLANKS!!!??? Could someone, please, tell me what >> was in that cup of tee I've drunk an hour ago?... Dan, you pushed this >> patch via your tree, right? Could you double-check, please? >> > > What a mess.  The other patches in your series were applied and > checkpatched from the tarball you sent.  This last fix up patch was not > cc'd to lkml so I fell back to applying it from a saved Thunderbird > message.  The real issue is that I did not have checkpatch automated > from StackedGIT's import command.  Please double check the fix below... > Sascha, Will you be taking this clean-up through your tree? I don't think it is suitable for 2.6.29 and in my opinion it belongs with other IMX platform driver fixups targeted for 2.6.30. Thoughts? -- Dan