From: Dan Williams <dan.j.williams@intel.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] iop-adma, dmaengine: misplaced curly brackets?
Date: Mon, 2 Mar 2009 16:25:22 -0700 [thread overview]
Message-ID: <e9c3a7c20903021525jff8e2d4qf848a92dced8be93@mail.gmail.com> (raw)
In-Reply-To: <49A53FF5.1020509@gmail.com>
On Wed, Feb 25, 2009 at 5:56 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> I observed this by code inspection, and it was not tested in any way,
> but aren't the curly brackets below wrong?
>
> please review.
> ------------------------------>8-------------8<---------------------------------
> Misplaced curly brackets.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
Yes, static analysis caught this error here recently as well. I have
applied your patch with a fixed up changelog:
commit d2076514c9ea68e7fef21158c1cdb8b244bfe5f2
Author: Roel Kluin <roel.kluin@gmail.com>
Date: Wed Feb 25 13:56:21 2009 +0100
iop-adma, mv_xor: fix mem leak on self-test setup failure
iop_adma_zero_sum_self_test has the brackets in the wrong place for the
setup failure deallocation path. This error was duplicated in
mv_xor_xor_self_test.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Thanks,
Dan
prev parent reply other threads:[~2009-03-02 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 12:56 Roel Kluin
2009-03-02 23:25 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c20903021525jff8e2d4qf848a92dced8be93@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®