From: Dan Williams <dan.j.williams@intel.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
haavard.skinnemoen@atmel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: Fix oops on dmatest module unload.
Date: Wed, 4 Mar 2009 16:03:47 -0700 [thread overview]
Message-ID: <e9c3a7c20903041503lb2f55fct3ec39f268e609317@mail.gmail.com> (raw)
In-Reply-To: <e9c3a7c20902121612q724d0931ifb70d559081f206d@mail.gmail.com>
On Thu, Feb 12, 2009 at 5:12 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Thu, Feb 12, 2009 at 5:30 AM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
>> This patch fixes an oops that happens when the dmatest module is unloaded. The
>> dma_release_channel() function is called on channels that have already been
>> cleaned up (and therefore freed) with dmatest_cleanup_channel().
>>
>> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Thanks, applied with Atsushi's ack.
>
...and now it is unapplied :-). The problem with this patch is that
it releases the channel before dmatest is done with it. 'Cleanup'
followed by 'release' is the right order, just need to save ->chan
before it gets freed.
--
Dan
next prev parent reply other threads:[~2009-03-04 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 9:31 [PATCH] " Thierry Reding
2009-02-12 11:48 ` Atsushi Nemoto
2009-02-12 12:30 ` [PATCH v2] " Thierry Reding
2009-02-13 0:12 ` Dan Williams
2009-03-04 23:03 ` Dan Williams [this message]
2009-03-06 11:13 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c20903041503lb2f55fct3ec39f268e609317@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®