mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Guennadi Liakhovetski <lg@denx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipu_idmac: code clean-up and robustness improvements
Date: Mon, 16 Mar 2009 14:59:33 -0700	[thread overview]
Message-ID: <e9c3a7c20903161459n8ad3c6qd705d146703b28a1@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903130837040.4653@axis700.grange>

On Fri, Mar 13, 2009 at 12:41 AM, Guennadi Liakhovetski <lg@denx.de> wrote:
> General code clean-up: remove superfluous semicolons, update comments.
> Robustness improvements: add DMA error handling to the ISR, move common code
> fragments to functions, fix scatter-gather element queuing in the ISR, survive
> channel freeing and re-allocation in a quick succession.
>
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
> ---
>
> Dan, I've been using this patch for a while, without any need for a
> change, so, it should be fine to go upstream.
>

Are you sure that we will never want to bisect in between these
several topics?  I would feel more comfortable with at least the fixes
separated from the code refactoring/pure additions.

Thanks,
Dan

  reply	other threads:[~2009-03-16 21:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13  7:41 Guennadi Liakhovetski
2009-03-16 21:59 ` Dan Williams [this message]
2009-03-23 10:10   ` [PATCH 0/3 v2] " Guennadi Liakhovetski
2009-03-23 10:10     ` [PATCH 1/3 v2] dma: ipu_idmac driver cosmetic clean-up Guennadi Liakhovetski
2009-03-23 10:10     ` [PATCH 2/3 v2] dma: improve section assignment in i.MX31 IPU DMA driver Guennadi Liakhovetski
2009-03-23 10:11     ` [PATCH 3/3 v2] dma: i.MX31 IPU DMA robustness improvements Guennadi Liakhovetski
2009-03-25  2:15     ` [PATCH 0/3 v2] ipu_idmac: code clean-up and " Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20903161459n8ad3c6qd705d146703b28a1@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=lg@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®