mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
	linux-kernel@vger.kernel.org, haavard.skinnemoen@atmel.com
Subject: Re: [PATCH 1/2] dmaengine: TXx9 Soc DMA Controller driver
Date: Tue, 17 Mar 2009 18:23:46 -0700	[thread overview]
Message-ID: <e9c3a7c20903171823g1e6c42b9t5f042d550a6ddd47@mail.gmail.com> (raw)
In-Reply-To: <20090318.094935.238694196.nemoto@toshiba-tops.co.jp>

On Tue, Mar 17, 2009 at 5:49 PM, Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Tue, 17 Mar 2009 10:02:14 -0700, Dan Williams <dan.j.williams@intel.com> wrote:
> BTW, there are another holes in dma_async_device_register.  If
> idr_pre_get or idr_get_new was failed, idr_ref will not be freed.

Thanks for these fixlets, I appreciate it.

Now, back to the issue at hand.  Does your driver still need direct
control over chan->chan_id, or can it now rely on the fact that
dma_async_device_register() will fail if a channel is not initialized?
 Or, just use some platform_data to identify the channel in the same
manner as atmel-mci?

Regards,
Dan

  reply	other threads:[~2009-03-18  1:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 15:28 Atsushi Nemoto
2009-02-26  1:45 ` Dan Williams
2009-02-26 15:24   ` Atsushi Nemoto
2009-03-12 16:19     ` Atsushi Nemoto
2009-03-13 14:16       ` Atsushi Nemoto
2009-03-16 21:50         ` Dan Williams
2009-03-17  2:20           ` Atsushi Nemoto
2009-03-17  4:52             ` Dan Williams
2009-03-17 16:09               ` Atsushi Nemoto
2009-03-17 17:02                 ` Dan Williams
2009-03-18  0:49                   ` Atsushi Nemoto
2009-03-18  1:23                     ` Dan Williams [this message]
2009-03-18  2:01                       ` Atsushi Nemoto
2009-03-18 17:26                         ` Dan Williams
2009-03-21 12:29                           ` Atsushi Nemoto
2009-03-26 14:12                             ` Atsushi Nemoto
2009-03-31 19:34                               ` Dan Williams
2009-04-01 16:20                                 ` Atsushi Nemoto
2009-03-16 21:20     ` Dan Williams
2009-03-17  1:52       ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20903171823g1e6c42b9t5f042d550a6ddd47@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®