From: Dan Williams <dan.j.williams@intel.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] Add COH 901 318 DMA driver platform config for U300 v3
Date: Wed, 28 Oct 2009 12:08:40 -0700 [thread overview]
Message-ID: <e9c3a7c20910281208w54ddc859wb650f6527dae2d08@mail.gmail.com> (raw)
In-Reply-To: <1256743153-17252-1-git-send-email-linus.walleij@stericsson.com>
On Wed, Oct 28, 2009 at 8:19 AM, Linus Walleij
<linus.walleij@stericsson.com> wrote:
[..]
> +#define flags_memcpy_config (COH901318_CX_CFG_CH_DISABLE | \
> + COH901318_CX_CFG_RM_MEMORY_TO_MEMORY | \
> + COH901318_CX_CFG_LCR_DISABLE | \
> + COH901318_CX_CFG_TC_IRQ_ENABLE | \
> + COH901318_CX_CFG_BE_IRQ_ENABLE)
> +#define flags_memcpy_lli_chained (COH901318_CX_CTRL_TC_ENABLE | \
> + COH901318_CX_CTRL_BURST_COUNT_32_BYTES | \
> + COH901318_CX_CTRL_SRC_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_SRC_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_DST_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_DST_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_MASTER_MODE_M1RW | \
> + COH901318_CX_CTRL_TCP_DISABLE | \
> + COH901318_CX_CTRL_TC_IRQ_DISABLE | \
> + COH901318_CX_CTRL_HSP_DISABLE | \
> + COH901318_CX_CTRL_HSS_DISABLE | \
> + COH901318_CX_CTRL_DDMA_LEGACY | \
> + COH901318_CX_CTRL_PRDD_SOURCE)
> +#define flags_memcpy_lli (COH901318_CX_CTRL_TC_ENABLE | \
> + COH901318_CX_CTRL_BURST_COUNT_32_BYTES | \
> + COH901318_CX_CTRL_SRC_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_SRC_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_DST_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_DST_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_MASTER_MODE_M1RW | \
> + COH901318_CX_CTRL_TCP_DISABLE | \
> + COH901318_CX_CTRL_TC_IRQ_DISABLE | \
> + COH901318_CX_CTRL_HSP_DISABLE | \
> + COH901318_CX_CTRL_HSS_DISABLE | \
> + COH901318_CX_CTRL_DDMA_LEGACY | \
> + COH901318_CX_CTRL_PRDD_SOURCE)
> +#define flags_memcpy_lli_last (COH901318_CX_CTRL_TC_ENABLE | \
> + COH901318_CX_CTRL_BURST_COUNT_32_BYTES | \
> + COH901318_CX_CTRL_SRC_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_SRC_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_DST_BUS_SIZE_32_BITS | \
> + COH901318_CX_CTRL_DST_ADDR_INC_ENABLE | \
> + COH901318_CX_CTRL_MASTER_MODE_M1RW | \
> + COH901318_CX_CTRL_TCP_DISABLE | \
> + COH901318_CX_CTRL_TC_IRQ_ENABLE | \
> + COH901318_CX_CTRL_HSP_DISABLE | \
> + COH901318_CX_CTRL_HSS_DISABLE | \
> + COH901318_CX_CTRL_DDMA_LEGACY | \
> + COH901318_CX_CTRL_PRDD_SOURCE)
You go through the hassle of defining these flag combination sets...
> + .param.config = COH901318_CX_CFG_CH_DISABLE |
> + COH901318_CX_CFG_RM_MEMORY_TO_PRIMARY |
> + COH901318_CX_CFG_LCR_DISABLE |
> + COH901318_CX_CFG_TC_IRQ_ENABLE |
> + COH901318_CX_CFG_BE_IRQ_ENABLE,
...but then don't use them to cut down on the line count in the
definition of these parameters?
--
Dan
next prev parent reply other threads:[~2009-10-28 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 15:19 Linus Walleij
2009-10-28 19:08 ` Dan Williams [this message]
2009-10-29 12:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c20910281208w54ddc859wb650f6527dae2d08@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®