From: Dan Williams <dan.j.williams@intel.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH] dma: cases IPU_PIX_FMT_BGRA32, BGR32 and ABGR32 are the same in ipu_ch_param_set_size()
Date: Tue, 19 Jan 2010 17:22:51 -0700 [thread overview]
Message-ID: <e9c3a7c21001191622q528974c3hfd357ff1c4f05aca@mail.gmail.com> (raw)
In-Reply-To: <4B564D94.3080804@gmail.com>
[ added Guennadi ]
On Tue, Jan 19, 2010 at 5:25 PM, Roel Kluin <roel.kluin@gmail.com> wrote:
> In these cases the same statements are executed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> But was this intended? if not, what should differ? bpp?
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 9a5bc1a..1c518f1 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -348,6 +348,7 @@ static void ipu_ch_param_set_size(union chan_param_mem *params,
> break;
> case IPU_PIX_FMT_BGRA32:
> case IPU_PIX_FMT_BGR32:
> + case IPU_PIX_FMT_ABGR32:
> params->ip.bpp = 0;
> params->ip.pfs = 4;
> params->ip.npb = 7;
> @@ -376,20 +377,6 @@ static void ipu_ch_param_set_size(union chan_param_mem *params,
> params->ip.wid2 = 7; /* Blue bit width - 1 */
> params->ip.wid3 = 7; /* Alpha bit width - 1 */
> break;
> - case IPU_PIX_FMT_ABGR32:
> - params->ip.bpp = 0;
> - params->ip.pfs = 4;
> - params->ip.npb = 7;
> - params->ip.sat = 2; /* SAT = 32-bit access */
> - params->ip.ofs0 = 8; /* Red bit offset */
> - params->ip.ofs1 = 16; /* Green bit offset */
> - params->ip.ofs2 = 24; /* Blue bit offset */
> - params->ip.ofs3 = 0; /* Alpha bit offset */
> - params->ip.wid0 = 7; /* Red bit width - 1 */
> - params->ip.wid1 = 7; /* Green bit width - 1 */
> - params->ip.wid2 = 7; /* Blue bit width - 1 */
> - params->ip.wid3 = 7; /* Alpha bit width - 1 */
> - break;
> case IPU_PIX_FMT_UYVY:
> params->ip.bpp = 2;
> params->ip.pfs = 6;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2010-01-20 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 0:25 Roel Kluin
2010-01-20 0:22 ` Dan Williams [this message]
2010-01-20 19:21 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c21001191622q528974c3hfd357ff1c4f05aca@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®