From: Dan Williams <dan.j.williams@intel.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org,
Maciej Sosnowski <maciej.sosnowski@intel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Pavel Machek <pavel@ucw.cz>, Li Yang <leoli@freescale.com>,
Paul Mundt <lethal@linux-sh.org>,
Ralf Baechle <ralf@linux-mips.org>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Magnus Damm <damm@opensource.se>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Joe Perches <joe@perches.com>, Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH 2/2] DMAENGINE: generic channel status
Date: Thu, 25 Mar 2010 15:00:04 -0700 [thread overview]
Message-ID: <e9c3a7c21003251500r27077cci67b1f06727be97f1@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1003252146070.4413@axis700.grange>
On Thu, Mar 25, 2010 at 1:58 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> On Thu, 25 Mar 2010, Linus Walleij wrote:
>
>> Convert the device_is_tx_complete() operation on the
>> DMA engine to a generic device_tx_status()operation which
>> can return three states, DMA_TX_RUNNING, DMA_TX_COMPLETE,
>> DMA_TX_PAUSED.
>>
[..]
> General: you converted all drivers to the new .device_tx_status() API, but
> since they don't implement "residue," you left it uninitialised
> everywhere. Wouldn't it be better to set it to 0 or total length,
> depending on the complete / not complete status?
Agree that it should not be uninitialized. At the same time I do not
want to require drivers that don't need it to go through the hassle of
looking up a byte count, so perhaps all but the drivers that want this
support can return a 'max byte count'??
>
>> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> index 0731802..c9f2c67 100644
>> --- a/include/linux/dmaengine.h
>> +++ b/include/linux/dmaengine.h
>> @@ -40,11 +40,13 @@ typedef s32 dma_cookie_t;
>> * enum dma_status - DMA transaction status
>> * @DMA_SUCCESS: transaction completed successfully
>> * @DMA_IN_PROGRESS: transaction not yet processed
>> + * @DMA_PAUSED: transaction is paused
>> * @DMA_ERROR: transaction failed
>> */
>> enum dma_status {
>> DMA_SUCCESS,
>> DMA_IN_PROGRESS,
>> + DMA_PAUSED,
>> DMA_ERROR,
>> };
>>
>> @@ -249,6 +251,21 @@ struct dma_async_tx_descriptor {
>> };
>>
>> /**
>> + * struct dma_tx_state - filled in to report the status of
>> + * a transfer.
>> + * @last: last completed DMA cookie
>> + * @used: last issued DMA cookie (i.e. the one in progress)
>> + * @residue: the remaining number of bytes left to transmit
>> + * on the selected transfer for states DMA_IN_PROGRESS and
>> + * DMA_PAUSED if this is implemented in the driver, else 0
>> + */
>> +struct dma_tx_state {
>> + dma_cookie_t last;
>> + dma_cookie_t used;
>> + u32 residue;
>
> In the original proposal by Dan Williams the last member was "unsigned
> long pos." I don't think, even on 64-bit systems anyone would kick off a >
> 4GB transfer, but who knows... And - I don't particularly like the name
> "pos," but I do like the idea of returning bytes transfered better, than
> bytes left. Can we change this?
Things like copy_from_user() and the scsi subsystem return residue, so
only for consistency with other areas would I side with the "bytes
left" camp.
Ack to all your other comments.
--
Dan
next prev parent reply other threads:[~2010-03-25 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 15:03 Linus Walleij
2010-03-25 15:07 ` Mark Brown
2010-03-25 20:58 ` Guennadi Liakhovetski
2010-03-25 22:00 ` Dan Williams [this message]
2010-03-25 22:37 ` Guennadi Liakhovetski
2010-03-26 0:05 ` Dan Williams
2010-03-25 23:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3a7c21003251500r27077cci67b1f06727be97f1@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=damm@opensource.se \
--cc=g.liakhovetski@gmx.de \
--cc=haavard.skinnemoen@atmel.com \
--cc=joe@perches.com \
--cc=leoli@freescale.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=maciej.sosnowski@intel.com \
--cc=nicolas.ferre@atmel.com \
--cc=pavel@ucw.cz \
--cc=ralf@linux-mips.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®