From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88465146A79 for ; Mon, 14 Oct 2024 09:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728898268; cv=none; b=GyXFp5qrW/P0FGi//v6NICz36cGPyH7TebK7jJTnCTZ5dHuqwHeHS9VznppHLh+Xu0NTOm5YNeAqPP+ZXX0z9RG375dbqaQhHCQCNFQN7LLYgA/L/FyQArBz1X5ceZ2PwlcR9YDHIEnD1ZG3SwpfrYKaDL/Ga0bOmP7J6QWC9ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728898268; c=relaxed/simple; bh=10Vh/KXdRgda34P24+FCpQSF7tDiI5LjonUGB1ERa3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V1gEQElV98x6E0Jz4+4xPxtWr6udZNdmgVXby8bo0KtQKL7tb5YnvzVA937KeW/MZN4lX9wXzg/BsuIavvVy2aYi0IjwhHqSTrWY16FCSUEBBckCG09eflAoG4z9zEkkSeIIEtdVnm5pdYH6AD5hAvwkV/4RrPfY7XzcgHSsvQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eMXcXS8l; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eMXcXS8l" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4311d972e3eso21261865e9.3 for ; Mon, 14 Oct 2024 02:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728898265; x=1729503065; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tPxfM3/+LHt+EmVnzhLr9Fip6ZGfwtZ5p/tUW2SXXpI=; b=eMXcXS8lzTnM02rJIVw2/WdsdmSh/mnx/ivOmhWN8ViLT9NNERxB4W7xliedmLhH1U P9q9MwDQYYfBQsWQh9os4zZXfDzbuJoBjp4xOR3RinoOc278D5Z0IR8mzybKbwwu2W21 lPfZSq6fesf0cRiLuObl92IuvJtrj6XMCWZ9LxrGUiQGkUfMSNHTmQ23XoIFl/WAnOZo +o4oAsVOmxj1tqMfannFrZT7oA837YZ/Gue1RpkIBGKiFF0nAzNRmLO5obvM3zQtvXTO 7uUeBTJGye+HNYoKNhZRhPA/qsYUPs248r2BcyQ4o5VJMoKT6NoSuHr5G/aps62cVkjD 3z0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728898265; x=1729503065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tPxfM3/+LHt+EmVnzhLr9Fip6ZGfwtZ5p/tUW2SXXpI=; b=nsy03f6UHt6TouYZ+ZY44kNKd6KburQB519/acpNgsZI/IM9oebNQBx6Lh+mxeJsme H8ztlA4/t+J7ltQRNgKythyUWv4Lg8KKvV5a75ZYhARSAAwWiosTXUpteQ/njaEWL80u dCO0wo2f2p3xf7L3c96WP6C7pYeF1WegpihSTmwxi9L4RNYmeHQQElW4KiOsFDQqXLcV OM448Tm8outhrD5lnjSeySPY1QMMwd+vDHly4x2Hs9QpEDEIl8fDa3NL/p0BxKQpHcYM ifzzJSKYNkh2rx4jLLiF3ROk1Z7qn8Pxe1uhk41x7sdbbBve833uuux0qLHe0J/TDO8/ il6w== X-Forwarded-Encrypted: i=1; AJvYcCVOxU0h0DHewZFIgULgjpV/zGNhh2DL+pL0MwNvmVEbcu7pzQ/SkJvi7SVteBWtRCRnbT7dTDo/YqqIIeU=@vger.kernel.org X-Gm-Message-State: AOJu0YyrW6V8Y/i3xeCqkR+ymjxbtX6ki8Cwxo3XbmG24klAUX/bCCH2 rnDrM50xnLxmC8rKbHH5d84DYHc7y6RY7F4r11JyFTyXOlsC55nyZI3FjtdWwhQ= X-Google-Smtp-Source: AGHT+IGJAZ2abLY3A+ePxucwhIPOIPVNEZwYUtaSndGiYueX+Z9ySXWSN9wDAthowcyl1n/MoONv3w== X-Received: by 2002:a05:600c:190f:b0:430:53f8:38bc with SMTP id 5b1f17b1804b1-431255dcb76mr61160315e9.12.1728898264921; Mon, 14 Oct 2024 02:31:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43127a6ae71sm63892235e9.47.2024.10.14.02.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 02:31:04 -0700 (PDT) Date: Mon, 14 Oct 2024 12:31:00 +0300 From: Dan Carpenter To: Javier Carrasco Cc: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Umang Jain , Laurent Pinchart , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node Message-ID: References: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> On Mon, Oct 14, 2024 at 10:56:35AM +0200, Javier Carrasco wrote: > This series refactors some useless goto instructions as a preparation > for the fix of a missing of_node_put() by means of the cleanup > attribute. > > Signed-off-by: Javier Carrasco > --- > Changes in v2: > - Refactor vchiq_probe() to remove goto instructions. > - Declare and initialize the node right before its first usage. > - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com > Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter