From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C8933B6E3 for ; Thu, 19 Feb 2026 14:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771510714; cv=none; b=f9m3PJUl6t67kHgLql4v80SY5kEvvi6CSNoRbsKuiMAFpuhMI4xqwSZ4M1VJSyjMlop9JZUyRYymQ2SUi4fo7gHN/RgmLVZB6kdI2EPS6SaQdieMLYn1uvOgpzTIqsCjSwQ4LmYb+pITaaEzEXdYXjrIpI0RYTAxh1obl4eMbuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771510714; c=relaxed/simple; bh=l2+yFArAt6HLkcsncg+FDTIGCg0hoeriCBLtZp05nF0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qgfUOnB3lXPA8+J4AF0AKIrYIRCLfe2eJ9q74phQkZUzcYzCVa5lSXXksEToan095jGRxU06bLi9ZpHXF83NJ6J2tWuZIGwjDSRFe9ybGRSTKZ2IPIiT6iSjFg8GcoqSJM3hnhbrvy9RhnXRM9dXfOQGJG0Ivu4EJhV9ebAg4uY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DMJB9Bpx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ky61syfl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DMJB9Bpx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ky61syfl" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61JBMB2p3564290 for ; Thu, 19 Feb 2026 14:18:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fI+C+WM3mKxwnH0W4AOtVbzKTZRTzsan7m781umLAjo=; b=DMJB9BpxMWLVLgv+ r3jM4755MQco87FiotYp668gQRoT2lTX/MTV2GDE+/QLOSjAoOrnZtmqvLnnHKyX khmtrLnvN9TuZ8XJ09b8RKrg+JZNxP09b2dnaOFSWLHxwpRmV9GHqE0332mYrc1L I2vZzeznY/P8GesO+W6gp0oLES6j/lz6AkqUGPETfcYvo7Wrrw537E/RZ7Es6OwW C0M11gFDvzFB7fn1wX8GwQWn0qYi7eTCG+L+fhECyZDuR1MDh+7Hzmy0mHqqnxIQ I0DH9DWkR60G13IG3s/MfDt/9N9E8O6zHImDgzUrAeRLwCGPAMWsfF63bf4LvEAD ysHQXw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ce1k80ghj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 14:18:32 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb38346fdbso87695885a.0 for ; Thu, 19 Feb 2026 06:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771510712; x=1772115512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fI+C+WM3mKxwnH0W4AOtVbzKTZRTzsan7m781umLAjo=; b=Ky61syflwiQm/AVn3RfjsGYbmjyq0LqHLPPBeG96L5IYSmZShX367TTrQ8LKWTXeiL YRhjXfzkut53qj8jaEF94Jsbf+m2wblwKi/dzIkw37bPDth7geGhC134lHtyJJ/XUZfK zS1Fy7B7f+GAA9MueFdzlwawXqacvOZIDtZdQ5ZRKva4uJcYPhvtvv9g0fo2bTkq/82C 8j6NjM8UfhjSDXKitM57T0DFhETzZnWmr2sfMCBtq6PzTD9+UpimTy7qr5lWOofW2S38 ZVwIaMROC8TSXKDgUPUNQ0EucmaVtK37QdkOFSYI0/DP7fkKD+arh2H73urV1oAygCsi bJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771510712; x=1772115512; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fI+C+WM3mKxwnH0W4AOtVbzKTZRTzsan7m781umLAjo=; b=mYSv2YsoZw4vP/pX6wb7U7g8Ts5PFvBfeniZYvdrWt3W+nvRyPQikFcX+K+9VTfo+a vbMmFPIpWB6CYVr1prVd2anR274+EysLn9U0CJesiyHHKUPP06y4GC8LvZn2GwT7I+kf A9OdUzG26cgwOxWwASjbDKvZKa9UiL0BvJSO30n8BsXrRJJkcD1ITaJP3mWxZgMD3vSE 1tPjG7ynDDW/+VG2T6mC3iFn+A8N84ImQcMLsd5ssNe+6/ams28kNV+PnVEOEO+kALyh tB+5svR+8fVKz5Wpy8dBxaGzs97YNTnrTDkgZrr7BYrizznElH9XjbLLoCcym5w5Cqe5 S2cg== X-Forwarded-Encrypted: i=1; AJvYcCU6paGNVSF5Qe1oBKKx1+Xm3cn9nOFhA28q2gn5U4Sp/XTERWm5YzEEktgXAv0SZRv3ifYQFIxRCRMPrtg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1mr5nIspiQAtCw3azwuXc1kpecTucikcX9D9gK73NehT2ZqPV TG0A/eDp2Y4Uivnp8qztQnbUrz5xxtWmw5tIx8YXk9Z/wzQ6KsKdFgthoo91ljZKMsFq7Ws2iUV LbxnLKILdeRUeQysNVeyBgYtNO+/UIAznzcDiOK3WdSlpVRVz+WsyIl5CnjLoQsSibts= X-Gm-Gg: AZuq6aKLGcFp/xYfOmzDNOqdvDhRnj6Zjh41O76owDciYZEEDF+XtTkx+JFGfmok6cJ mK4d7jMeS0wrsP7eTCVuRGJfAScfkHlstPc9Lw2oFUBI+nyq9eaD4oKDmAOyXINXbVf9mM4lfPQ VkixILYxiqcZ4Q7GkwLyh+mRFQ6CN6Gw4DqsU4sE/5CR79MPXm1XiXkcXsI6WUJdkI44q8T716S gy3TzXG3f5n9Ruo1J2QLzIhlMiMI628d+vPLVAvykyGSnxmVIxi68ElWWgzz4z9larnfTHMMBrG DM46Yfwl/f4PL9U568yeFusZTu9/1f7egHCdH7B+Fd2E5qVQgB8Ot+Fy3eWbtZOh6B1Gp3KtS+6 R5Zu536jgUy8hOTpYDU7Wy2//ZmcLH1CVc0Lp7NtrDC0dzJRCZPKf6f4f+NipE2pQIq+gJdVywN CZY/s= X-Received: by 2002:a05:620a:468b:b0:8c0:c999:df5a with SMTP id af79cd13be357-8cb408c8f1emr2037397085a.6.1771510711980; Thu, 19 Feb 2026 06:18:31 -0800 (PST) X-Received: by 2002:a05:620a:468b:b0:8c0:c999:df5a with SMTP id af79cd13be357-8cb408c8f1emr2037394485a.6.1771510711456; Thu, 19 Feb 2026 06:18:31 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e5f5b2e35sm5303818e87.82.2026.02.19.06.18.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 06:18:30 -0800 (PST) Message-ID: Date: Thu, 19 Feb 2026 15:18:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/4] soc: qcom: ice: Set ICE clk to TURBO on probe To: Abhinaba Rakshit , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260219-enable-ufs-ice-clock-scaling-v6-0-0c5245117d45@oss.qualcomm.com> <20260219-enable-ufs-ice-clock-scaling-v6-4-0c5245117d45@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260219-enable-ufs-ice-clock-scaling-v6-4-0c5245117d45@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: lt_A_wN2YiLHllLhH3PFmHa-RvGJSH79 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDEzMCBTYWx0ZWRfX4+gyjSBRsXHs qcjsTznmJ9DEqW1MyfyHw54sdq8zV4hx6mztQrkV6Gmr01BLwEOSj8Mpc61eut3IoPkhWu0rjIA 7q9xTSE4jjwXdp0fFchqNu6sGu0jL4iP1oPow7rOiIjG4RFBWoECMRS3CfF1AaIGOtq7iLnEEN3 243MJoQqqZhag2IqNf/ASmt95vaRXDaRDElTBZqA9CJUadng+Pzb3lZRS2kmFRq5f1ovBa1YWuA Fip+wpM787p40BBv9oStGASCyTVxy1uU1FBSj8vzNd0w/QBt8iZ3j20qorTvxaeXvAmQzRDVoRX N5GmLPU6yWTAeW1ohvgCZOR5ezxjPviCsWNqyfHb3Qho3/7I6UGp5ZvRP6uwzfaW636IuaJUXNw 0CBcrNq+9SJKAGlT2RXM8vT4yWfUrK5a3vcTAW4K7Sl6vagwas5GtNET4UUpNGZNgqPLzlaYELY z6z45/XgWDXyfIldDEQ== X-Authority-Analysis: v=2.4 cv=cdrfb3DM c=1 sm=1 tr=0 ts=69971bb8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=kiQjUq8FSzjVjtPiR3oA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: lt_A_wN2YiLHllLhH3PFmHa-RvGJSH79 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_04,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190130 On 2/19/26 10:39 AM, Abhinaba Rakshit wrote: > MMC controller lacks a clock scaling mechanism, unlike the UFS > controller. By default, the MMC controller is set to TURBO mode > during probe, but the ICE clock remains at XO frequency, > leading to read/write performance degradation on eMMC. > > To address this, set the ICE clock to TURBO during probe to > align it with the controller clock. This ensures consistent > performance and avoids mismatches between the controller > and ICE clock frequencies. > > For platforms where ICE is represented as a separate device, > use the OPP framework to vote for TURBO mode, maintaining > proper voltage and power domain constraints. > > Signed-off-by: Abhinaba Rakshit > --- > drivers/soc/qcom/ice.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index 1372dc4a4a4d0df982ea3a174df8779a37ce07c6..a60a793f9c230e08ebd7cae89a828980e762db27 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -665,6 +665,13 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > dev_info(dev, "ICE OPP table is not registered\n"); > } > > + if (engine->has_opp) { > + /* Vote for maximum clock rate for maximum performance */ > + err = dev_pm_opp_set_rate(dev, INT_MAX); > + if (err) > + dev_warn(dev, "Failed boosting the ICE clk to TURBO\n"); I suppose this isn't exactly critical, but should never happen either Nonetheless, it's fine Reviewed-by: Konrad Dybcio Konrad