From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel
Date: Thu, 22 Sep 2022 17:16:10 +0200 [thread overview]
Message-ID: <e9d55a49-e3c6-a6b2-43e1-8e643dc49d58@somainline.org> (raw)
In-Reply-To: <02f44228-866a-f096-1e90-dfbd31660491@linaro.org>
On 22.09.2022 17:11, Krzysztof Kozlowski wrote:
> On 22/09/2022 15:58, Konrad Dybcio wrote:
>> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
>> Compact smartphones.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> Thank you for your patch. There is something to discuss/improve.
>
>> +
>> + reg: true
>> +
>> + backlight: true
>> +
>> + vddio-supply:
>> + description: VDDIO 1.8V supply
>> +
>> + vsp-supply:
>> + description: Positive 5.5V supply
>> +
>> + vsn-supply:
>> + description: Negative 5.5V supply
>> +
>> + preset-gpios:
>
> How about bringing them closer to common GPIOs:
> panel-reset-gpios
> ?
>
>> + description: Display panel reset pin
>> +
>> + treset-gpios:
>
> touch-reset-gpios
>
I can do that. I will however wait with resending in case somebody has comments
on the .c driver.
Konrad
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-09-22 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 13:58 Konrad Dybcio
2022-09-22 13:59 ` [PATCH v2 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver Konrad Dybcio
2022-09-22 15:11 ` [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel Krzysztof Kozlowski
2022-09-22 15:16 ` Konrad Dybcio [this message]
2022-09-22 15:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9d55a49-e3c6-a6b2-43e1-8e643dc49d58@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jamipkettunen@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®