From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B28D13A865 for ; Thu, 28 Nov 2024 07:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732778816; cv=none; b=RNX6RX+Wil/geYnwTUbo+npTUKvNMvf1f5/BpXohqfyvLnJ1+5RKMwMGW1WMcldT2zEX51PIYatSnJWboWSFxrCRr0dWIiSDkfxor39xBNrcpIsvy9RzaPEAI86zlKpaD5icXBauMTtAnY62gohSSv7OYq29W/ob0IawkdBLerQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732778816; c=relaxed/simple; bh=pLOz2YuQx1sF3DfeE3uqwKBatiuvQk+YGAPg9txMgGM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=aF+YlEvMTuHZVt74+Cr+aR4x0qM/FxpUyeIOR57J0xpM36Apk2Ou1DOVKrj89aLzNAQ2D91XIcxZMiEO8/2jFCIx1orxPZd2fHQN7wPc+TAVCRZWQztS1xBrdBv9XyYGfUXCLK67RTO2qzC2olhc6YEmgWRAUOtoZ2wvJZ2IQYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KWde0fdU; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KWde0fdU" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-434a742481aso4176025e9.3 for ; Wed, 27 Nov 2024 23:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732778812; x=1733383612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=8kqh1KNqKnunsDJjpBDg96FW+lRvbuxgoy5i/G9dtrM=; b=KWde0fdUCQLkW/ahLZU/ncTXf0/R9V5r9rtkEOJp5Kd3NwC3i6uNY/F7ubBdTqv9VD +wLT7ZpgVPkqp54zt40mZDGkCtLiqarPCzHOMfKXVjgLp+ZlJLznjY4z7+14bE9bfFrL 4CHcV+SLkSdC+NXyeAz9U2tCCnURh9NuTHKpAVAIrBKSXOfPvwMxVUMJIh4xS98sqB3o T851gWUIdGkbzVQdB1A72jD3iPezi//9yjgK2lfUN4++E88Gz7IGMarKZ2cKu/Wj1isa uTnwP/g6mEvL5j6O3iJWvIbZ3yI8Bj4UKHDKn9k2/eA+9WC1uefM2SdSHsxRmtAXi4PH 9EGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732778812; x=1733383612; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8kqh1KNqKnunsDJjpBDg96FW+lRvbuxgoy5i/G9dtrM=; b=P+8KPUnHHdUnNHRHPSZXfGDjJx4NAuxXb03rCN8SaBlwFEE4Ty5p11nOmAWiIAKJqL GImZRox4fDTUTAiVRtDZ4HglQhEUXZJ97EY+yoJPkmu528BjINpQZuVS7QVdZqLWPhVY 5T2Ls0PQsCxu/vAgiUIQDIFOHZkyMT1FZbL0aaj26TE8gdwosipzwr8NRku/P+ITbdnh 32/v2saHZBVGFnVBx+u9Gm43HFsN6IqmSgYjrehvcACgge4y5S9XdNNjeS8FYjJTZRUH tycpaQFkPBJpZp45HAYwXrHM+nZCirJxmt8q5/VggJBVnh8sIzZZl4QBvwNELCUryuOK G9CQ== X-Forwarded-Encrypted: i=1; AJvYcCUXj5SFZ/j5hL6kVZPXJ7njboEHnREYXTGTwvrNrPdVFxnoME+dTgJ07KsrFmLU6sMLyIoG93fhChHIvl4=@vger.kernel.org X-Gm-Message-State: AOJu0YzHCi4VrGLFl+w93WEnw/jR4QRhkBwX5sLEoP1Tq66xexbiTos+ VMzYJZCewlz3tdDD3fJg4WwfIobCYr7QTuQR4g4/g2BgWTkaqpAwNT0h36YGqok= X-Gm-Gg: ASbGncsNw9oN0o3DbnywTGxp9j7ZHYe1tqLEkyhEHgBAmdA2GWXuDUMBq+lN0zyQBgO fcXvTiIAwn0/5RSLYEMAzd79Q+aq3vF4X3XwrD+9/O/9J4+4LfAlEvUQZ1yQ3zJXXKNzn4OOMwV VGtuf0RIkg5dvcztVlSFTNYGHvQnIzS8kn1ngBnPkgGVOtVYjtRfgMiXi7a4cEmfazXYVu8fcOI xa1FpdMkUw8BxrJV38DJubK9T5OU9kIEI3Sciof1NuIKZ5x5HyxxaCPGi8= X-Google-Smtp-Source: AGHT+IFLv++oJgv9Qwh3wkymj9ZOpRIqdb0ylXRtmM787YQXfSehzvlY/3Z1EYVe5oEXo8L0YnB7qg== X-Received: by 2002:a05:600c:458b:b0:434:a924:44e9 with SMTP id 5b1f17b1804b1-434a9dcfedfmr57606425e9.15.1732778812529; Wed, 27 Nov 2024 23:26:52 -0800 (PST) Received: from [192.168.0.190] ([82.76.24.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7d26b5sm43808615e9.35.2024.11.27.23.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 23:26:52 -0800 (PST) Message-ID: Date: Thu, 28 Nov 2024 09:26:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: adc: at91-sama5d2_adc: Fix use-after-free in sama5d2_adc driver To: Pei Xiao , jic23@kernel.org, lars@metafoo.de, nicolas.ferre@microchip.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com References: <1c67249dbc78678c451a155c04ef908627da6d1a.1732776187.git.xiaopei01@kylinos.cn> Content-Language: en-US From: Eugen Hristev In-Reply-To: <1c67249dbc78678c451a155c04ef908627da6d1a.1732776187.git.xiaopei01@kylinos.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello, On 11/28/24 08:45, Pei Xiao wrote: > at91_adc_interrupt can call at91_adc_touch_data_handler function > to start the work by schedule_work(&st->touch_st.workq). > > If we remove the module which will call at91_adc_remove to > make cleanup, it will free indio_dev through iio_device_unregister > while the work mentioned above will be used. The sequence of operations > that may lead to a UAF bug is as follows: > > CPU0 CPU1 > > | at91_adc_workq_handler > at91_adc_remove | > iio_device_unregister(indio_dev) | > device_release | > //free indio_dev | > | iio_push_to_buffers(indio_dev) > | //use indio_dev > > Fix it by ensuring that the work is canceled before proceeding with > the cleanup in at91_adc_remove. > > Fixes: 27e177190891 ("iio:adc:at91_adc8xx: introduce new atmel adc driver") I believe that the commit that introduced the workqueue is different than the one you tagged here. With that changed, Reviewed-by: Eugen Hristev > Signed-off-by: Pei Xiao > --- > drivers/iio/adc/at91-sama5d2_adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 8e5aaf15a921..4ba52b500054 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -2491,6 +2491,7 @@ static void at91_adc_remove(struct platform_device *pdev) > struct iio_dev *indio_dev = platform_get_drvdata(pdev); > struct at91_adc_state *st = iio_priv(indio_dev); > > + cancel_work_sync(&st->touch_st.workq); > iio_device_unregister(indio_dev); > > at91_adc_dma_disable(st);