From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FBEC433EF for ; Mon, 25 Apr 2022 22:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231708AbiDYW0n (ORCPT ); Mon, 25 Apr 2022 18:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343702AbiDYWP6 (ORCPT ); Mon, 25 Apr 2022 18:15:58 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF3852FE56 for ; Mon, 25 Apr 2022 15:12:52 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id p12so23172221lfs.5 for ; Mon, 25 Apr 2022 15:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CAP7rPZV7Wg1L7ILm1X74Kue+bkQwcGO5HR9HWZTqCQ=; b=dJX2cSv/+gKglImH2uFpJEYgjc5+NX9Xd3BuvqhDgGusOPOJFIHWKeRICKBQpPPoSR LRWg4erbLAb1L1jmTzVE/ERDXVMvVaMjRvVK7eK25m1tZvgc7xsuVzviLcWRLXb4qJNe NncodU0a2RPl7ROmTaSIncvmiSd45Wt4Ukqa56boq0NxluU+2gvngMpLmVhuRptAw847 xuWUIzDVOKohXpafkUfT2vcFXmK0te0qBVyT91KKUUDbSKU9uqP1ofJgrALW5B6j0/MD B0TFCbQWgpjg+K5CtO/iipd/25Fhf9UGPKZNMiNdweZ0IA1QeOLtbn7yj1vNiyXmfHLL 3RdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CAP7rPZV7Wg1L7ILm1X74Kue+bkQwcGO5HR9HWZTqCQ=; b=GtdsT92d28gKfCHAIf0zq8nyjjeJqYcG4MhYroOvY+Iq2k0cxbv4mVJ2hWnbnlMYLK SzJxPx+EyYyPN/tHtY+y5Hkcod6g23sXQ/Q3Gkwv37TnX6TqGBcjL/3HqPDzg4/enxLp ux1FLgEJ8zAAbWNR6rQKtqme58/kcxCtviPWD2U5Q/eoZBaHo/w9iVhorWITPSTVYmMG 4OgOX4+c3HEc9IUwlExD/U+NdaMiLHZKr0QK1IC1NkrYAWlQbkqeop8oS+8Rsvip7gqG O2E+HaKmo0WNvse3aqk/gU5rEr8QhLW5c1tX9KMZZta7GPbP3F7uRj/poCrNi7dgQ0sJ z/WA== X-Gm-Message-State: AOAM530Ju8uSrB0ORq+fGtGZ5/+U23T3yn+8DRrqke66MDo+R43oI85k HPZM/1SdhYBwe2u2dGMSfDtK6w== X-Google-Smtp-Source: ABdhPJwcqBXtXmf+RLDNzHIm9VFcDdg9XbcmIbPJSD5DRm06iD9NfzLea91rV2lpzRSmr+WIJqT1DQ== X-Received: by 2002:ac2:435a:0:b0:46b:ae5b:83e8 with SMTP id o26-20020ac2435a000000b0046bae5b83e8mr14551244lfl.485.1650924771409; Mon, 25 Apr 2022 15:12:51 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id l28-20020a19495c000000b0044a8abcb589sm1536797lfj.186.2022.04.25.15.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 15:12:51 -0700 (PDT) Message-ID: Date: Tue, 26 Apr 2022 01:12:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] drm/msm: change msm_sched_ops from global to static Content-Language: en-GB To: Tom Rix , robdclark@gmail.com, sean@poorly.run, quic_abhinavk@quicinc.com, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220421131507.1557667-1-trix@redhat.com> From: Dmitry Baryshkov In-Reply-To: <20220421131507.1557667-1-trix@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/2022 16:15, Tom Rix wrote: > Smatch reports this issue > msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static? > > msm_sched_ops is only used in msm_ringbuffer.c so change its > storage-class specifier to static. > > Signed-off-by: Tom Rix Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c > index 367a6aaa3a20..66f4ec09ef67 100644 > --- a/drivers/gpu/drm/msm/msm_ringbuffer.c > +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c > @@ -40,7 +40,7 @@ static void msm_job_free(struct drm_sched_job *job) > msm_gem_submit_put(submit); > } > > -const struct drm_sched_backend_ops msm_sched_ops = { > +static const struct drm_sched_backend_ops msm_sched_ops = { > .run_job = msm_job_run, > .free_job = msm_job_free > }; -- With best wishes Dmitry