mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
To: Chris Obbard <chris.obbard@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bharath Kumar <bkumar@qti.qualcomm.com>,
	Chenna Kesava Raju <chennak@qti.qualcomm.com>,
	Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: agatti: Add memory-region for audio PD
Date: Mon, 17 Aug 2026 23:13:17 +0530	[thread overview]
Message-ID: <e9da1e84-a7a5-44ba-b392-ce098f781dfa@oss.qualcomm.com> (raw)
In-Reply-To: <CAPnEM6b49hbfaXKd1y+JmF2FXSv8CAxau4JuUmJRZbX0YTpdpA@mail.gmail.com>



On 8/15/2026 2:56 AM, Chris Obbard wrote:
> Hi Vinayak,
> 
> On Fri, Aug 7, 2026 at 6:51 AM Vinayak Katoch
> <vinayak.katoch@oss.qualcomm.com> wrote:
>>
>> Reserve memory region for audio PD dynamic loading and remote heap
>> requirements. Add the required VMID list for memory ownership
>> transfers.
>>
>> Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - Fixed VMID list alignment.
>> - Link to v1: https://lore.kernel.org/r/20260806-agatti-audio-v1-1-cd6766cc9ccb@oss.qualcomm.com
>> ---
>>  arch/arm64/boot/dts/qcom/agatti.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
> 
> Thanks for the patch!
> 
> This fixes a boot loop on Qualcomm QRB2210 RB1 and Arduino UNO Q, I
> wonder if we could add a suitable Fixes tag ?
> 
> Tested-by: Christopher Obbard <chris.obbard@oss.qualcomm.com>
>

Thanks for testing!

This patch is a feature addition rather than a bug fix, so a Fixes tag
would not be appropriate here.

The boot loop on QRB2210 RB1 and Arduino UNO Q was caused by the
userspace audiopd service file, not a kernel regression. That issue has
already been addressed in the userspace FastRPC repository:
https://github.com/qualcomm/fastrpc/commit/cd0c0dbbfef8ae950f9ebb4483a9b0192d8fb6a6


>> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
>> index 590bd2432d85..2064eed01327 100644
>> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
>> @@ -381,6 +381,14 @@ rmtfs_mem: memory@89b01000 {
>>                         qcom,client-id = <1>;
>>                         qcom,vmid = <QCOM_SCM_VMID_MSS_MSA QCOM_SCM_VMID_NAV>;
>>                 };
>> +
>> +               adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
>> +                       compatible = "shared-dma-pool";
>> +                       alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
>> +                       reusable;
>> +                       alignment = <0x0 0x400000>;
>> +                       size = <0x0 0x800000>;
>> +               };
>>         };
>>
>>         smp2p-adsp {
>> @@ -2348,6 +2356,9 @@ fastrpc {
>>                                         compatible = "qcom,fastrpc";
>>                                         qcom,glink-channels = "fastrpcglink-apps-dsp";
>>                                         label = "adsp";
>> +                                       memory-region = <&adsp_rpc_remote_heap_mem>;
>> +                                       qcom,vmids = <QCOM_SCM_VMID_LPASS
>> +                                                     QCOM_SCM_VMID_ADSP_HEAP>;
>>
>>                                         qcom,non-secure-domain;
>>
>>
>> ---
>> base-commit: 1701fda2f58e345c050f4309971bdc07cd6146ba
>> change-id: 20260806-agatti-audio-357bcd74ae9c
>>
>> Best regards,
>> --
>> Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
>>
>>


  reply	other threads:[~2026-08-17 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  5:50 Vinayak Katoch
2026-08-07  9:19 ` Dmitry Baryshkov
2026-08-07 10:44 ` Ekansh Gupta
2026-08-14 21:26 ` Chris Obbard
2026-08-17 17:43   ` Vinayak Katoch [this message]
2026-08-19 11:32 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9da1e84-a7a5-44ba-b392-ce098f781dfa@oss.qualcomm.com \
    --to=vinayak.katoch@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bkumar@qti.qualcomm.com \
    --cc=chennak@qti.qualcomm.com \
    --cc=chris.obbard@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ekansh.gupta@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®