From: David Laight <David.Laight@ACULAB.COM>
To: 'Tom Talpey' <tom@talpey.com>,
"longli@microsoft.com" <longli@microsoft.com>,
Steve French <sfrench@samba.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [Patch v3 2/6] cifs: Allocate validate negotiation request through kmalloc
Date: Wed, 18 Apr 2018 13:08:53 +0000 [thread overview]
Message-ID: <e9e7f77032c5402e848de0293e4db3ee@AcuMS.aculab.com> (raw)
In-Reply-To: <d7e569b6-d268-b8c1-e91d-d6dc0e7cdfc2@talpey.com>
From: Tom Talpey
> Sent: 18 April 2018 12:32
...
> On 4/17/2018 8:33 PM, Long Li wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > The data buffer allocated on the stack can't be DMA'ed, and hence can't send
> > through RDMA via SMB Direct.
>
> This comment is confusing. Any registered memory can be DMA'd, need to
> state the reason for the choice here more clearly.
The stack could be allocated with vmalloc().
In which case the pages might not be physically contiguous and there is no
(sensible) call to get the physical address required by the dma controller
(or other bus master).
David
next prev parent reply other threads:[~2018-04-18 13:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 0:33 Long Li
2018-04-18 11:32 ` Tom Talpey
2018-04-18 13:08 ` David Laight [this message]
2018-04-18 14:07 ` Tom Talpey
2018-04-18 17:11 ` Long Li
2018-04-18 17:40 ` Tom Talpey
2018-04-18 18:53 ` Long Li
2018-04-18 17:16 ` Long Li
2018-04-18 17:42 ` Tom Talpey
2018-04-18 18:53 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9e7f77032c5402e848de0293e4db3ee@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome