From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A99728EB for ; Sat, 11 Jan 2025 02:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736561412; cv=none; b=AhIGnMvaq/xBEtO9GncF5gqcSwTlMWrWET5YMIhdy4gcRdolIzQOi7bfrAJyAmgWHyU5cALTFbi7rI2m1j5dviUw6fHikb3eRWMdkVYiWTufs0m4sJmM/RRcVUzCNp1Bx7mwni207YyrBRi2OCgv+86Pd658vIXNhZLhMa6xGOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736561412; c=relaxed/simple; bh=XSrnqv9MHTTYKdgKGnKopg2+wUw/BAe1bkHzwBeLIHg=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=SXm1oRUHosjxh00QFvGenxKrLF1adCyIHW5zC6utWUw76nNgvxtEq6LuCnjcR+YBHnrj9B547R7tFDf9sCcDauvIJQfsYcSPz6aYrW8cuctEFb0ayoEK2RBMajjpiLXULq4vOsmtTcgS0Bw82j8NEvLjXUQTtALp34y+LG/6ph0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXbCGdwR; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXbCGdwR" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2166f1e589cso54489025ad.3 for ; Fri, 10 Jan 2025 18:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736561410; x=1737166210; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Ikx4Vevw+NcJa3tECh//u5K0h78SO2S3IuvFw1IpZWY=; b=NXbCGdwRJ201cbMMfEP2tYc2BFY9OYH0xhlCSgCwBVj1Scqcu5G1ogenM2FYX/ShYn s7UWoAU7PxA+dYjcJYKmsAEGWkLZtqHjDKUbIpw18UZ2n0W7Aa0jn+SNF4M/SbvoCb3X jNdjnsvyx1EVoQCTduuwD/U41ZsQTbYZiBEvh868W5rbbcEZzRZmhj0hZS51DvIbmgtK BmL2T0jdNX2Ej20q+hvJIBo8ML+lnbrtlUQdvSki6W7J9Icrp7PauRZ9u3mSsT21loZJ WYSSUwJGYpUjWkH1BVTIycgkf6SqV4lUe7Ix/YWTNpiPC8Xjh9YkGm9WU+ALOeaZWQMZ c98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736561410; x=1737166210; h=content-transfer-encoding:in-reply-to:references:cc:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ikx4Vevw+NcJa3tECh//u5K0h78SO2S3IuvFw1IpZWY=; b=eOv2+0tSy4Wpsep7hucOR2v8eTA5vZBH00+81e/7S/uZrjlYkG7UewtTpA1qht+22Q IG/1A4nqGcnQWcBn9i7b57WKVIdf4HR6/SEjtsT6kwFt+VW0iCqbf0gjS9GYtqUqWN/t BfZQ8iz9oDijDpfIw0VYyI6lfKAeLKxdJSLv8tdKeH38CiyRKz127k5aO/UvJdXA7SAd gx0ZQBHc5EZYUqNG4FlYERl7IVaSv+DJ23n5fVK6NoDgPD72zeAn0FsBBEKHaVv+aFxi HdhGAikbxDe4Yr/3DUCb4hi70czfYGBkTF7OZ3P3vXnNIdTVQKUtT/KgMvj0hrxrd9jk Ql6A== X-Forwarded-Encrypted: i=1; AJvYcCUqkKbCgOydCRe+odIYlk9ZlRcUcu6NVlILOEsiB8r2dfoZI4WfxY1PZQGCf39uOrXfGe12s5gjdWx2WDY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjiovf5KW/KI19XGcGKDeD8pFOnPKeA+OOh07f+3i3xzbws8lp nsRpF0/1WdB1WSO6VhkWZ7Y88xmjBF3dn/RKEYVlPM49TsOUHLO/ X-Gm-Gg: ASbGncuAmWEOt9/TtKtG3xJINOdceJ90FzEYLdp+jCFjmA+CfiT9jYEWPSY9ck2CZTt lwMW2IgpGHE4xSb9kLBwnla6WkruB228TkA7jrTXIL9/PROphgJpr1LyFdhZlE2ebIY/w6ptiI4 09MMeX9S1KYV82+zLBleNsVb/5wH8/FJxIxGuzXppMIgw+PFSJmTNbDkvmLGbUrgb4W2jOvCOXS 42tT7pAZx9pp+qfDS7867XXhpioQ3XPXfOFhhGvnO07uQCbjn/8gFbnF7fy23I+Jjfz9SJYgwf0 MK0wte4JRjnYvue3PhEoOOsELu2q3IrrAFs= X-Google-Smtp-Source: AGHT+IHleCSawmwVue3HvJfgQ5KvS3wZN5VyhLE1UzPaCRAs7QMUtn7RS2J+206biBhBK28kucIBeQ== X-Received: by 2002:a05:6a00:3c83:b0:71e:4296:2e with SMTP id d2e1a72fcca58-72d21f4bc9emr17796023b3a.11.1736561410185; Fri, 10 Jan 2025 18:10:10 -0800 (PST) Received: from ?IPV6:240e:3af:e05:c460:74c2:d24d:3e6:13f6? ([240e:3af:e05:c460:74c2:d24d:3e6:13f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4067edf0sm2189684b3a.133.2025.01.10.18.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 18:10:09 -0800 (PST) Message-ID: Date: Sat, 11 Jan 2025 10:10:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 From: Li Zhijian Subject: Re: [PATCH] mm: vmscan : pgdemote vmstat is not getting updated when MGLRU is enabled. To: donettom@linux.ibm.com Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, hannes@cmpxchg.org, kaiyang2@cs.cmu.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, rientjes@google.com, ritesh.list@gmail.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, weixugc@google.com, yuzhao@google.com References: <20250109060540.451261-1-donettom@linux.ibm.com> In-Reply-To: <20250109060540.451261-1-donettom@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > When MGLRU is enabled, the pgdemote_kswapd, pgdemote_direct, and > pgdemote_khugepaged stats in vmstat are not being updated. > 'Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for > NUMA balancing operations")' moved the pgdemote vmstat update > from demote_folio_list() to shrink_inactive_list(), which is in > the normal LRU path. As a result, the pgdemote stats are updated > correctly for the normal LRU but not for MGLRU. > To address this, we have added the pgdemote stat update in the > evict_folios() function, which is in the MGLRU path. With this > patch, the pgdemote stats will now be updated correctly when MGLRU > is enabled. > Without this patch vmstat output when MGLRU is enabled > ====================================================== > pgdemote_kswapd 0 > pgdemote_direct 0 > pgdemote_khugepaged 0 > With this patch vmstat output when MGLRU is enabled > =================================================== > pgdemote_kswapd 43234 > pgdemote_direct 4691 > pgdemote_khugepaged 0 > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA balancing operations") > Signed-off-by: Donet Tom Great minds think alike, It's excatly same with mine[0] :) There is another bug[1] as well. [0] https://lore.kernel.org/linux-mm/20250110122133.423481-2-lizhijian@fujitsu.com/ [1] https://lore.kernel.org/linux-mm/20250110122133.423481-1-lizhijian@fujitsu.com/ Feel free to add vvv if your patch is accepted at last. Tested-by: Li Zhijian Reviewed-by: Li Zhijian > --- > mm/vmscan.c | 3 +++ > 1 filechanged , 3 insertions(+) > diff --git a/mm/vmscan.c b/mm/vmscan.c index 9a859b7d18d7..b1ec5ece067e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4642,6 +4642,9 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap reset_batch_size(walk); > } > + __mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(), + stat.nr_demoted); + item = PGSTEAL_KSWAPD + reclaimer_offset(); > if (!cgroup_reclaim(sc)) > __count_vm_events(item, reclaimed); > --