From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdFNORu (ORCPT ); Wed, 14 Jun 2017 10:17:50 -0400 Received: from resqmta-po-11v.sys.comcast.net ([96.114.154.170]:48664 "EHLO resqmta-po-11v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdFNORs (ORCPT ); Wed, 14 Jun 2017 10:17:48 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest To: Masami Hiramatsu Cc: Steven Rostedt , Shuah Khan , linux-kselftest@vger.kernel.org, Ingo Molnar , linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan References: <149551934796.30231.12544755801380678045.stgit@devbox> <4b0b2ac8-dfba-abd9-3dba-bbe73c22f79f@kernel.org> <20170607185628.452a11a1@gandalf.local.home> <8f974157-c2e5-9b39-c55b-b637d6e7814f@osg.samsung.com> <20170608133743.4720e2bc@gandalf.local.home> <8bcf5a87-812a-6ceb-7fa4-ea2d33d4e717@osg.samsung.com> <20170608170844.134e1158@gandalf.local.home> <9a2b4e46-a545-b862-2517-472f364a68b3@osg.samsung.com> <20170608172627.3dab319e@gandalf.local.home> <9be74d50-aee5-4771-a62c-e04156176263@osg.samsung.com> <20170608173946.7c9308f2@gandalf.local.home> <052a7347-be6e-42e2-de5e-6f5849fa1e8e@osg.samsung.com> <20170608175144.205894cb@gandalf.local.home> <20170614111217.46825d2caf31eae9edb72162@kernel.org> <20170614135313.04e2f0b0596bbb9057ce557b@kernel.org> From: Shuah Khan Message-ID: Date: Wed, 14 Jun 2017 08:17:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170614135313.04e2f0b0596bbb9057ce557b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfIqadOC3yW4GdnIV8mOJvsQZQguuPcUjqQfKujjmA8nNZ8JEose9OdGRfHbOkIQ4Oo88gM9iSBHXdI97zkPCtXTqbKuCb24FjCvAbZxAxiraSOQGklSi DTS7e8rCLzVW4+2emryPh3hzypw1kcl0okWXT7Y20n+WZpwxhdleGvHFGAHdgXBlSC0bslPD8eVaDD4niwD56zAtDQY92jCYBTNaOmq4g5a0le6VwqXt8g/5 0i1PGsssOTTWNrK83PcEa+yCbKycFjJlFtvO4/TsoYVi/sWdQyJwyOT9Pb+yA/wwyFtXV5YwptZ/7/Sba4KjtbB7HGnpmBobrVgPE6N2rjj1WWB2U68urD6D uO36VY03AaM0A6nzRcZtyO2m5SqD3g== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masami, On 06/13/2017 10:53 PM, Masami Hiramatsu wrote: > On Wed, 14 Jun 2017 11:12:17 +0900 > Masami Hiramatsu wrote: > >> Hi Shuah and Steve, >> >> Sorry for replying so late... >> >> On Thu, 8 Jun 2017 17:51:44 -0400 >> Steven Rostedt wrote: >> >>> On Thu, 8 Jun 2017 15:44:08 -0600 >>> Shuah Khan wrote: >>> >>>>> Also, did you see my reply about having the right config? You have >>>>> HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in >>>>> your report. >>>> >>>> I did see that one. Didn't get a chance to look at that yet. Do you expect >>>> the tests to be skipped in this case? Could it be that tests aren't run? >>>> I will look at this and let you know what I find on my test system. >>> >>> Your first email showed that they passed, which would be hard to do >>> since the feature is not even enabled. ftracetest is very much set up >>> to look at the existing pseudo files to determine if a feature exists >>> or not, and if it does not, it returns "UNSUPPORTED". If it returned >>> PASSED when the feature is not enabled, that would be a big time bug in >>> the test. >> >> As far as I can see, what Steve you saw was my result on the 4.9 stable >> kernel, which had been compiled with fully ftrace enabled :). >> >>>> >>>>> >>>>> One more thing, is this 100% reproducible. That is, does it always fail? >>>>> >>>> Failed the two times I tried. >> >> I've also tried to test the latest linus tree with this series with Shuah's >> config on qemu, and could not reproduced it. (I attached the log) >> As you can see, with Shuah's config, histogram tests are marked UNSUPPORTED. >> >> Of course, that is 4.12.0-rc5+ and kconfig is a bit tweaked(attached). >> I'll try kselftest tree too. > > I've tried it on linux-kselftest/next, but not able to reproduce it... > > Thank you, Hmm. Not sure what's happening on my test system. I will try it one more time with a clean build and see what happens. Thanks for debugging this. -- Shuah