From: Joe Perches <joe@perches.com>
To: Mahak Gupta <gmahak1@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, rcy@google.com, benchan@chromium.org,
toddpoynor@google.com, rspringer@google.com
Subject: Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis
Date: Sun, 07 Feb 2021 08:31:31 -0800 [thread overview]
Message-ID: <e9ecbee6d8c076fec8d2814b744f991c69a29dec.camel@perches.com> (raw)
In-Reply-To: <20210207140928.11029-1-gmahak1@gmail.com>
On Sun, 2021-02-07 at 19:39 +0530, Mahak Gupta wrote:
> This patch fixes warnings of 'checkpatch.pl'. According to
> Linux coding guidelines, code should be aligned properly to
> match with open parenthesis and lines should not end with
> open parenthesis.
>
> Signed-off-by: Mahak Gupta <gmahak1@gmail.com>
> ---
> drivers/staging/gasket/gasket_ioctl.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index e3047d36d8db..a966231bad42 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -40,7 +40,7 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
>
>
> /* Read the size of the page table. */
> static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
> - struct gasket_page_table_ioctl __user *argp)
> + struct gasket_page_table_ioctl __user *argp)
> {
> int ret = 0;
> struct gasket_page_table_ioctl ibuf;
> @@ -51,8 +51,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
> if (ibuf.page_table_index >= gasket_dev->num_page_tables)
> return -EFAULT;
>
>
> - ibuf.size = gasket_page_table_num_entries(
> - gasket_dev->page_table[ibuf.page_table_index]);
> + ibuf.size = gasket_page_table_num_entries(gasket_dev->page_table[ibuf.page_table_index]);
>
>
> trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> ibuf.host_address,
> @@ -66,7 +65,7 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
>
>
> /* Read the size of the simple page table. */
> static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev,
> - struct gasket_page_table_ioctl __user *argp)
> + struct gasket_page_table_ioctl __user *argp)
> {
> int ret = 0;
> struct gasket_page_table_ioctl ibuf;
> @@ -92,7 +91,7 @@ static int gasket_read_simple_page_table_size(struct gasket_dev *gasket_dev,
>
>
> /* Set the boundary between the simple and extended page tables. */
> static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
> - struct gasket_page_table_ioctl __user *argp)
> + struct gasket_page_table_ioctl __user *argp)
> {
> int ret;
> struct gasket_page_table_ioctl ibuf;
> @@ -107,8 +106,8 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
>
>
> if (ibuf.page_table_index >= gasket_dev->num_page_tables)
> return -EFAULT;
> - max_page_table_size = gasket_page_table_max_size(
> - gasket_dev->page_table[ibuf.page_table_index]);
> + max_page_table_size = gasket_page_table_max_size
> + (gasket_dev->page_table[ibuf.page_table_index]);
>
>
> if (ibuf.size > max_page_table_size) {
> dev_dbg(gasket_dev->dev,
> @@ -119,8 +118,7 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
>
>
> mutex_lock(&gasket_dev->mutex);
>
>
> - ret = gasket_page_table_partition(
> - gasket_dev->page_table[ibuf.page_table_index], ibuf.size);
> + ret = gasket_page_table_partition(gasket_dev->page_table[ibuf.page_table_index], ibuf.size);
> mutex_unlock(&gasket_dev->mutex);
>
>
> return ret;
> @@ -183,7 +181,7 @@ static int gasket_unmap_buffers(struct gasket_dev *gasket_dev,
> * corresponding memory.
> */
> static int gasket_config_coherent_allocator(struct gasket_dev *gasket_dev,
> - struct gasket_coherent_alloc_config_ioctl __user *argp)
> + struct gasket_coherent_alloc_config_ioctl __user *argp)
> {
> int ret;
> struct gasket_coherent_alloc_config_ioctl ibuf;
next prev parent reply other threads:[~2021-02-07 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 14:09 Mahak Gupta
2021-02-07 14:35 ` Greg KH
2021-02-07 16:31 ` Joe Perches [this message]
2021-02-07 17:46 ` Joe Perches
2021-02-08 2:55 Mahak Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9ecbee6d8c076fec8d2814b744f991c69a29dec.camel@perches.com \
--to=joe@perches.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gmahak1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rcy@google.com \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®