From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751413AbdJDUQ7 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 16:16:59 -0400
Received: from mail-wr0-f193.google.com ([209.85.128.193]:36081 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751132AbdJDUQ6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 16:16:58 -0400
X-Google-Smtp-Source: AOwi7QCKGXe7uolaSMGh4hiTkTrhws+OcDaEyMHEbYeupnnlPRZdjKYbsktOY3YEdsolBS0kGs++7w==
Subject: Re: [PATCH 1/5] cris: nand: Delete an error message for a failed
 memory allocation in crisv32_nand_flash_probe()
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-cris-kernel@axis.com,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Krzysztof Halasa <khalasa@piap.pl>, Mikael Starvik <starvik@axis.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
        Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <cd84411c-d202-70d6-dec2-c02bedaf3594@users.sourceforge.net>
 <92a95fe3-5b8d-5dd9-a7bf-131a999e74c6@users.sourceforge.net>
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Message-ID: <e9efec69-69dd-c33f-85cf-bf5f796acdb8@gmail.com>
Date: Wed, 4 Oct 2017 22:16:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <92a95fe3-5b8d-5dd9-a7bf-131a999e74c6@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/10/17 20:45, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 --
>  arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> index 925a98eb6d68..259aa1f46fbe 100644
> --- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> +++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
> @@ -136,8 +136,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
>  	/* Allocate memory for MTD device structure and private data */
>  	wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
>  	if (!wrapper) {
> -		printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> -			"device structure.\n");
>  		err = -ENOMEM;
>  		return NULL;
>  	}
> diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> index 53b56a429dde..1baf16ee74e8 100644
> --- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> +++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
> @@ -111,8 +111,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
>  	/* Allocate memory for MTD device structure and private data */
>  	wrapper = kzalloc(sizeof(struct mtd_info_wrapper), GFP_KERNEL);
>  	if (!wrapper) {
> -		printk(KERN_ERR "Unable to allocate CRISv32 NAND MTD "
> -			"device structure.\n");
>  		err = -ENOMEM;
>  		return NULL;
>  	}