From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: qcom-rpmh: Add support for PM8550 regulators
Date: Wed, 16 Nov 2022 12:38:04 +0100 [thread overview]
Message-ID: <e9f08af0-4360-1b92-5dcd-f1b8f3a8a4ee@linaro.org> (raw)
In-Reply-To: <20221116110515.2612515-3-abel.vesa@linaro.org>
On 16/11/2022 12:05, Abel Vesa wrote:
> Add the rpmh regulators found in PM8550 PMIC.
It's a bit more than just PM8550..
The changes look good though, so with the commit message rectified:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> They contain FT-SMPS 525s, so add their configuration as well.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 81 +++++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
>
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 4158ff126a67..42c42d17335b 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -731,6 +731,24 @@ static const struct rpmh_vreg_hw_data pmic5_ftsmps520 = {
> .of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
> };
>
> +static const struct rpmh_vreg_hw_data pmic5_ftsmps525_lv = {
> + .regulator_type = VRM,
> + .ops = &rpmh_regulator_vrm_ops,
> + .voltage_range = REGULATOR_LINEAR_RANGE(300000, 0, 267, 4000),
> + .n_voltages = 268,
> + .pmic_mode_map = pmic_mode_map_pmic5_smps,
> + .of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
> +};
> +
> +static const struct rpmh_vreg_hw_data pmic5_ftsmps525_mv = {
> + .regulator_type = VRM,
> + .ops = &rpmh_regulator_vrm_ops,
> + .voltage_range = REGULATOR_LINEAR_RANGE(600000, 0, 267, 8000),
> + .n_voltages = 268,
> + .pmic_mode_map = pmic_mode_map_pmic5_smps,
> + .of_map_mode = rpmh_regulator_pmic4_smps_of_map_mode,
> +};
> +
> static const struct rpmh_vreg_hw_data pmic5_hfsmps515 = {
> .regulator_type = VRM,
> .ops = &rpmh_regulator_vrm_ops,
> @@ -987,6 +1005,57 @@ static const struct rpmh_vreg_init_data pm8450_vreg_data[] = {
> {}
> };
>
> +static const struct rpmh_vreg_init_data pm8550_vreg_data[] = {
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_pldo, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_pldo, "vdd-l2-l13-l14"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> + RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo, "vdd-l5-l16"),
> + RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo_lv, "vdd-l6-l7"),
> + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l6-l7"),
> + RPMH_VREG("ldo8", "ldo%s8", &pmic5_pldo_lv, "vdd-l8-l9"),
> + RPMH_VREG("ldo9", "ldo%s9", &pmic5_pldo, "vdd-l8-l9"),
> + RPMH_VREG("ldo10", "ldo%s10", &pmic5_nldo, "vdd-l1-l4-l10"),
> + RPMH_VREG("ldo11", "ldo%s11", &pmic5_pldo, "vdd-l11"),
> + RPMH_VREG("ldo12", "ldo%s12", &pmic5_pldo, "vdd-l12"),
> + RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l2-l13-l14"),
> + RPMH_VREG("ldo14", "ldo%s14", &pmic5_pldo, "vdd-l2-l13-l14"),
> + RPMH_VREG("ldo15", "ldo%s15", &pmic5_pldo, "vdd-l15"),
> + RPMH_VREG("ldo16", "ldo%s16", &pmic5_pldo, "vdd-l5-l16"),
> + RPMH_VREG("ldo17", "ldo%s17", &pmic5_pldo, "vdd-l17"),
> + RPMH_VREG("bob1", "bob%s1", &pmic5_bob, "vdd-bob1"),
> + RPMH_VREG("bob2", "bob%s2", &pmic5_bob, "vdd-bob2"),
> + {}
> +};
> +
> +static const struct rpmh_vreg_init_data pm8550vs_vreg_data[] = {
> + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps525_lv, "vdd-s1"),
> + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps525_lv, "vdd-s2"),
> + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps525_lv, "vdd-s3"),
> + RPMH_VREG("smps4", "smp%s4", &pmic5_ftsmps525_lv, "vdd-s4"),
> + RPMH_VREG("smps5", "smp%s5", &pmic5_ftsmps525_lv, "vdd-s5"),
> + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_mv, "vdd-s6"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo, "vdd-l2"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> + {}
> +};
> +
> +static const struct rpmh_vreg_init_data pm8550ve_vreg_data[] = {
> + RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps525_lv, "vdd-s1"),
> + RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps525_lv, "vdd-s2"),
> + RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps525_lv, "vdd-s3"),
> + RPMH_VREG("smps4", "smp%s4", &pmic5_ftsmps525_lv, "vdd-s4"),
> + RPMH_VREG("smps5", "smp%s5", &pmic5_ftsmps525_lv, "vdd-s5"),
> + RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_lv, "vdd-s6"),
> + RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps525_lv, "vdd-s7"),
> + RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps525_lv, "vdd-s8"),
> + RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo, "vdd-l1"),
> + RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo, "vdd-l2"),
> + RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo, "vdd-l3"),
> + {}
> +};
> +
> static const struct rpmh_vreg_init_data pm8009_vreg_data[] = {
> RPMH_VREG("smps1", "smp%s1", &pmic5_hfsmps510, "vdd-s1"),
> RPMH_VREG("smps2", "smp%s2", &pmic5_hfsmps515, "vdd-s2"),
> @@ -1314,6 +1383,18 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = {
> .compatible = "qcom,pm8450-rpmh-regulators",
> .data = pm8450_vreg_data,
> },
> + {
> + .compatible = "qcom,pm8550-rpmh-regulators",
> + .data = pm8550_vreg_data,
> + },
> + {
> + .compatible = "qcom,pm8550ve-rpmh-regulators",
> + .data = pm8550ve_vreg_data,
> + },
> + {
> + .compatible = "qcom,pm8550vs-rpmh-regulators",
> + .data = pm8550vs_vreg_data,
> + },
> {
> .compatible = "qcom,pm8998-rpmh-regulators",
> .data = pm8998_vreg_data,
prev parent reply other threads:[~2022-11-16 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 11:05 [PATCH 0/2] regulator: qcom-rpmh: Add support for PM8550 Abel Vesa
2022-11-16 11:05 ` [PATCH 1/2] regulator: qcom,rpmh: Add compatible " Abel Vesa
2022-11-16 11:23 ` Krzysztof Kozlowski
2022-11-16 11:05 ` [PATCH 2/2] regulator: qcom-rpmh: Add support for PM8550 regulators Abel Vesa
2022-11-16 11:38 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f08af0-4360-1b92-5dcd-f1b8f3a8a4ee@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®