From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44B113A3ED for ; Fri, 1 Aug 2025 10:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754043293; cv=none; b=OFHGYb9PFNMIcWUBcXiPoXAkyMNGk2f8E36E5GE5cXFKtUaBzX8cycVGhZaN9wVVWkkJq+oi1Hth8/HYfAxtnj0dk7Oglc3o1ZyFbrFzdXKGHlNBKj7F4NVlcxqmBdo0nrZrN41YzKFJALDGVNP9ttn6cGKB32hguDNwrwnzZb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754043293; c=relaxed/simple; bh=NJyNuo+otNeF5GVRmFl2ZHZX4jKaO9xPyVc0ehBDVqw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=YD6W/vx5XrN+vbvpQvE9VFb+O1/uHwSUntYFiGRQzL9kzd9cK1GJWXoyJDJipCMxt/fUjdLLaRKsKVTG3TzDonUDQhFSqz3AylR5StuBW7UEHZ7pJ+RpInHbnxjcoJA1E5SmdG1mWTHhyTWXB7XGhPg9j1JsVdH24kAbL/qEExs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jBizmy0u; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jBizmy0u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754043290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5f0ikHwLTTt3/O8uwlenMs9vmb7xQLN+kpZuqDeh9ZM=; b=jBizmy0ug7L02ncGxeYJGVK+aeySjogFcNSRj2g1nMYTck09z1DUrouIQ5tb/3J6gLuUje BUtyA8m8htl7cZSZDK9Z8Ekhb0GAF8QjA0gkp9HNA2Pi7YGABzPKlQcQtALprN5dJCTE/A Ait1FIQlZuZ/ehfbIlI5dRBEMrZHV6Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-KgRZMFpvOV6bTgfUSszqHA-1; Fri, 01 Aug 2025 06:14:49 -0400 X-MC-Unique: KgRZMFpvOV6bTgfUSszqHA-1 X-Mimecast-MFC-AGG-ID: KgRZMFpvOV6bTgfUSszqHA_1754043288 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45624f0be48so9465805e9.3 for ; Fri, 01 Aug 2025 03:14:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754043288; x=1754648088; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5f0ikHwLTTt3/O8uwlenMs9vmb7xQLN+kpZuqDeh9ZM=; b=a/E5IB/DalBc8xbUhxC4+U98ozDZ/AVWONa2bpcMlBYxbQCitmtDyKwKQh64w+sMJ7 oebATYgKo1HpU8p4Gcx/0GmfLPVw7pWuLYn0hdcqrLG+ZfMJF8MPeqCtWT3Snn9SGlPd phuSX/x97ql/GGHC9D6XnJSkJyof4gMQqo7snhvCYnXFUm4240fREXaoUUs3CK7xQk9O pg/yrYzpsFcBSLeNcjLQxO1U3sqLHM766Rv9LJuWiQGB1lMt4UnE80HKS896/svkUwhM l9MvyAE3Svk5z5ocqbtJwMBhX+Csl2desGFRVk7Km7VCeavXJmn3XD9z/E81eQ2Og1Ys Poaw== X-Forwarded-Encrypted: i=1; AJvYcCUorRnODc4VbglVaytjnr7/3GzyJRDR6rQTV0jGlhtmxbIIykbKFbK4LWeQF3KvdCApfMVkr1/P8XljaXE=@vger.kernel.org X-Gm-Message-State: AOJu0YyGJOv3e/tqQWzFPvDrS+mEasvOSY3lErUeA0OxN2CRDcP6asrJ cvmwzUEwFwzzo8fbJ0dmIYyjERlrUWA9Ffgg4J66WXEYET3aPBnkfq2E5M1AUsFd9G+T3hbaLD5 MAuS5pSDXZkJOreT0uF78R05yfEypAKrmpEOV0OQpXgl+3norkZT6p9Zk7E1t006NSw== X-Gm-Gg: ASbGnculbRu00q5qEuXeL36bPG0ao5N+ABN1/dpZturzm362Z/hKAe7ePMql0qi2NLm lsu4/EdWYrh4x4X6dYmLWlK0Jzl2J9uFEiNNadKH4wmbwA2phTshxalNLYrMKWE1XeNSwox3nwg vbE6jxIHIa5eWTm1Jz7wF4xy6hqw5SKopFia4NTpOsFFp3guaPTk/gyRlNcs0q1BmN+A/pn+VR7 lwJ/T/PbEncz1wa+8HfEyZOOzirMm6Ltaki+ToUMPgxys9cui+BLnc+3Gkrn3OdlY7McTE2jK+R h8dldN18gl99Otq+vOdoKzulQGjMXEyRktR/iWgLJOHU9wya87Dj5bzQt3Q4z5SZMuJ/GjSjlqo b3n/xoMxJ4MIVnODHr+i9fuPf0LOLguTPr6qorpn5rLWlrSRJ1xXnSrKCh8+ai1OQ X-Received: by 2002:a05:600c:810a:b0:43c:fbba:41ba with SMTP id 5b1f17b1804b1-45892bd1ecfmr88340695e9.28.1754043288086; Fri, 01 Aug 2025 03:14:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcNW9A99gwbz1/XGrQLX0CryukwzOCxu8d/MxqztwNcsfV6vrQMa1DlM86ZeUVO2ntIikTPg== X-Received: by 2002:a05:600c:810a:b0:43c:fbba:41ba with SMTP id 5b1f17b1804b1-45892bd1ecfmr88340295e9.28.1754043287521; Fri, 01 Aug 2025 03:14:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f20:7500:5f99:9633:990e:138? (p200300d82f2075005f999633990e0138.dip0.t-ipconnect.de. [2003:d8:2f20:7500:5f99:9633:990e:138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c4533e6sm5570881f8f.35.2025.08.01.03.14.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Aug 2025 03:14:46 -0700 (PDT) Message-ID: Date: Fri, 1 Aug 2025 12:14:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in trace_suspend_resume To: syzbot , Liam.Howlett@oracle.com, akpm@linux-foundation.org, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, rppt@kernel.org, surenb@google.com, syzkaller-bugs@googlegroups.com, vbabka@suse.cz, Sasha Levin References: <688c9223.a00a0220.26d0e1.0068.GAE@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <688c9223.a00a0220.26d0e1.0068.GAE@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.08.25 12:08, syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit: f2d282e1dfb3 Merge tag 'bitmap-for-6.17' of https://github.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11709cf0580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=c686e0c98d241433 > dashboard link: https://syzkaller.appspot.com/bug?extid=99d4fec338b62b703891 > compiler: arm-linux-gnueabi-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > userspace arch: arm > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15e0e2a2580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12a439bc580000 > > Downloadable assets: > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/98a89b9f34e4/non_bootable_disk-f2d282e1.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/25cab46afcee/vmlinux-f2d282e1.xz > kernel image: https://storage.googleapis.com/syzbot-assets/77cd04442f1b/zImage-f2d282e1.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+99d4fec338b62b703891@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 4155 at mm/highmem.c:622 kunmap_local_indexed+0x20c/0x224 mm/highmem.c:622 > Modules linked in: > Kernel panic - not syncing: kernel: panic_on_warn set ... > CPU: 0 UID: 0 PID: 4155 Comm: syz.1.17 Not tainted 6.16.0-syzkaller #0 PREEMPT > Hardware name: ARM-Versatile Express > Call trace: > [<80201a24>] (dump_backtrace) from [<80201b20>] (show_stack+0x18/0x1c arch/arm/kernel/traps.c:257) > r7:00000000 r6:8281f77c r5:00000000 r4:8224bc00 > [<80201b08>] (show_stack) from [<8021fb00>] (__dump_stack lib/dump_stack.c:94 [inline]) > [<80201b08>] (show_stack) from [<8021fb00>] (dump_stack_lvl+0x54/0x7c lib/dump_stack.c:120) > [<8021faac>] (dump_stack_lvl) from [<8021fb40>] (dump_stack+0x18/0x1c lib/dump_stack.c:129) > r5:00000000 r4:82a76d18 > [<8021fb28>] (dump_stack) from [<80202624>] (vpanic+0x10c/0x360 kernel/panic.c:440) > [<80202518>] (vpanic) from [<802028ac>] (trace_suspend_resume+0x0/0xd8 kernel/panic.c:574) > r7:804be014 > [<80202878>] (panic) from [<802548c4>] (check_panic_on_warn kernel/panic.c:333 [inline]) > [<80202878>] (panic) from [<802548c4>] (get_taint+0x0/0x1c kernel/panic.c:328) > r3:8280c684 r2:00000001 r1:822326d8 r0:8223a0a0 > [<80254850>] (check_panic_on_warn) from [<80254a28>] (__warn+0x80/0x188 kernel/panic.c:845) > [<802549a8>] (__warn) from [<80254ca8>] (warn_slowpath_fmt+0x178/0x1f4 kernel/panic.c:872) > r8:00000009 r7:82266338 r6:df985d14 r5:840d5400 r4:00000000 > [<80254b34>] (warn_slowpath_fmt) from [<804be014>] (kunmap_local_indexed+0x20c/0x224 mm/highmem.c:622) > r10:00000000 r9:ded86c30 r8:deb6caa4 r7:00a00000 r6:00000003 r5:840d5400 > r4:ffefd000 > [<804bde08>] (kunmap_local_indexed) from [<8053ace8>] (__kunmap_local include/linux/highmem-internal.h:102 [inline]) > [<804bde08>] (kunmap_local_indexed) from [<8053ace8>] (move_pages_pte mm/userfaultfd.c:1457 [inline]) > [<804bde08>] (kunmap_local_indexed) from [<8053ace8>] (move_pages+0xb1c/0x1a00 mm/userfaultfd.c:1860) > r7:00a00000 r6:00000000 r5:8490d6ac r4:ffefb000 > [<8053a1cc>] (move_pages) from [<805c401c>] (userfaultfd_move fs/userfaultfd.c:1923 [inline]) > [<8053a1cc>] (move_pages) from [<805c401c>] (userfaultfd_ioctl+0x1254/0x2408 fs/userfaultfd.c:2046) > r10:8425d6c0 r9:df985e98 r8:00000001 r7:21000000 r6:00000000 r5:20000040 > r4:8486d000 > [<805c2dc8>] (userfaultfd_ioctl) from [<8056c4d4>] (vfs_ioctl fs/ioctl.c:51 [inline]) > [<805c2dc8>] (userfaultfd_ioctl) from [<8056c4d4>] (do_vfs_ioctl fs/ioctl.c:552 [inline]) > [<805c2dc8>] (userfaultfd_ioctl) from [<8056c4d4>] (__do_sys_ioctl fs/ioctl.c:596 [inline]) > [<805c2dc8>] (userfaultfd_ioctl) from [<8056c4d4>] (sys_ioctl+0x130/0xba0 fs/ioctl.c:584) > r10:840d5400 r9:00000003 r8:8572d780 r7:20000040 r6:8572d780 r5:00000000 > r4:c028aa05 > [<8056c3a4>] (sys_ioctl) from [<80200060>] (ret_fast_syscall+0x0/0x1c arch/arm/mm/proc-v7.S:67) > Exception stack(0xdf985fa8 to 0xdf985ff0) > 5fa0: 00000000 00000000 00000003 c028aa05 20000040 00000000 > 5fc0: 00000000 00000000 002f6300 00000036 00000000 002f62d4 00000938 00000000 > 5fe0: 7eb28780 7eb28770 000193dc 001321f0 > r10:00000036 r9:840d5400 r8:8020029c r7:00000036 r6:002f6300 r5:00000000 > r4:00000000 > Rebooting in 86400 seconds.. Probably fixed by https://lore.kernel.org/r/20250731144431.773923-1-sashal@kernel.org/ #syz test --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -1453,10 +1453,15 @@ static int move_pages_pte(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, folio_unlock(src_folio); folio_put(src_folio); } - if (dst_pte) - pte_unmap(dst_pte); + /* + * Unmap in reverse order (LIFO) to maintain proper kmap_local + * index ordering when CONFIG_HIGHPTE is enabled. We mapped dst_pte + * first, then src_pte, so we must unmap src_pte first, then dst_pte. + */ if (src_pte) pte_unmap(src_pte); + if (dst_pte) + pte_unmap(dst_pte); mmu_notifier_invalidate_range_end(&range); if (si) put_swap_device(si); -- 2.39.5 -- Cheers, David / dhildenb