mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Henri Hunnekens" <henrihunnekens@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: mingo@elte.hu
Subject: TSC calibration sometimes not correct with RT patch.
Date: Wed, 25 Jul 2007 09:25:09 +0200	[thread overview]
Message-ID: <e9f486400707250025k163d34cdk97cf2722db739634@mail.gmail.com> (raw)

I've seen that the calbration of the TSC timer was not always done
correctly, which resulted in incorrect timers.

I found out that local_irq_disable is used before the calibration is
started. However with the RT patch applied this does not mean that the
interrupts are disabled and therefore the calibration may fails when
it's interrupted by an interrupt. Correct me if I'm wrong.

I think that this local_irq_disable must be replaced with the
raw_local_irq_disable which does disable the interrupts.

I'm not able to verify if this solves the problem because it is very
hard to reproduce. Maybe someone can verify if my assumption is
correcly.

Currently I'm using kernel version 2.6.20-RT8, but I've checked that
latest kernel version with the latest RT patch and they have the same
implementation.

             reply	other threads:[~2007-07-25  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25  7:25 Henri Hunnekens [this message]
2007-07-25  7:39 ` Ingo Molnar
2007-07-25  7:56   ` Henri Hunnekens
2007-07-25 10:30     ` Joachim Deguara
2007-07-25 11:39       ` Henri Hunnekens
2007-07-25 11:41         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f486400707250025k163d34cdk97cf2722db739634@mail.gmail.com \
    --to=henrihunnekens@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®