mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Aiqun(Maria) Yu" <aiqun.yu@oss.qualcomm.com>
To: Kathiravan Thirumoorthy
	<kathiravan.thirumoorthy@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Robert Marko <robimarko@gmail.com>,
	Das Srinagesh <quic_gurus@quicinc.com>,
	tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible
Date: Tue, 11 Nov 2025 20:08:16 +0800	[thread overview]
Message-ID: <e9f52ab2-747d-4893-849f-f9fbdc567f63@oss.qualcomm.com> (raw)
In-Reply-To: <5b1f8204-1f49-4061-aa4e-f6dfe5ae2a0a@oss.qualcomm.com>

On 11/11/2025 4:29 PM, Kathiravan Thirumoorthy wrote:
> 
> On 11/7/2025 1:54 AM, Bjorn Andersson wrote:
>> On Tue, Nov 04, 2025 at 03:58:27PM +0100, Konrad Dybcio wrote:
>>> On 11/4/25 3:52 PM, Krzysztof Kozlowski wrote:
>>>> On 04/11/2025 15:38, Konrad Dybcio wrote:
>>>>> On 11/4/25 3:37 PM, Krzysztof Kozlowski wrote:
>>>>>> On 04/11/2025 15:35, Konrad Dybcio wrote:
>>>>>>> On 11/4/25 3:26 PM, Krzysztof Kozlowski wrote:
>>>>>>>> This I got, but nothing here explains why you need generic
>>>>>>>> compatible.
>>>>>>>> To re-iterate: there was no generic compatible before, now there
>>>>>>>> is.
>>>>>>>> Writing bindings and numerous reviews from DT maintainers ask
>>>>>>>> not to use
>>>>>>>> generic compatibles.
>>>>>>> OK so let's not worry about a generic compatible. IMEM exists since
>>>>>>> MSM8974 and it only had major hw updates with SM8550. They don't
>>>>>>> impact the software interface though, so qcom,msm8974-imem is OK.
>>>>>>>
>>>>>>> There's a separate control/status register address space for each
>>>>>>> instance of this IP (usually far apart from the actual SRAM pool),
>>>>>>> which Linux doesn't have to care about.
>>>>>> Just use qcom,kaanapali-imem - that's the first device here
>>>>>> without syscons.
>>>>> So we don't want to move the existing ones over?
>>>> This was never discussed and this patch did not do it. You cannot move
>>>> them, that's ABI.
>>> I see, I implicitly assumed this would be a sweeping change.
>>>
>>> So should the Kaanapali submitters simply send a version of this
>>> patch with:
>>>
>>> - oneOf:
>>>    - const: qcom,kaanapali-imem
>>>    - items:
>>>      # existing big list
>>>
>>> ?
>> We have 33 cases of "this is just a generic Qualcomm IMEM block", could
>> we just make it "qcom,imem" until there's actually a sign that it's not
>> a platform-independent block?

If it’s not platform-specific, why not use a common compatible here? I
mean let's have a common "qcom,imem" start from kaanapali.

What benefits would a platform-specific approach bring in this case? For
newer platforms, we could simply adopt the common compatible and avoid
adding a dedicated platform compatible name.

Also, the old bootloader reboot-mode solution that uses the IMEM area as
a magic syscon is deprecated for newer targets.

> 
> 
> Any conclusion / further feedback on this would be helpful to move
> things forward. Thanks in advance.


Which platform are you waiting for as a reference? Or are you only
focused on the current Kaanapali?
By the way, great to see we share the same goal here.

> 
> 
>>
>> Regards,
>> Bjorn
>>
>>> I'm not a huge fan of using kaanapali as the fallback-going-forward
>>> since it's literally the newest platform on the shelves (or perhaps
>>> not even on the shelves yet..) so it's going to look funny when
>>> someone comes up with support for another 2013 soc.. but perhaps
>>> that's just how things are supposed to be
>>>
>>> Konrad


-- 
Thx and BRs,
Aiqun(Maria) Yu

  reply	other threads:[~2025-11-11 12:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03  7:25 [PATCH v3 0/2] dt-bindings: soc: qcom: Add soc related bindings for Kaanapali Jingyi Wang
2025-11-03  7:25 ` [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible Jingyi Wang
2025-11-04  3:17   ` Bjorn Andersson
2025-11-04  8:16   ` Krzysztof Kozlowski
2025-11-04 10:41     ` Aiqun(Maria) Yu
2025-11-04 12:32     ` Konrad Dybcio
2025-11-04 14:26       ` Krzysztof Kozlowski
2025-11-04 14:35         ` Konrad Dybcio
2025-11-04 14:37           ` Krzysztof Kozlowski
2025-11-04 14:38             ` Konrad Dybcio
2025-11-04 14:52               ` Krzysztof Kozlowski
2025-11-04 14:58                 ` Konrad Dybcio
2025-11-04 15:02                   ` Krzysztof Kozlowski
2025-11-04 15:14                     ` Konrad Dybcio
2025-11-06 20:24                   ` Bjorn Andersson
2025-11-11  8:29                     ` Kathiravan Thirumoorthy
2025-11-11 12:08                       ` Aiqun(Maria) Yu [this message]
2025-11-11 16:38                         ` Kathiravan Thirumoorthy
2025-11-03  7:25 ` [PATCH v3 2/2] dt-bindings: firmware: qcom,scm: Document SCM on Kaanapali SOC Jingyi Wang
2025-11-04  3:53 ` (subset) [PATCH v3 0/2] dt-bindings: soc: qcom: Add soc related bindings for Kaanapali Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f52ab2-747d-4893-849f-f9fbdc567f63@oss.qualcomm.com \
    --to=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_gurus@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®