From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012061.outbound.protection.outlook.com [40.93.195.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E30822AE65 for ; Mon, 12 Jan 2026 06:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.61 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768198332; cv=fail; b=RO6pqmJBsrvSG7T0lflzF8D2rYEfq2bqcuI21r8K43ecdwYtjjEtx9Yi4Qz0UVrrdZeGwc+i5OdXcHZBfIqTIA6+Sk8lqSB8SPIR8YVrB1af/A9i1HHJ/o8xlLsepnK0J3QDz0bmwPzFcscqZpN1mXlKteL3IYHAgChQ3CeWVkA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768198332; c=relaxed/simple; bh=Y3Z5xHQJ9P2x6ros7n/RNJkT7S2AARpwdYGQsez3dLc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=jOiaKAz9uHpq6ZlD+R6B0Y72I1oR1vl7C+i0CVJYR5ozPCD9hzopy91+Kiq8ZeAEF+/4Nk/xthII3QmdN3QR1xaOwZzcyrN3Ole3WOHktX0LdoKZRpK6G98AX2UFrWpaswmGj1XZOzmLXpNFH1vqT7UtWUmySwgimwYjlzHVCBI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=PCvOmh1F; arc=fail smtp.client-ip=40.93.195.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="PCvOmh1F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rmXSLdORD6txoFWuY6ajAaTIfMunmmoYDXpkjp/OMv1VHaIkjl+h9rv//kxF/UN+OKY0d7vakU9HYQaLVrEceFv7na3jgdQjq+PxIPCmpl7ujTf/FsoJn3nCzdbymSukiX8XBahB1jcIZlH+k9HuOcJ1ssAoXPwMuQ0GIor60QCAAGdJGkP3/EGJkJHpZ3guKhB7OHHSU01CzQO1FOq4YmIqE17rckLV7eapaYznnC2zLqZJtE8V2/jgPr6jh6IbxIyWEZCP4vmXd0kB6tAVinZ6yqmxvInHocWN+H4ybi/82Udm8w0FLQo0RNJm3jQz3NJTs0VI1CIPgQy8ZMNFrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUVGQI7YArTVwYf5eLSV6dJ55hCCSUtoC/n8+rxxxWM=; b=naG+zA8vxfdCYiM49cS4zFpRX3atg1pJtHcbmieWe48panfA73H9uLn6g2Ml9EoKTlJWulZ14DBQA2koi/a/3QNzE1sYKh/pdzoGw94EQxhzJzFKGyLxHPxntKlpYLnLkAZzvGoXwrx+TTVfpQ/ozC3tp37pkrYjFz5zL53oOXsnhSYgIx8YQaW7APp+hYKAYoZi6UJ7JDIp/+Ut4ZmtGqabcZChYOM60WLkgz880gk3aFUglWT/H2vYCmkjsjyiOmyBMO7A1Yy0npzqwMxkgGFIJFkTKfosp+Agl43XWb/zz01n1KTWtVEUBIe84QDA+Qj8PQ4jaZylIA44jveqIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IUVGQI7YArTVwYf5eLSV6dJ55hCCSUtoC/n8+rxxxWM=; b=PCvOmh1FFly0b4OybzrTAE2Wy9RBadd3Nllbni0FbQ/ze4tMXsp8synHoufzknHwaFn1uTve4iumcPYf3J8u+DMe/I7ErYk7OV/14BC4ZGmZ0JxShnmambMDXvZ5cEXfmp0a7LHFruHI1TfBpox8arUb45fyU9fEDLcMi0f506U= Received: from SA1P222CA0153.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c3::17) by SA1PR12MB9490.namprd12.prod.outlook.com (2603:10b6:806:45b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Mon, 12 Jan 2026 06:12:08 +0000 Received: from SA2PEPF00003F68.namprd04.prod.outlook.com (2603:10b6:806:3c3:cafe::64) by SA1P222CA0153.outlook.office365.com (2603:10b6:806:3c3::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9499.7 via Frontend Transport; Mon, 12 Jan 2026 06:12:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SA2PEPF00003F68.mail.protection.outlook.com (10.167.248.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Mon, 12 Jan 2026 06:12:08 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 12 Jan 2026 00:12:07 -0600 Received: from [10.136.46.14] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 12 Jan 2026 00:12:04 -0600 Message-ID: Date: Mon, 12 Jan 2026 11:41:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] sched/rt: remove empty sched_rt_do_global() helper To: Zhan Xusheng , CC: , , , , , , , , , , Zhan Xusheng References: <20251217073721.9272-1-zhanxusheng@xiaomi.com> <20260112040241.13346-1-zhanxusheng@xiaomi.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260112040241.13346-1-zhanxusheng@xiaomi.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003F68:EE_|SA1PR12MB9490:EE_ X-MS-Office365-Filtering-Correlation-Id: 236617a1-cebb-4ad7-8d57-08de51a18452 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?clp4K0ZUUi9Pc2l4UE5PMWxxdk9GNUZJRVFzSVVaSWovd0xsdmpCUG9nVmF0?= =?utf-8?B?VVFDRjMrYjQxck5DMUVIOGdBcUhCT2l3ZmJVcWx3Q3FYdlBLWk9ZOTJvYzVW?= =?utf-8?B?eWJ2eTRac3doY0hwcDNPUGt1YTAyNFh0R2FJUW1tUnYzOUpQUksyRURXOFA3?= =?utf-8?B?UUFFaldMaHQ2L3NhaVFkMmt3SlNwck12UjlqNjgvNUd5Z1pIaXNlUndHWjBB?= =?utf-8?B?cTllSVNSY0VlKzEzZGt5aTluMndnVmNhL2FsYmlaVTJTYjFwZU9GTTVzQjVa?= =?utf-8?B?MTJ3OWVoU1RNNkJjSm9sSkxadzZiUUU2M2tUVHlxSTlEN3VCUDFNc3pLWEtV?= =?utf-8?B?b0pJSWpxTVpQVENOUGR2aHJJZXE0R21Qa3NCRVpRNFdwOHJtZStzYzF1a3Nv?= =?utf-8?B?S3prM3lpL2dFZnhMQ3d3SDBwdkhXOHdUUzlzdmFmanpEdS9xTm0rNTZJcFY1?= =?utf-8?B?TVZyNXkvSU5KWmxnZy9lSHVqeHNjTENPWlA3R1pzck0vNm96cWRpZ2pRdjIr?= =?utf-8?B?eFV1Z1FHSnJQbTBpdkYxZmJKbUwrL3prR0s2TktOUmd4NVEreTc0UlAxT2pJ?= =?utf-8?B?WHFhaFo5U3dIOCtGcEIwK0dnNWNlUnZVdTFraFVRaHJQTXZ6YnMxUkcrNkVo?= =?utf-8?B?UDh5R3A0NjNzVUJvOU5YeGxvaFFreGl3b1dOeWk4bWxHNWNTaHRXelhXVFZO?= =?utf-8?B?a2dYUi9hMlhPMUxtaUhsaG51TFdFMWxIZG5HUGdQZVFOZWdJMlRmcWRnUmlC?= =?utf-8?B?V1JpOC9WSDJDK3h0YnAzQ1I4UUk3SjllS1JrZHIxTUN2T25jaktXK0U5SWFR?= =?utf-8?B?ZlZNTzBLNkI3MVJpdisyTng0MWJIdzZRMDFOdWtBcDNENnZqeFkyOEFNYWJI?= =?utf-8?B?UEVhaUN5RzBSdnRCRFZrcHZ0ZmZVbnpsUnB5azlvNzZYVjNUbXZmdDQxYjBj?= =?utf-8?B?TTFJQWs0NUZqUFl1dWh2UDRWNUhWc3Z5Q0JhWHpvRWRsNVF6M1lESVVUM3Vp?= =?utf-8?B?UDJ2RHB6VVk0ZGpSY1ZpUHllR2o2ckdmc1AraW9pYmdVdGY1Zjcyc3dPRUoy?= =?utf-8?B?T0NnMmVKMC9lTjlPbU5RbUs5QVI3NFFIUVZudEF2c3E5ZGEvVGp0SnBuWnRS?= =?utf-8?B?SXQwK3BNa2tKd3pET2ZwV2RmVXBRYys0NWZGenBzdm1XclpuM3lJeFBmOTNy?= =?utf-8?B?bzl3WEVoelphQWc5YlRJK3pGRklmbGdadFRFRm11VDQxRGUrR0xhSFU3MW5S?= =?utf-8?B?eTE1aVpqYmdEQW9xTVRWNitQUlZZWTV0UjdtNGdKRTFiZHQxYzh2WEpqL2Zi?= =?utf-8?B?bjE2MW8rUDVuS0NkWFl6SkpxQ3dOSVV3YXB1bExBS1RnTFpualpnQjltTVpx?= =?utf-8?B?UVluSXNNWVBwcHR3eE00cFlySGhrckdIRExPRUpYb3RyejQ0MFoyODJZTDE4?= =?utf-8?B?YVF5dzdkdUljajhQdldzenQ1Ymcrbmp3eGVjVkR3a1FBU2QwakhNOVlzenky?= =?utf-8?B?UVhDQjNrV2RRS1lPWWx2cEUrUU13ZUNTTHljb0t3alcrSTM1NW1ab08ybEJV?= =?utf-8?B?K3lHNEdNc2JtRllhYlBrV2NRQXY5NlhBa2VEVllUa1hROThPZCtqRUQ1SGlM?= =?utf-8?B?cTB3bG5IWkN6NXRYMTk3bjIyb1pjM3pGWVN1d1FDT3NRcGZZNS9uT0hIeHl1?= =?utf-8?B?K3B1djNPSncwOWxsd3hHOStNbklRMElOeDV2OUltTzdIT1MrMnhNa1NiaElq?= =?utf-8?B?TDArUytvdUo5c2t0RW9LWmdNTkFMZEtYS3VCaDVlUlltQXJlZFpCRjllM1Fw?= =?utf-8?B?ay9GVW5COVQ2K0dRUmVpZWoxcGF1TUNVN2dkeWlIcUFpRGovU201ZnNjdkkz?= =?utf-8?B?VEFTcVFmYnJtenZUK01SV1MzUzZET0VuZG5SV2NNS3I3cU5CclpiTVZLMVY5?= =?utf-8?B?ODhEbXk3VUZCV0xXbXhxU0tiVzVmQ2RlT1cyMkx5NFQ4OC84WEtWWmw5Z3VS?= =?utf-8?B?cHpzZFRkYUFwZVg5S3RYTkN4N0h1ZWg3S3g0dmpaNDBvVXRyVlE2V2ladStP?= =?utf-8?B?QUdVRXhhQ3FZaCtWQnpJQk0vdmxGa0xrKy93Y0lOVjlhdUk5ck41VzdXdDdB?= =?utf-8?Q?KcOU=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2026 06:12:08.4151 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 236617a1-cebb-4ad7-8d57-08de51a18452 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003F68.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9490 Hello Zhan, On 1/12/2026 9:32 AM, Zhan Xusheng wrote: > sched_rt_do_global() is an empty helper that has no effect on > RT bandwidth sysctl handling. Perhaps you can add small comment indicating its prior function: sched_rt_do_global() was responsible for managing the RT throttling parameters before the introduction of the fair server. Since commit 5f6bd380c7bd ("sched/rt: Remove default bandwidth control") sched_rt_do_global() turned obsolete but the empty helper was retained. > > Remove the unused function and its call site to simplify the > sysctl update path. > > No functional change intended. > > Signed-off-by: Zhan Xusheng Feel free to include: Reviewed-and-tested-by: K Prateek Nayak -- Thanks and Regards, Prateek