mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vineet Gupta <vgupta@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"schuster.simon@siemens-energy.com"
	<schuster.simon@siemens-energy.com>,
	"Ley Foon Tan" <lftan@altera.com>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org,
	"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH] nios2: ksyms: Declare __mulsi3 export
Date: Sat, 31 Oct 2026 17:26:55 -0700	[thread overview]
Message-ID: <e9f9ac85-442a-4bcc-8ec6-a03a6519178d@kernel.org> (raw)
In-Reply-To: <3175caa0-9f49-465d-959e-6b6c9bbb4f01@kernel.org>

On 10/31/26 16:57, Vineet Gupta wrote:
>> * no generic implementation in kernel, need to copy from
>>     libgcc/lib1funcs.S code:
>>
>> === __divsi3 ===
>> arch/arc/kernel/arcksyms.c
>> arch/nios2/kernel/nios2_ksyms.c
>> arch/openrisc/kernel/or32_ksyms.c
>> -> arch/arm/lib/lib1funcs.S
>>      arch/m68k/lib/divsi3.S
>>      arch/microblaze/lib/divsi3.S
>>      arch/xtensa/lib/divsi3.S
>> === __modsi3 ===
>> arch/arc/kernel/arcksyms.c
>> arch/nios2/kernel/nios2_ksyms.c
>> arch/openrisc/kernel/or32_ksyms.c
>> -> arch/m68k/lib/modsi3.S
>>      arch/microblaze/lib/modsi3.S
>>      arch/xtensa/lib/modsi3.S
>> === __udivsi3 ===
>> arch/arc/kernel/arcksyms.c
>> arch/nios2/kernel/nios2_ksyms.c
>> arch/openrisc/kernel/or32_ksyms.c
>> -> arch/arm/lib/lib1funcs.S
>>      arch/m68k/lib/udivsi3.S
>>      arch/microblaze/lib/udivsi3.S
>>      arch/sh/lib/udivsi3.S
>>      arch/xtensa/lib/udivsi3.S
>> === __umodsi3 ===
>> arch/arc/kernel/arcksyms.c
>> arch/nios2/kernel/nios2_ksyms.c
>> arch/openrisc/kernel/or32_ksyms.c
>> -> arch/arm/lib/lib1funcs.S
>>      arch/m68k/lib/umodsi3.S
>>      arch/microblaze/lib/umodsi3.S
>>      arch/xtensa/lib/umodsi3.S
> ARCv2 has hardware divide so these are not needed, but ARC700 doesn't
> and there's a ton of calls for those.
>
> ┌───────────┬───────┬───────────┐
> │  routine  │ calls │ functions │
> ├───────────┼───────┼───────────┤
> │ __udivsi3 │ 415   │ 238       │
> ├───────────┼───────┼───────────┤
> │ __umodsi3 │ 203   │ 131       │
> ├───────────┼───────┼───────────┤
> │ __divsi3  │ 77    │ 57        │
> ├───────────┼───────┼───────────┤
> │ __modsi3  │ 41    │ 33        │
> └───────────┴───────┴───────────┘
>
> I can take a stab at providing the generic libgcc implementation in
> lib/* but I only expect the arches using libgcc version to switch.

It seems there 4 are always needed together or not at all.
Do we want 4 Kconfig gates or just one will suffice ?

Thx,
-Vineet

  reply	other threads:[~2026-11-01  0:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  9:49 Thomas Weißschuh
2026-10-19 11:16 ` Arnd Bergmann
2026-10-19 14:34   ` Dinh Nguyen
2026-10-20  9:40     ` David Laight
2026-10-31 23:57   ` Vineet Gupta
2026-11-01  0:26     ` Vineet Gupta [this message]
2026-11-01 11:19       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9f9ac85-442a-4bcc-8ec6-a03a6519178d@kernel.org \
    --to=vgupta@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dinguyen@kernel.org \
    --cc=lftan@altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=schuster.simon@siemens-energy.com \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®