From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v2 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer
Date: Tue, 21 Feb 2023 08:22:56 +0100 [thread overview]
Message-ID: <ea0055c7-34d4-3da0-0d3a-52020a783922@samsung.com> (raw)
In-Reply-To: <CAPLW+4=cOV8J+Ho1t8Tkg8X_3m4npyy3FUC2zcQAYywE12uEkw@mail.gmail.com>
On 19.02.2023 18:36, Sam Protsenko wrote:
> On Wed, 8 Feb 2023 at 17:43, Sam Protsenko <semen.protsenko@linaro.org> wrote:
>> Exynos5433 clock driver implements PM support internally, which might be
>> also useful for other Exynos clock drivers. Extract all PM related code
>> from clk-exynos5433 to common ARM64 functions.
>>
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>> Changes in v2:
>> - Rebased on top of latest soc/for-next tree
>> - Included linux/slab.h for kfree (found by kernel test robot)
>>
>> drivers/clk/samsung/clk-exynos-arm64.c | 171 ++++++++++++++++++++++++-
>> drivers/clk/samsung/clk-exynos-arm64.h | 3 +
>> drivers/clk/samsung/clk-exynos5433.c | 157 +----------------------
>> 3 files changed, 175 insertions(+), 156 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos-arm64.c b/drivers/clk/samsung/clk-exynos-arm64.c
>> index 2aa3f0a5644e..7ad7fd353dda 100644
>> --- a/drivers/clk/samsung/clk-exynos-arm64.c
>> +++ b/drivers/clk/samsung/clk-exynos-arm64.c
>> @@ -10,6 +10,9 @@
>> */
> Hi Marek,
>
> It just occurred to me that as I'm pulling your code from
> clk-exynos5433.c here, I should've probably added you to this file's
> author list in the header comment. Does that sound right to you? If
> so, I can re-send v3 with fixes.
Fine for me.
> Also, could you please review this series, if possible? I'm working
> right now on PM_DOMAINS support for Exynos850, so along with this
> series that would bring the initial PM support for ARM64 Exynos chips.
Well, feel free to add:
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
to v3 (the whole patchset).
The only remark I have is not strictly related to this patchset, but the
code that is already in drivers/clk/samsung/clk-exynos-arm64.c. Playing
with GATE_ENABLE_HWACG/GATE_MANUAL is not strictly specific to all
Exynos ARM64 SoCs. GATE_OFF_START/GATE_OFF_END and the enable register
bits are something specific to recent Exynos SoCs (like 7885/850/auto9)
and don't fit well into the generic arm64 clk PM code, but I don't have
a good idea how to move it to the respective clk drivers and keep it simple.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2023-02-21 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 23:43 [PATCH v2 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 1/6] clk: samsung: Don't pass reg_base to samsung_clk_register_pll() Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 2/6] clk: samsung: Remove np argument from samsung_clk_init() Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 3/6] clk: samsung: Set dev in samsung_clk_init() Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 4/6] clk: samsung: Extract clocks registration to common function Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 5/6] clk: samsung: Extract parent clock enabling " Sam Protsenko
2023-02-08 23:43 ` [PATCH v2 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer Sam Protsenko
2023-02-19 17:36 ` Sam Protsenko
2023-02-21 7:22 ` Marek Szyprowski [this message]
2023-02-23 3:07 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0055c7-34d4-3da0-0d3a-52020a783922@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sumit.semwal@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®