Re: [PATCH v2] media: iris: Refine internal buffer reconfiguration logic for resolution change

[Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>]

On 11/5/2025 5:20 AM, Val Packett wrote:
> 
> On 11/4/25 2:11 AM, Dikshita Agarwal wrote:
>> [..]
>> --- a/drivers/media/platform/qcom/iris/iris_common.c
>> +++ b/drivers/media/platform/qcom/iris/iris_common.c
>> @@ -91,12 +91,13 @@ int iris_process_streamon_input(struct iris_inst *inst)
>>   int iris_process_streamon_output(struct iris_inst *inst)
>>   {
>>       const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops;
>> -    bool drain_active = false, drc_active = false;
>>       enum iris_inst_sub_state clear_sub_state = 0;
>>       int ret = 0;
>>
>> [..]
> 
> Somehow, you have lost the + edited line that declares the bools.. Hence
> the CI failure reported for v1, and the kernel test robot message from just
> a couple minutes ago.

Yes, I realized the mistake and have posted v3 with the fix. However, I
missed to add your tested-by, apologies for the same.

Could you please review v3 and add the tag again.

Thanks,
Dikshita
> 
> But with `bool first_ipsc = false, drain_active = false, drc_active =
> false;` filled in,
> 
> Tested-by: Val Packett <val@packett.cool>
> 
> finally the decoder is actually usable \o/
> 
> ~val
>