From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD27309F1D for ; Tue, 6 Jan 2026 07:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767684160; cv=none; b=VWRFBcLKh9dxiRbngiZFoUA139mgHOdQeK2uykp3BTdcFCIyfDoCsZEMwxOpRaANAqzh/LKLP/7aJLlfSPws/in0GfKUm5hZqZwRupRTcQFx+jjYF7fE848a8ZDjGOrRdBbNG7ERRN0yjzzWqXdh4OL/k1COhdQ9wVnnBz+fDaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767684160; c=relaxed/simple; bh=Tr6nKMkYH0j83URjwjkdws1idv2EwgShDP79lP6p2OA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ALBx1o3d+NQxdEhDzlpl3M1lyLLLpo9MxvurQeXh9Zu7B3Ek/LDrZYb0DU40RZ7mCLpmKHCBJpF1FIaLkkY12/T/N80dOBDWSb+PfWlkf29vt2m0F7rdxdNEuhkprAXYQbKCM1yF8k3dLY6tJ2QrrohS3vI1gRWk6m94ogLTfic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h21zQnPG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qw0ZE9fl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h21zQnPG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qw0ZE9fl" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6063QY0Z529153 for ; Tue, 6 Jan 2026 07:22:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nYdW3BUX9r+B5i/qFPMyHS7fMQ9moDI8ZVhqNQ0SgLE=; b=h21zQnPG6XUjfuZd wiiBJlH7C444BJXszHf8wwBZdpf/u07fopTIjrv7uwJz5bSjN9H4WEQFlwhFQOMa yA1ZyTdqlUU2Vl6V+YedptWVFGq1aI3iSC2ObA0QJ7Hjp1HxjSZlPzJbmKbubN99 AU+HqNUSVOdJ68sfHqM5mMI1sizwCH9370e8TUcMaCU35MZkjty1pN5iMS80YY39 6RmDmOfuu5y009YVi9BoLbuKGJde2IXy9RCGNmi1Vmv36RjAmGNWStOdF557lqRW wGTqGE4QQT7ZGaSFxgYYpBDoO2WoDPRjY7cQvFtsjnG9WlRP66jzuQr9eTRTLccH HzcGJg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bggqu277f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 07:22:37 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f177f4d02so18403735ad.2 for ; Mon, 05 Jan 2026 23:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767684157; x=1768288957; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nYdW3BUX9r+B5i/qFPMyHS7fMQ9moDI8ZVhqNQ0SgLE=; b=Qw0ZE9fl/yuJByGWkPKW1sN9X1KjnJRHHNfpuKuFialFeRyWtPsuivCXWXXon8t3o/ TiPMYLRH5BmGMZCjCHN+YmGW0BAhF9kfsmsQRzwS/AfPY7vGnp0VnahznSt8bnF57O9Y HrcTRieLdAgDlJCvRFn9XFp5e0MU60C/mrDTKtuqI+cJGuaAFficJbtaeTnC5E3jmhkb Ik3KefDtGu4qdYqeyrJLKjxqx/pK3P5bdu3guyMpUwEj3YLdU8IoEDiDSiFTcR0ito3g jyz8TdiIhZBViqQuSuZXjZdW9Ikx6hBSkyD3bOp/PS5KbCIF5EFLbtTv/DpgIjMrQ+Jw qf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767684157; x=1768288957; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nYdW3BUX9r+B5i/qFPMyHS7fMQ9moDI8ZVhqNQ0SgLE=; b=lRBwlHslHEEY0y8mgmggC+jKPh762kf8bQdSwUVH57Yrd9yCsnGm45OW3GBBR8P4W1 E96F/4qVNZiK6DZRHHNmngrL1cN0oPGmAir+EYjYRE6PXvJfUl2bZuM0ZSYFeQomIGmP +LXDbo1wHlsVUyleEUfXDtt+mLPvRIc1puAQLO5/EUO0jAwhq2EXxadoSaLFxTYgIEM6 mOtRXaufGlMN5enUu/VDGdksvtAtvmIikk8WF3svrAyPiXjZ11LYMwGDBiNfRrkG++uz cZTrssjGoo1AaKQ7j+4IiH7R0UbteDG/kI5u9wZ66DiAC0dFQzYPwi/mQA5DT8mys0CM +iOg== X-Gm-Message-State: AOJu0YxNPi78J3ps1gmD6pjYIi88qxqn3WcsjYz6EWh7/vjf4/KuXHOs feKNGtIlpoqumr8x5vG14JJrCbxfjqsrKUGO2+N1FrkbJsCk9+5kAswPhJCyfBlgIbBvC6neUvg /dpHyvPaqzgpucf+QLD+M5zil+S85NiyzjSq3HhpVpSyvFd4DKILZYSFlNjJGdfSZnJiYcgmFo0 M= X-Gm-Gg: AY/fxX62qqLp/cnRNxH20MvOAaYeZX3sZdE994GerMrtfmIDDUESg0LHnUqkcvxSpb4 26Fwd+d5kUInmv8Sw1C03LMVm7r3LxRxL118/qDKxAYfhWCN+9IXD9n4zvaoc4KWULzzGaDCnEm 7hBUln916c6MBDmvUj3nh0WkGAQm9B1Rqp58DDfMXr8onmth4yCBfY3tlM/mgD7PN7goWayHuGG CCQbaujvrDbL4Lb4YTvg7LE2fTmlXCFrbtvBk3VGV8m4zBxLjtLCtriNyTd9qHB0rJ7lN3fL2Ej 9bI/ZqssjKcpzEPs43DI9+9SeMdjy/pnr3zLjneKrAthcohDqiV3FZ1+ux3pkxj9fpAKfSsGdoJ MFnVKd7Y+ilD/ADaUJD9MihhzLCrV20kDwnjgMh2GmQXDKpm/QybO3PUYKqGBOifkResyUr1A70 IOA6WSLQ== X-Received: by 2002:a17:902:ef52:b0:297:df4e:fdd5 with SMTP id d9443c01a7336-2a3e2cbbd99mr25369415ad.23.1767684156835; Mon, 05 Jan 2026 23:22:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4fCgkBJ5GwaDnr/7t7gVcZN56BH0JhczYJMXPSvB/LnWS4Ez/W7dUAS7GgJqcWhHEpxGMYQ== X-Received: by 2002:a17:902:ef52:b0:297:df4e:fdd5 with SMTP id d9443c01a7336-2a3e2cbbd99mr25369205ad.23.1767684156306; Mon, 05 Jan 2026 23:22:36 -0800 (PST) Received: from [10.133.33.154] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5adf1cfsm1159738b3a.57.2026.01.05.23.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jan 2026 23:22:35 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 15:22:31 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 7/7] qcom-tgu: Add reset node to initialize To: Jie Gan , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> <20251219065902.2296896-8-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDA2MCBTYWx0ZWRfXyPN7161oc1kC k3hewrrYuC9I4FoxlQaO0NntoJddSbTWJTdPkOH/Z2BwMhJLhKeowr/lKKC70IZAC3y9ftMbyey 2n68QzQAfz3UBtZ3xpKvVy5O9ba1n2HEbGa0fP0ai2V0peDZy2dL09CY/wGh1K6jeBUw8czV1Vm FmD5VHY4eGVlGEDlJVFekJN2IMmA6Pz8H7HRIj8zYD2k27ifjmXtwOG7zU7D+tMguKl8XJm/rRx rkHRQ39uicQ5Nhnk8oiQM0yHe0IQ6CkZ0LkcmlVhWiECphLZRQZeLZXbDRgMVB06S/Hr2Yqo6Sk WQmmJgiZZYw8RUuqV5ji6zyGIXrVbj1Bj4SPY+YhB6gurRdJ+RnoMoSmRRVGsMXnGqrXW3B7z5Z 0HOkrh4ewOc8Qik5UtwEuYFC0gUOClh3jmTdBm95eZ9KO1dBpC+seL/MYjMnsqD5JzvAhWqCXCz 7IeiFKIrBTWLpOc2aLQ== X-Proofpoint-ORIG-GUID: m67XUV6gOguwgQAvAL9GtPiEg08gG2xb X-Authority-Analysis: v=2.4 cv=fr/RpV4f c=1 sm=1 tr=0 ts=695cb83d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=E2cSrPEqdgoo7pV8VbMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: m67XUV6gOguwgQAvAL9GtPiEg08gG2xb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-05_02,2026-01-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060060 On 12/25/2025 1:56 PM, Jie Gan wrote: > > > On 12/19/2025 2:59 PM, Songwei Chai wrote: >> Add reset node to initialize the value of >> priority/condition_decode/condition_select/timer/counter nodes. >> >> Signed-off-by: Songwei Chai >> --- >>   .../ABI/testing/sysfs-bus-amba-devices-tgu    |  7 ++ >>   drivers/hwtracing/qcom/tgu.c                  | 74 +++++++++++++++++++ >>   2 files changed, 81 insertions(+) >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/ >> Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> index 010eade0a1c5..0733b3e07b45 100644 >> --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu >> @@ -42,3 +42,10 @@ KernelVersion    6.19 >>   Contact:    Jinlong Mao , Songwei Chai >> >>   Description: >>           (RW) Set/Get the counter value with specific step for TGU. >> + >> +What:        /sys/bus/amba/devices//reset_tgu >> +Date:        December 2025 >> +KernelVersion    6.19 >> +Contact:    Jinlong Mao , Songwei Chai >> >> +Description: >> +        (Write) Write 1 to reset the dataset for TGU. >> diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c >> index d4210869556e..5a8c6af9b719 100644 >> --- a/drivers/hwtracing/qcom/tgu.c >> +++ b/drivers/hwtracing/qcom/tgu.c >> @@ -425,8 +425,82 @@ static ssize_t enable_tgu_store(struct device *dev, >>   } >>   static DEVICE_ATTR_RW(enable_tgu); >> +/* reset_tgu_store - Reset Trace and Gating Unit (TGU) configuration. */ >> +static ssize_t reset_tgu_store(struct device *dev, >> +                   struct device_attribute *attr, const char *buf, >> +                   size_t size) >> +{ >> +    unsigned long value; >> +    struct tgu_drvdata *drvdata = dev_get_drvdata(dev); >> +    int i, j, ret; >> + >> +    if (kstrtoul(buf, 0, &value) || value == 0) >> +        return -EINVAL; >> + >> +    if (!drvdata->enable) { >> +        ret = pm_runtime_get_sync(drvdata->dev); >> +        if (ret < 0) { >> +            pm_runtime_put(drvdata->dev); >> +            return ret; >> +        } >> +    } >> + >> +    guard(spinlock)(&drvdata->lock); >> +    TGU_UNLOCK(drvdata->base); >> + >> +    writel(0, drvdata->base + TGU_CONTROL); > > Better move TGU_LOCK(drvdata->base) here Yeah.> > Thanks, > Jie > >> + >> +    if (drvdata->value_table->priority) >> +        memset(drvdata->value_table->priority, 0, >> +                MAX_PRIORITY * drvdata->max_step * >> +                drvdata->max_reg * sizeof(unsigned int)); >> + >> +    if (drvdata->value_table->condition_decode) >> +        memset(drvdata->value_table->condition_decode, 0, >> +                drvdata->max_condition_decode * drvdata->max_step * >> +                sizeof(unsigned int)); >> + >> +        /* Initialize all condition registers to NOT(value=0x1000000) */ >> +    for (i = 0; i < drvdata->max_step; i++) { >> +        for (j = 0; j < drvdata->max_condition_decode; j++) { >> +            drvdata->value_table >> +            ->condition_decode[calculate_array_location( >> +            drvdata, i, TGU_CONDITION_DECODE, j)] = >> +            0x1000000; >> +        } >> +    } >> + >> +    if (drvdata->value_table->condition_select) >> +        memset(drvdata->value_table->condition_select, 0, >> +                drvdata->max_condition_select * drvdata->max_step * >> +                sizeof(unsigned int)); >> + >> +    if (drvdata->value_table->timer) >> +        memset(drvdata->value_table->timer, 0, >> +                (drvdata->max_step) * >> +                (drvdata->max_timer) * >> +                sizeof(unsigned int)); >> + >> +    if (drvdata->value_table->counter) >> +        memset(drvdata->value_table->counter, 0, >> +                (drvdata->max_step) * >> +                (drvdata->max_counter) * >> +                sizeof(unsigned int)); >> + >> +    dev_dbg(dev, "Coresight-TGU reset complete\n"); >> + >> +    TGU_LOCK(drvdata->base); >> + >> +    drvdata->enable = false; >> +    pm_runtime_put(drvdata->dev); >> + >> +    return size; >> +} >> +static DEVICE_ATTR_WO(reset_tgu); >> + >>   static struct attribute *tgu_common_attrs[] = { >>       &dev_attr_enable_tgu.attr, >> +    &dev_attr_reset_tgu.attr, >>       NULL, >>   }; >