From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B8FE3F0AB8 for ; Fri, 10 Jul 2026 08:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672078; cv=none; b=nw/PFL5m/Wgz8JQij4+Rt0nlonkJ6BEjPNPdMINmy1SxndkNsvIEwA29gyRr9YwL75CfY5k5NqWxvr0s4xhpkHDalhznEcyuJCyx8BMiPt7pfTLT2q3qBKnXD7LuHbgmS4LzRyacDo558MI16XOW6C5enrEeoB2o3fOslr6ppJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783672078; c=relaxed/simple; bh=w0XukhUGcMXl1pfRJDXW4iErHU1Kq89lOp4vXId0pfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gn/UU/p7SjZ/SGNDLXFRP9uzn7YuoX7dpUjd3Z2iaKB0+p3bD0dswvdHcptjoNZVV5CKldoP6wTmJfo1kqdWdo4R/kuaG9TH5k/x+7GixjpoFbnRqSroxKr3J6q7F4/MtvmBin5hbeD/STPgvlY/0plUUAMpI/6VGEtTjCvZGrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LTK3w/pf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GtFReaBW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LTK3w/pf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GtFReaBW" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7dVcT235361 for ; Fri, 10 Jul 2026 08:27:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fwL26Vdu8eHV+0HZPUj6SDG3AZi2maZop/sTus1frl4=; b=LTK3w/pf3y2Iwjay ScD6QLWv15XwLvfa+FLdeLfN4OlKhxIRNGhpmo1qec5K4gDHlsNxK9tmeazt5uED JiQJGEG8ZD0SnkJ91uuLUs1m+dWSKRV/KgnrEHpmC8hlhxa6I3VvaCVhzqy5tgS8 TTu+cTF8uJlQgkZsoZfRZeSRHromjAdPhGS7vrr0/Oe6g0fkTAF3dlrwQYbnCVFY k9IY1n9ADtRlUYK+sAw6WZG5LIOcWKyUbjbSLGEJ19Dyt1cYhJgDAwpRBR0HOq32 Cl/P/LkEtnZ+0ihDpFs71ZmTR4tnqCgVLsWo+eggL86azB2OKYcynoOQ4IT+X4tP NwgJDw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg3kjhu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 08:27:56 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e5e38fbc5so63881785a.2 for ; Fri, 10 Jul 2026 01:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783672076; x=1784276876; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fwL26Vdu8eHV+0HZPUj6SDG3AZi2maZop/sTus1frl4=; b=GtFReaBWjS1RpAs+mubYSuPaEbTzuDSLEZvo6Ty9kZB64UI17vLvUVlZZLP4KVTMli rKeO0HajI/jbqZvPnXUdqAS8frtfQbRMATHcPQcxKcUKrPfnS9IO4cx3JR6JTAXZurwG uX+sagAzQdqPItQuZzuMU3bE2u2UY0a3BpvJ4i0AyiTcba9fB5vHbi8FTj6/QHuJBYRx +/b1sPd/icLcoU7Vlhw2x3X/weg/fppGW9FxZZvkCoOGPvYRQIi/ON/yboQAU2zuTAHZ qeni6eDHXkY20cnFGFf0cGH6/a0YHRQxgoL80Su0flM/8iHKCXDZPJovrUFxgMv4iDjx SpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783672076; x=1784276876; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fwL26Vdu8eHV+0HZPUj6SDG3AZi2maZop/sTus1frl4=; b=qXbJUxdWw569HG9lOeVfhZ4Hs1LnRAFEvMtNuSpmp5B51rbjGyVoAiyP3BwQS5dh/9 JT1dkAbKBegbkTJWxhbZLnUxPREQqrdIsjZBsdKThu6MaDrXyWuFAqHo5r2I3WcDEaoV 2R9t7v948pjU7qbFlYpW6uHAJiRQa0Ltx9RTO9vbVR3evyguCRWg9XsV/wda1WZhleZ3 GHIBz5MJraw31hG1EZ9YOPODM8qFsmGn1XRvCnk20YNcAhlSnXyu3M8oIsQdgoGr3S/R 64wVMATbZi3j7K0ReuqvVy2Akmy1pdbtYYja3TjfCnp74C/F5MwzK4kmys4ggq7Eanho 2i0Q== X-Forwarded-Encrypted: i=1; AHgh+RqE5CO87+iOJORpqOp3ACLKvj0RT8Cgb8KlcUC7Rt8tpoNz8DSkuzoOerd/ujFYCI4XGn1YnkCQIcwVFyU=@vger.kernel.org X-Gm-Message-State: AOJu0YzBVB1OvyJAGZkHIue1m206rZP1jmnSGPOBuiJ6d6s4rkchC4Mb yEo440N0T0zW+XNjUKDu3W7f5VSSE+VEOcCzS5LjyVSwOFlm9tPbpyeYadh5UXTpiPynd/Mynvv dQ5z539ONw5McT2LqKX46xS0qVBlvNnSbeNUA/EVtOGUv4tylkSme5+l5JVjva80LMxmuhhMNrJ g= X-Gm-Gg: AfdE7cn4IK1WKOQuVNXBJLZwcTQG4ePpv514Y4Zxp1Yc5bFiZN9ytjH7WcB8NDlCThI 6FuVNrjiLUa3sXEfmuzBW66WwbyHckpZyVhiguzd0OXpqW6lOYXbcsM9cRdJwcSFaOkFp0ak3X4 dBFP3RLr+2WwnDe2nsCAjYnPgZ4s4KFeiShQ8pKy0C9i+vQyuyqmMnhKPqxV7MWeA5YBMbuOI+c +XGaD49Ei++ikHPjkvrrDtRiSeCDInwHwOvQyTCPjCLbjKKee0UP4XzcqZIh3MD5+4oOmCdLHUn 7YDPan+Eyk/4AZAWpgwV1bY+U8i6bogLld5IdY20FuoYwzLW+UZ5Xsl3cTU5oNLPKZiby7LdXAB Cu28FY8ZEztlfNBjbNX4M/Ad0+CIyut4nPGvpMIEhyo73yA== X-Received: by 2002:ac8:590d:0:b0:51c:2190:3b56 with SMTP id d75a77b69052e-51c8b433337mr114544521cf.21.1783672075640; Fri, 10 Jul 2026 01:27:55 -0700 (PDT) X-Received: by 2002:ac8:590d:0:b0:51c:2190:3b56 with SMTP id d75a77b69052e-51c8b433337mr114544311cf.21.1783672075114; Fri, 10 Jul 2026 01:27:55 -0700 (PDT) Received: from [192.168.0.172] ([49.205.253.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15c38c164asm429906566b.3.2026.07.10.01.27.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 01:27:53 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 13:57:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] media: iris: avoid bit depth validation for capture formats To: Vishnu Reddy , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Dmitry Baryshkov , Neil Armstrong Cc: Bryan O'Donoghue , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-0-701d6dfd1ac1@oss.qualcomm.com> <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-1-701d6dfd1ac1@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260710-qc10c_fix_and_disable_time_delta_based_rc-v2-1-701d6dfd1ac1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA4MSBTYWx0ZWRfX1z72XykRUWJA BO7MBTXDqkJa0urZV/HfEHpPnfedhgicE+t0/cwcM8MvK+yTZKER4wElNWBRwzXaB1FhLekKr5t MHQzhjtKkUwJf+MGtQj2e0va+UhanbnuZLrlsZoOS/FomeClvRyfVv/Ta6Z3clMelgWqv7eOu4J nhSnvfru87Msd39A5nry9X2SnEaYLF7f18LYGHWcM5o5oyCcvjdNgKEkgBJyzzTMfrzJnPpKNsa eozah1S8CsR3bmEch0mQAXK5kLMPH/3P/5+8nsROSHP2l4U0CDaHbTS6NFU9hMZbuOUhTSSd8h9 hGzQeXMjgJOqR8h/BdWjvPoiiVoBcIXavvUVA8cdwz46I42DlSNoJNsd6WVya0QQoHUwxecmZpx CyKyA9oC8Me7SFpwSqsQoRBm9lgymTesY4QrwsXW+zaSW8Z4jG+WZcBjcZf4NAwdGqi28xkLQuz s9s3dw6UcbtXaEOjcCg== X-Authority-Analysis: v=2.4 cv=ZcMt8MVA c=1 sm=1 tr=0 ts=6a50ad0c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=MoCqpHF70WjPNMFBpltNPQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ukklFZUiyCJfO1Kbj-UA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA4MSBTYWx0ZWRfX9yU3rI62zwuK qtKS9RvIc2fvtzUmKpUS9GcP1NcKoTCMD3qtA/ujzpb3QRIVPmEppV0uig+Mwn4A7WKQfwEuzvP M4OjgzzEP+aPc0KYpmVgjl30+9sM4pc= X-Proofpoint-GUID: UbyZHAfIZ79ka1P1_mE70o5HbfoCwIrw X-Proofpoint-ORIG-GUID: UbyZHAfIZ79ka1P1_mE70o5HbfoCwIrw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100081 On 7/10/2026 8:24 AM, Vishnu Reddy wrote: > When validating a capture format, check_format() compares the requested > pixel format against inst->fw_caps[BIT_DEPTH]. However, the bit depth > capability is not available at this stage and it contains the default > value of BIT_DEPTH_8. The actual bit depth is updated later after the > firmware reports stream capabilities through read_input_subcr_params(). > Because of this, a valid client request of QC10C format request is > rejected during the initial format negotiation. The driver then falls > back to the default capture format (NV12) and stores it as capture format. > Later, when the firmware reports that the stream is 10-bit, the driver > sees NV12 as the selected capture format and switches to the default > 10-bit format (P010). As a result, the original QC10C format requested > by userspace is lost and QC10C decoding cannot work correctly. > The bit depth information is not reliable during the initial format > setup, so it should not be used to validate capture formats. Remove > the bit-depth checks from check_format() and only verify that the > requested pixel format is supported. This allows the format requested > by userspace is handled correctly. > > Fixes: 20c3ef4c7cae ("media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats") > Cc:stable@vger.kernel.org > Signed-off-by: Vishnu Reddy > --- > drivers/media/platform/qcom/iris/iris_vdec.c | 10 ---------- > 1 file changed, 10 deletions(-) Reviewed-by: Vikash Garodia