From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbdLFR1j (ORCPT ); Wed, 6 Dec 2017 12:27:39 -0500 Received: from mail-eopbgr20127.outbound.protection.outlook.com ([40.107.2.127]:21873 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752530AbdLFR1b (ORCPT ); Wed, 6 Dec 2017 12:27:31 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH v2 2/2] eeprom: at24: use a common prefix for all symbols in at24.c To: Bartosz Golaszewski Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-i2c , Linux Kernel Mailing List References: <20171206130131.13438-1-brgl@bgdev.pl> <20171206130131.13438-3-brgl@bgdev.pl> <5cffa160-7371-c71a-d3b7-ba01edb408e3@axentia.se> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Wed, 6 Dec 2017 18:27:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [85.226.244.23] X-ClientProxiedBy: HE1PR05CA0209.eurprd05.prod.outlook.com (2603:10a6:3:f9::33) To DB6PR0202MB2552.eurprd02.prod.outlook.com (2603:10a6:4:1b::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2e256c8-ed4c-4aa3-a6ce-08d53ccea01b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603286);SRVR:DB6PR0202MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;3:f54kskxEBiaTmS+QPR/3xYl5o1R7MBfFhhbBIo27az4qoSyTA71fCN3K2XxpBxL1Ux5uTSoZX4D6soYYBf23IWlTBxXXIm7Gn19Iz8IE3hgORtdg3hRHYcbAWNm5cueJxfaTTeltCY77fsUScyjz+Itr7UEvpm5rVXjqdTAw04APxyb/xcJXKiopuIx18cYMZmJQVjXkAqqfjSWY7RQSmMd8g/8InCqTz4UNrSHF2oGQ814F8uv2iAxSwDqm203m;25:nulaLORB4pA2cEVB+GhT+k55EfScbDXEpDI/ZAMVgaHDRCmwqOgsCZzshrnSNV9U2cLExJ50tCzPDw6N0WZkYeXjchX2G21hH7ea1qBZcRXP6/G3tJOmS73czgZmKZcVV6EY2kRJzntjZNsSx5AGvPMa1Jsl1zjiKvr1rXcwIJnroNxntyVj7buDU26ge0QlOQrPHmDCdT+ROBk1UnrLfAtGD/wCV0DiU9nD/5yKMTW2IyNwbtDZcML8jo40X6Ei0xr68hgXuRBTm0bGpJZ0udP5rLkOk6DwsI0tIYv0J72JHOAdcm7ndC5L9Tjhh9u9odYzyrQuywgqEfV+McMf7Q==;31:nRwmEEyX3sBSaD4oW6y/JMdiDxb4wchX22KdRJxh/0NJwvubLqPaugZS6Zldba7FtMdyyFRO2uOkV5By5aGQdbEu5G5ydtLLyZY2wt+Eb6gAln8bQefMq2OQkR+blZ+yp7pusakBM8V8tkRxVvPjHD3WjNuzuqgSmtGH8OkGv6IpfbJM+I0iEGODULkNvtN8moouUj19hcAxxxVL4xxKgmR6DIEdQuKFHVPQGirmBUk= X-MS-TrafficTypeDiagnostic: DB6PR0202MB2552: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(20161123558100)(2016111802025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6043046)(6072148)(201708071742011);SRVR:DB6PR0202MB2552;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB6PR0202MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;4:WAvCz9y6utq4IbSQq8e1uMp2n56G/hA0g/z+zsiqzdqpo+DBltquQw1JwfBraOmmxvrHp2WAtZTni4Ekz1LnjBqAN0XwdaWDIIi4RYyGRILSK5HcWiUsVez1SeKazNG6VTDyfDv0prXjnbSWsja6aLxuuP9jDzKjdn5bu1g5UcRYmqlTtr/zh1SKYBnAe+SM9Yw5n1oa+xzUMd4cbzW7zyNyPM52Pp6EBwBTWtQkXNJ3rm6QCeMJfplz84nuDKTqPTRv2NewLjEmzcs84a6aPg== X-Forefront-PRVS: 05134F8B4F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(366004)(346002)(39830400002)(376002)(377424004)(24454002)(189003)(199004)(66066001)(47776003)(65956001)(31696002)(83506002)(16526018)(53936002)(105586002)(6116002)(101416001)(3846002)(81166006)(50466002)(2906002)(68736007)(81156014)(5660300001)(8676002)(65806001)(36756003)(64126003)(16576012)(33646002)(3260700006)(305945005)(316002)(25786009)(97736004)(117156002)(65826007)(230700001)(4326008)(76176011)(229853002)(93886005)(77096006)(6486002)(2950100002)(58126008)(6666003)(54906003)(6916009)(106356001)(36916002)(23676004)(74482002)(52146003)(53546010)(6246003)(2486003)(31686004)(86362001)(7736002)(52116002)(8936002)(478600001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0202MB2552;H:[192.168.13.3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjAyMDJNQjI1NTI7MjM6SlFjRjI5MnJtT25DS3lURGM5UFdLVFBq?= =?utf-8?B?NGZrUVpld1RIQSs3NlFPUkx2ci9ZYUxBcXl4ZVF1dkQ3bmR1YUNFRDNCVUVs?= =?utf-8?B?ankvQ0I4K1VISkdBay9DN3dzdkNIcGVlbkNtM051ako2RTdza1kxVi94Rks3?= =?utf-8?B?WDJsUlhKaGhYU2pGNFA5N1RhRmlpc3BMLzA4dS9ORkNwS1RGTjhITEJkRzNo?= =?utf-8?B?VUtxV3VLdEdIcGczWmMwTGRVcm9DOVluSHdaYktTT3VsY2VuNTRtdkU4Nytt?= =?utf-8?B?WnJBSVV0UmdrVG9KbDdhU2RTT0tjckN0SHBXUzlVbVd5SjdCSmovV3VqL0tE?= =?utf-8?B?SGJBWExYSHROb3hLZXF1MzM4V2xiRlVtL2s4NnFCVzcxZmowNGpwYXc3eUFW?= =?utf-8?B?a1VwWENWRGVKNDZodzd3MnBoQTNtaS9yNlRtV25vcmJPVGYvbFZUTFRRL1ov?= =?utf-8?B?NGVJNXBidWRpQ2taUVBRSjV4eWdyaE5PRnNSYmJLS0ZpTXZMUzVKVUJIR3d5?= =?utf-8?B?Z05JY2hWVnZqSTQ0eXNDL2MxbHROdGxhTFp6UjRKL1dGMEdJeUs0STNKTTBJ?= =?utf-8?B?U3dxRnV6NGhNZmM0RVRYT0lybXM3a25jVm1HZ09FNEJhYXpxWnNJY0VQeEZY?= =?utf-8?B?alBCTWN5a2dXVjFQTCs2RUpWTXZNZktuRHlva3p0UnJHNWkwMG9WZmN3ZmZx?= =?utf-8?B?OGF1OXJTcjFlN01UZ0Q2SnY4VTNBL2tzU2pUNDBSWm84NDNZTTlJV3VyTjlR?= =?utf-8?B?UmJsUVJpSGl2R2svT2RKVjB1Z1ZDeitNSmtCRTRJbldvQ3FkQnZLTGRSOWxS?= =?utf-8?B?bE1xUjRTbWtIaEFHWU9heDJ6NHZCeExQeEh2MWl3Z0czTWVJYTBFZHFYTk5D?= =?utf-8?B?djVXeDFUWnhxdnR4cWsvS1VndFFtODcwekwvOGJPcnl3cVY2RUF6Mm5iV0w4?= =?utf-8?B?UVZYNGR6UjdIaWxYU3IrSGZ3a0RkTlFKNlNIRytqdGZZdVBHUld0V3hPMlpY?= =?utf-8?B?Z2NLZ01DbS9LZXl3eCswQ0xZOXcwU1ZvVys0WkZZcU4wY1lWejlqMUFjdGR1?= =?utf-8?B?QjBRUmhqcXFqMkpEN2ZEQldCNkJrRWw5Y1Q5S2tIV0x1RFpxY2tMRkpiMSta?= =?utf-8?B?eTEvL0hKc04wVm9YelJuUytFY1llUlFGcGVZNkw2Rk41VWVuNFc1Sk5BNjd2?= =?utf-8?B?RWpFZE5xUkg1UUQ3VUl0UEllelN0OStDTnp1eHhsRkhUb3ZzQmdycEFUZFZu?= =?utf-8?B?UDZXZkg4Q0tGa1ZWUVJ3ZGJXVUtzbno1QWFNRnNnRzNqaTh0TEZPRXVkL0Ry?= =?utf-8?B?alhRMHdUNDlacWYrSXpQRkU0eFRWQWo1K3dBNSs1eldBMVoxamhRbmF2QWUr?= =?utf-8?B?Tkp3dXFGcFhYYzFYZXdFaEk1YitlaVVlVkRNbmpUVWFGR29ZaXZRME9DZUlW?= =?utf-8?B?cEpKRGttSDhqTGJoRkdpU2t1ZTFQVUxkSEhnV3czbFZ2dmxjUlFWRno1dmJM?= =?utf-8?B?U3RoWFltQmdEM1M4b21ORy9TWGhsdGRDNGNvdm1Fb09qL2JZRXF4eDlSN3Ny?= =?utf-8?B?UWJxYXlOSnVENkRKTkFRQTgzcUJKMktBWnVlYWd6R3FEbWFVTDhBaWtLcnBU?= =?utf-8?B?ck42cDJ6WERmMXNaSVVUNktoUGt5VGZPeEpBMVRCMnFxUkdnaGpIZFdHTTBK?= =?utf-8?B?L3lsaU1yMkpxSkhBTkRUc0JCK29JeUdQeXFWbEZtUlVxbUZjZjU5ZVFjSEU1?= =?utf-8?B?cHVIV2I2RU1WQSttWlRRZXNjMWNVcXk3R0xkVEVvWlh1eWVpNUpPUVRwV2pL?= =?utf-8?B?Wmp0eEpyaEl5dXlqMGE0WEQycWMzK1FGTlpCb2VaOG1Nck85SHg0cDAyT0pX?= =?utf-8?B?QytVd2lOMDY4VWtlVVp1UWZ3aThQQ054NnRZZUJsR29ScEFDMVJCNWRhMHJp?= =?utf-8?B?RVpsZFpiTTJsejUrWkozdzhUbTFOdC9nd0ZzZDBJQjMwVDVaN2VPM0YxRlB4?= =?utf-8?B?NVEzZHBXSDJsT09VVlZQUHg0eWI5OFhmUmNac1BpbDgyazhUMGxhcnVWOE9M?= =?utf-8?Q?a4gLLo=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0202MB2552;6:fizaZh4MfUPLQuYSNczscIbkdKS2ZmWA4Ai+UstqOzZ8BZN3JWmfFOMFMt2QRHjjC9ENKrqh6Oyk7zQ18XfvW3hKrsd50940vCPELTzvWnqEwuoutTBSUu7kLOCmfeZXIse8nP+cBGRkzAAnxRxiSU890ocoi2IZTyCXOo0yhhWHAzX21sIfcTKsavWzCdpvJbSTfxuQ0ugT4vw7QFs98RnQ+QI96/33fO7y97OMYIWAwSXYMaASVdBfN5Y97iEVnHKtira0WcuF5eyh9tB97l+mD0STpV5KoGbmY5P8YKnV7ZWhzbDaHoAsBAQHBi/62tOyyQ1y61goNPGtH8BAJ5CpyyRG1X5+uHQ7bnB4T8g=;5:92aVKDENQM2hhTznd5vUGKKholfJzdbMv9aW0AkHOzm3NWRPMvUoygmw6dBAwrXaL3jqq+R30dHABzS+zwxWtoodGnsBjG4sgO4vLuf25pIt1XcS3OGPRyoX1ejiWAC1VYQq1bIxiKcywINJ9zvMpzkMcQN9aaXjJgLtXv/ouf0=;24:4NQ4Ea8KfT6/9/xuxM5erbaMYWBJ7KYyvITLfeq2wZnLSuG+oI2KIuI+/+3KJBeSvCpQE88BDeNFXYcWdWwWgyEEMUHZEZBxNa2T8hUhVJo=;7:pZfj+9Ib+P9Uh8TlPCjZE55F5FdUMzEUFd+SpctEu7JloDKqLIgJyAEY+wTFpGaMqq0Lc1LNGlzcsEMp/9xiiiU+y9KMsKvImxSCa5Np17kU9FPOftFZZoD/NcesGUuw3+3Q+UzlF7dkugGDc51bjp/5TfXfLCFDhM7uJpOZPn2Diw2HMC0Cm55oWJBGDOwNYmPg0kiQI6Ym12BvuFKMYTbWkkDkhyDHNzLm086whSINxMCNhqXkM7FhUxHJrVfm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 17:27:28.5670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2e256c8-ed4c-4aa3-a6ce-08d53ccea01b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0202MB2552 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-12-06 15:29, Bartosz Golaszewski wrote: > 2017-12-06 14:40 GMT+01:00 Peter Rosin : >> Hi! >> >> Some nits... >> >> On 2017-12-06 14:01, Bartosz Golaszewski wrote: >>> There are a couple symbols defined in the driver source file which are >>> missing the at24_ prefix. This patch fixes that. >>> >>> For module params: use module_param_named() in order not to break the >>> userspace. >> >> I'd write that as "...in order to not break userspace" >> > > I would love to hear an English native speaker's opinion on that. :) "not to" or "to not" is a matter of style/taste. I mainly wanted to point out that the definite article of "userspace" should be removed, because you are not talking about one particular userspace. Cheers, peda