From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D2543D4FA for ; Tue, 16 Jun 2026 11:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781611098; cv=none; b=kedNT8tIoX6gUfInCDpq0q6Daq82IqZSNkEdgQFDReNdmCBKlLPLo9EEw/m+9n7203YHMrUcC02COI2RePP9JvDTpstLMDewbo9KcMQtftm0YRpbC/nTyGs/UztZ3BCRIbrSu0RvTDdBJQagBBN43E7cSPc4x7qTQfEFtJrcaKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781611098; c=relaxed/simple; bh=Yr8lXVIAWkXgrBDr2OgS4iUFMLjDYwsygBnWvJVr03c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DcbUb5SflPPWueCjzSShHSQ0RAYJ2X30pDinrtbh4DUP8vIRVt2SepfUvg1BuXLVZVSooSLwZ2sF3pJodGPH9sb1g+PauB6+pW+oSzmTRXXLPPgfI5NBZee2OGRHZ+2CjbCvJIIVKnqNHZgAOdxMADoRrtw9poIHL9APxK1LwKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BsscBhV7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=afAuqzi8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BsscBhV7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="afAuqzi8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GAC1SI3256237 for ; Tue, 16 Jun 2026 11:58:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d6cYPSFoG/0e4M1JnmPrRoWDSlgvk/AWVR1/ScU4SAY=; b=BsscBhV7QwZc1V6C biXaOgq/iUL5gzyyiVMI8VWox3n+1L+X+FscBoa6QxScpl/DnDXlhNJv5BbNgam0 wuRrPnxKm/ws8gUfGcCBU/PcuF0qJKjmnz05A3z2S4NstV71ZAehxKTpRltH814U CKAts9oN6CZjx1ydDyAjtGk2rAYOXsCKwvdD+MJmlciaUcoerdQsnIMu/8gApqq1 Q7IW59U6xhGJ/+FTZ65fQsGWRNKkrDQ4qTrvvH00flnSWY5XxU+Ev6kduh9vAC8x eOv/MdIuaUyeAxT0fqherhdilY9eacjqT1BalLHQ4GV3RxF0WOuzflteyo+pZJxl H0mEyQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu09k9kwg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 11:58:15 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-917fd2bafdbso74477485a.3 for ; Tue, 16 Jun 2026 04:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781611095; x=1782215895; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d6cYPSFoG/0e4M1JnmPrRoWDSlgvk/AWVR1/ScU4SAY=; b=afAuqzi87XlYhJdN+hTKYkoY8QeWTbHZ3sxVCKbD7+Z8aaNp3SU4rAw7V0WDlpGOIV r6+NrCoGK/djQe249V69aKT9F8xZC3xCHkwEP0ELk3PspRYcF1nLarQkdrVMzO7Gx4J7 FJi7s+WfnQwQyPpB9e4IwOSsRDC+wNc9+d5tX3xT3GtWZljFfV9afEx91dWP7ZXZbbbH d8PnBFrR86Q+5cuZHG7UokhLlKtLVmff1Enu6A0WScdVNaiA0sOgpzl7NpWHM74jENzM iLmH9tHiGTMZ+DrzXqBvwk4wx9cIF6MyylA0ITfKVaJPY7YBQZxDBzoMKZEHjoh33kM7 Mwfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781611095; x=1782215895; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d6cYPSFoG/0e4M1JnmPrRoWDSlgvk/AWVR1/ScU4SAY=; b=W9jF4dZ+V27q3BissvEhKQcagq0h1wZ5zuJ0Sw9tRr/FMxWYYbBAISq2Qr8w/sbQ4Y 2fIaJYxvaLpiSk/osBYttA3PQ11335NPZnumFpEUY51wnbIEhHp2egqS3dtqT+SjxLPg ZQQgStXSIxo75spFeKB06sB4sZscmqcUt0THCDKN657InWS1F4UQ9do9B1mzvOE5X9vv NVSfk7WLUesKGUdpeZvHP2cqocb99wHJG2hZJ49Xk0rCnwBjYE3vxKSrl6Bz1TTN8GOC bis77LLkTKrCiJHToFUQcIqj9BHw1B0J9CmiS2g5M2RO9skYd3ttCU27sYsi6QN/VLUe 1Hsw== X-Forwarded-Encrypted: i=1; AFNElJ8CYkiJIr5guYxEqHQauuiZ0Cjimgd7t8jMOsZGZ7LjIom31LArzQPiE+qjOGOpeZ2BVFEBcwge8cuGyx8=@vger.kernel.org X-Gm-Message-State: AOJu0YwzJjFIDb4k1JqBtZyDWkvL5ZBE5BbIxcZzjM0944MnioBbkRjl Ggf1B6PyWQv760OJj6U2p9GMGESTuf6z2MJX6kJinGrJL+Zwvr8EyyhG0xisryLB4bbJfymKPLU 2GNDReAPPxT6fFC+5VGdgq2bxMTrFHvtS204VE5omITDdMpQY6vdqH0fyNHMDAINL3xg= X-Gm-Gg: Acq92OHzKQWdDNiQHJiiQ8L1spVvom2hYjPrVZYRq3RLQsZaUJpy64TpfLteM9qcpzO 1f1HyteArW2M6TbtS89LywwtTzlX150f6sixMhbsjqGoDhehUuqiYx3GK0Js8zz+i/eUTnmpKSZ F05VZyp3cH1xLzJjSkAHS1al9LzOPred8G1uRdV/4KgJSXYlfKVbQrncrOpnXKlnXMAraV9UooS XQMqv7WhpRfzDAbKIg7Z68QZV1HTTJWmleR3s7ZNpaE9oPb2ReNtZBkSDa3EhIsviw3Du13RS9k sEPoPpYuSabVF+WNbzSnsJmX45RHKbXLOUSz8hL/F3RtSc17kNxBWyedWCZMLFiuQA8z1jKzK85 se5sQBr8lQfdv9dZ9yerl+hw1DVnty5pDX/wXYmCrHlfUVg== X-Received: by 2002:a05:620a:1a20:b0:915:f92e:9b with SMTP id af79cd13be357-9161ba94c2dmr1711722885a.1.1781611095351; Tue, 16 Jun 2026 04:58:15 -0700 (PDT) X-Received: by 2002:a05:620a:1a20:b0:915:f92e:9b with SMTP id af79cd13be357-9161ba94c2dmr1711719685a.1.1781611094894; Tue, 16 Jun 2026 04:58:14 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb83420e9sm615905566b.45.2026.06.16.04.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 04:58:13 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 13:58:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support To: Hongyang Zhao , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Drake , Katsuhiro Suzuki , Matteo Martelli , Binbin Zhou , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Bjorn Andersson , Konrad Dybcio Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, rosh@debian.org References: <20260607-rubikpi-next-20260605-v1-0-7f334e16fea6@thundersoft.com> <20260607-rubikpi-next-20260605-v1-5-7f334e16fea6@thundersoft.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260607-rubikpi-next-20260605-v1-5-7f334e16fea6@thundersoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDEyMiBTYWx0ZWRfX2hVLVN+GmHdh Lmnu1ufHeht9eKtdsWbAzlbu7TsCRK5oSqqZW8zUexajeSzFws+Cx+UwgDyPMVE18H53JtuShMw 3q4I0Wqo1lXD3OF7+PXQNGiTAEyXNZ8= X-Proofpoint-GUID: DgAL6YZ4LXOUAwlrqm1iXs2qFpzUGUEt X-Authority-Analysis: v=2.4 cv=DoZmPm/+ c=1 sm=1 tr=0 ts=6a313a57 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Wdb1h0LgAAAA:8 a=BqodYhQyOslAVxcsot0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=j5gyrzqu0rbr1vhfHjzO:22 X-Proofpoint-ORIG-GUID: DgAL6YZ4LXOUAwlrqm1iXs2qFpzUGUEt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDEyMiBTYWx0ZWRfXwOCj23/SjZYZ NILEU7jx2190Xa+UwnTSH1IZCh38py4sPlH+fY9si/vaiFJ4nJlE+oTpOjtC9EUn8qcjLlnxmRc Zr9Cz+EN5sgW4YzgP2It/ryzQ46vO3PgaN9F14OkmH0vmzOHZVHR0QjhdsiGw4GmJGtUeXSDaIA dCoRyxJnJVLWtoeerg5/sBqu2ITVy7xuZag3N5VyQr+dWyPTl4dC9LLVRKj3Sdn8x/xGWw6UI9k zyTQl253T7zLXPm6GdoKxcpQjWFlZdHW2xW/6EIPpBtjVDcCKNYUEEuu60uVONcnTdpA3uT+nWq yOMpWz5hxD3wsHl15UySFOEnzlqg94FTxvDySDeD1nJRtcyR+D7hhbxJR45g2gd4eIR1wI8akBN aS/EgeXyzOz+ow4qvnPrj2IblXMMUHaVFHHwtMFAOraSzy7tBB7NLmPo8MNtD6Pr72PS91viYWY FM3Dkw9MiET/m3GKyNA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160122 On 6/6/26 8:58 PM, Hongyang Zhao wrote: > Add audio support for the Thundercomm RubikPi3 board. > > Enable AudioReach and describe the ES8316 headset codec, the LT9611 > HDMI codec endpoint and the SPDIF TX/RX endpoints exposed on the > 40-pin header. Add the sound card DAI links, LPASS pin configuration > and ES8316 fixed 3.3V supply. > > Signed-off-by: Hongyang Zhao > --- [...] > +&q6apmbedai { > + pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>, > + <&mi2s0_sclk>, <&mi2s0_ws>, > + <&lpass_qua_mi2s_sclk>, <&lpass_qua_mi2s_ws>, <&lpass_qua_mi2s_data>, > + <&lpass_lpi_i2s1_clk>, <&lpass_lpi_i2s1_ws>, > + <&lpass_lpi_i2s1_data0>, <&lpass_lpi_i2s1_data1>; > + pinctrl-names = "default"; > +}; I'm slightly confused as to why you bound it to the DAI node, others seem to couple these pins with the soundcard itself > + > &qupv3_id_0 { > firmware-name = "qcom/qcm6490/qupv3fw.elf"; > > @@ -1006,6 +1061,96 @@ &sdhc_2 { > status = "okay"; > }; > > +&sound { > + compatible = "thundercomm,qcs6490-rubikpi3-sndcard"; > + model = "QCS6490-Thundercomm-RubikPi3"; > + > + audio-routing = > + "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR", > + "MIC2", "Mic Jack"; Let's keep the first entry right after the equals sign and align the other ones on doublequotes Konrad