From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF03C43461 for ; Thu, 10 Sep 2020 18:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F691207EA for ; Thu, 10 Sep 2020 18:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726176AbgIJSHM (ORCPT ); Thu, 10 Sep 2020 14:07:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:8888 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbgIJSGd (ORCPT ); Thu, 10 Sep 2020 14:06:33 -0400 IronPort-SDR: ihsw14IEDztMFrsbGpSMqaAo10izxb84dtuwYqaYXw50kbAvP7ek/oBZ5pCOzNQNvvojWdOxMY MY20tK7KAKAw== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="158643332" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="158643332" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 11:06:13 -0700 IronPort-SDR: TbgBTxIPfPO2q3x6WUpY71mIX7SVfd8A37B2i0+LloyCOO9FB+mrsi21XpYbGQaGB26TwRPORs yr/lw+0Tr2KQ== X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="505920334" Received: from rdraharj-mobl1.amr.corp.intel.com (HELO [10.209.137.6]) ([10.209.137.6]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 11:06:11 -0700 Subject: Re: [PATCH V6] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine To: Radoslaw Biernacki , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Cc: Lech Betlej , alsa-devel@alsa-project.org, Todd Broch , Harshapriya , John Hsu , linux-kernel@vger.kernel.org, michal.sienkiewicz@intel.com, Ben Zhang , Mac Chiang , Yong Zhi , Marcin Wojtas , Vamshi Krishna , Alex Levin References: <20200910172538.31425-1-rad@semihalf.com> From: Pierre-Louis Bossart Message-ID: Date: Thu, 10 Sep 2020 13:06:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200910172538.31425-1-rad@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/20 12:25 PM, Radoslaw Biernacki wrote: > Since 256xFS clocks cannot be generated by SKL, the NAU8825 is > configured to re-generate its system clock from the BCLK using the > FLL. The link is configured to use a 48kHz frame rate, and 24 bits in > 25-bit slot. The SSP configuration is extracted from NHLT settings and > not dynamically changed. Listening tests and measurements do not show > any distortion or issues > > Signed-off-by: John Hsu > Signed-off-by: Yong Zhi > Signed-off-by: Mac Chiang > Signed-off-by: Ben Zhang > Signed-off-by: Radoslaw Biernacki > --- LGTM, thanks! Reviewed-by: Pierre-Louis Bossart