From: Joe Perches <joe@perches.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v2 1/2] change the function name s_vFillRTSHead
Date: Tue, 01 Nov 2022 06:32:15 -0700 [thread overview]
Message-ID: <ea1476128e2f21956ad99e52b01f0c99f46e70ba.camel@perches.com> (raw)
In-Reply-To: <ea25c687d28f5cf40c315b8191d98fa0608f8a76.1667305446.git.tanjubrunostar0@gmail.com>
On Tue, 2022-11-01 at 12:37 +0000, Tanjuate Brunostar wrote:
> Remove the use of Hungarian notation, which is not used in the Linux
> kernel. Reported by checkpatch
[]
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
[]
> @@ -23,7 +23,7 @@
> * s_uGetTxRsvTime- get frame reserved time
> * s_vFillCTSHead- fulfill CTS ctl header
> * s_vFillFragParameter- Set fragment ctl parameter.
> - * s_vFillRTSHead- fulfill RTS ctl header
> + * fill_rts_head- fulfill RTS ctl header
Perhaps use header as head is conventionally used in lists.
fill_rts_header
next prev parent reply other threads:[~2022-11-01 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 12:37 [PATCH v2 0/2] some checkpatch fixes in the file rxtx.c Tanjuate Brunostar
2022-11-01 12:37 ` [PATCH v2 1/2] change the function name s_vFillRTSHead Tanjuate Brunostar
2022-11-01 13:32 ` Joe Perches [this message]
2022-11-01 14:55 ` Tanju Brunostar
2022-11-01 12:38 ` [PATCH v2 2/2] Join some lines of code to avoid code lines ending in ( Tanjuate Brunostar
2022-11-01 18:21 ` [PATCH v2 0/2] some checkpatch fixes in the file rxtx.c Greg KH
2022-11-01 18:34 ` Tanju Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea1476128e2f21956ad99e52b01f0c99f46e70ba.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®