From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33135C4332F for ; Mon, 13 Nov 2023 11:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjKML5S (ORCPT ); Mon, 13 Nov 2023 06:57:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbjKML5Q (ORCPT ); Mon, 13 Nov 2023 06:57:16 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8C10D73 for ; Mon, 13 Nov 2023 03:57:12 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9e1fb7faa9dso659615666b.2 for ; Mon, 13 Nov 2023 03:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699876630; x=1700481430; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=g8RqWbgQzYLg3PyCTLVQhcj1adjOh+k7MefEyaZ5Nfo=; b=c1Tv0+Zv+PDRKyo+j5UN+aLGpnR5Dl7voltoQHRjZUfeA86wZ2jTwIY/bGPY4qsGAW NcmUWHnCXpQr6CpN4OShpfbhY/zjkVfZBi8J2+uZk2X6gGrYbn7vYxoGK/PLE0r/BAY7 z0IWUuEnTSEFyj7fGE9iXNatbUyF6JHY2Vi5JSQ3mXz/U7ER1gqTTe3+QzQfWwz9nPtQ GGIbHmUKycFXVEMsxgzpGTKYv0EctcryO8IDH/JgyN1E7HG5IIPpOOOew7Oyp7dL3r/f M8c2Q3RMILNOZC0gozkhhmY3Z+lSjY9WN8dmorZVDfjdNZOOY8vZpbR+nERtLCKPRTdB y6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699876630; x=1700481430; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g8RqWbgQzYLg3PyCTLVQhcj1adjOh+k7MefEyaZ5Nfo=; b=YIXiH6PF7jxSAFKN3JEpeDM9RZN1MUPJO/hT5O3xVLXbznfDFJ/gf5Npt3RfD2s13T p2nFbDMcmmYP7UYj5ZpPKbTYdZ2OZWyrq7FUgy/d9dORm3vFeGxzWzUlobdokko7aRhb otwDGjWQtE8IXHUgiptKGCSIRRGF/0DrVG+Yqo8rY2gWUIp65UzMJ4xwxMBuMCVFJc2Q LMXfX+AHh8Qu6cn09S4Tvd8nGx6L/eq/dXJCKa3iW0hxwCldDOEbMgF29ka8TPGBtmIg EFNVn0xq6JEXtYif6trvZkIblP0Mdxzo6tVOOlF+b6QEpESl0/gzODguaWV3HP9QCjgB gADw== X-Gm-Message-State: AOJu0Yw+0oW0NBJB7uWlyFAuyzQnEBV14Isxbnykfr7K+VYI/llovsEL KWPNFTG39YaO7w58gJseKERuPA== X-Google-Smtp-Source: AGHT+IF1nR/U1205K6tOwCWtLvWwJlc8OQPlDxUAGZ90GYOB0iVq8MzlFCjYhzxdWykIrTvVmiB4Vw== X-Received: by 2002:a17:906:c452:b0:9e5:37fd:8827 with SMTP id ck18-20020a170906c45200b009e537fd8827mr5203194ejb.63.1699876630540; Mon, 13 Nov 2023 03:57:10 -0800 (PST) Received: from [192.168.201.100] (178235177064.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.64]) by smtp.gmail.com with ESMTPSA id gx24-20020a170906f1d800b009c503bf61c9sm3868184ejb.165.2023.11.13.03.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 03:57:10 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 12:57:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/6] media: qcom: camss: Add sc8280xp resource details To: Bryan O'Donoghue , hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, Andy Gross , Bjorn Andersson , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , vincent.knecht@mailoo.org, matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231110-b4-camss-sc8280xp-v5-0-7f4947cc59c8@linaro.org> <20231110-b4-camss-sc8280xp-v5-4-7f4947cc59c8@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231110-b4-camss-sc8280xp-v5-4-7f4947cc59c8@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.11.2023 02:04, Bryan O'Donoghue wrote: > This commit describes the hardware layout for the sc8280xp for the > following hardware blocks: > > - 4 x VFE, 4 RDI per VFE > - 4 x VFE Lite, 4 RDI per VFE > - 4 x CSID > - 4 x CSID Lite > - 4 x CSI PHY > > Signed-off-by: Bryan O'Donoghue > --- [...] > +static const struct camss_subdev_resources vfe_res_sc8280xp[] = { > + /* IFE0 */ > + { > + .regulators = {}, > + .clock = { "gcc_axi_hf", "gcc_axi_sf", "cpas_ahb", "camnoc_axi", "vfe0", "vfe0_axi" }, > + .clock_rate = { { 0 }, > + { 0 }, > + { 19200000, 80000000}, > + { 19200000, 150000000, 266666667, 320000000, 400000000, 480000000 }, > + { 400000000, 558000000, 637000000, 760000000 }, > + { 0 }, }, > + .reg = { "vfe0" }, > + .interrupt = { "vfe0" }, > + .pd_name = "ife0", So, the comments before each array member, the reg/intr and pd names are all over the place between IFE and VFE.. Is there a reason to this? On top of that, another ideas to add onto your cleanup stack: - Are VFEs within a CAMSS block actually different? Can we just do "vfe data" and "vfe number" + "vfe_lite data" & "vfe_lite number"? - Should we move these platform structs into separate files? - Reminder about the clk_bulk_enable for clk_rate=0 clocks suggestion - OPP - Use _num instead of sentinels and magic scary while (not null) Konrad