From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751343AbdFEDvQ (ORCPT ); Sun, 4 Jun 2017 23:51:16 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:35816 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdFEDvI (ORCPT ); Sun, 4 Jun 2017 23:51:08 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: wmc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <6a6406cd813af419145a8c474337b592> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse To: Finley Xiao , heiko@sntech.de Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, huangtao@rock-chips.com, tony.xie@rock-chips.com, cl@rock-chips.com, wmc@rock-chips.com References: <1494557060-105230-1-git-send-email-finley.xiao@rock-chips.com> From: Frank Wang Message-ID: Date: Mon, 5 Jun 2017 11:51:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1494557060-105230-1-git-send-email-finley.xiao@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finley, On 2017/5/12 10:44, Finley Xiao wrote: > This adds the necessary data for handling eFuse on the rk322x. > > Signed-off-by: Finley Xiao > --- > Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 + > drivers/nvmem/rockchip-efuse.c | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > index 94aeeea..194926f 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible: Should be one of the following. > - "rockchip,rk3066a-efuse" - for RK3066a SoCs. > - "rockchip,rk3188-efuse" - for RK3188 SoCs. > + - "rockchip,rk322x-efuse" - for RK322x SoCs. As the comments from Heiko in other patches, compatibles should not contain wildcards, so could you please make this "rockchip,rk3228-efuse" instead? > - "rockchip,rk3288-efuse" - for RK3288 SoCs. > - "rockchip,rk3399-efuse" - for RK3399 SoCs. > - reg: Should contain the registers location and exact eFuse size > diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c > index 423907b..a0d4ede 100644 > --- a/drivers/nvmem/rockchip-efuse.c > +++ b/drivers/nvmem/rockchip-efuse.c > @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = { > .data = (void *)&rockchip_rk3288_efuse_read, > }, > { > + .compatible = "rockchip,rk322x-efuse", > + .data = (void *)&rockchip_rk3288_efuse_read, > + }, The same as above. BR. Frank > + { > .compatible = "rockchip,rk3288-efuse", > .data = (void *)&rockchip_rk3288_efuse_read, > },