From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4114FC433ED for ; Fri, 9 Apr 2021 09:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D1DB6115C for ; Fri, 9 Apr 2021 09:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232563AbhDIJsq (ORCPT ); Fri, 9 Apr 2021 05:48:46 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:16510 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231402AbhDIJsm (ORCPT ); Fri, 9 Apr 2021 05:48:42 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FGtY03JgDzPnX8; Fri, 9 Apr 2021 17:45:40 +0800 (CST) Received: from [10.174.178.48] (10.174.178.48) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Fri, 9 Apr 2021 17:48:20 +0800 Subject: Re: [PATCH -next] dlm: use DEFINE_MUTEX() for mutex lock To: Ye Bin , Christine Caulfield , David Teigland CC: , , , Hulk Robot References: <20210409095139.2293922-1-yebin10@huawei.com> From: "weiyongjun (A)" Message-ID: Date: Fri, 9 Apr 2021 17:48:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20210409095139.2293922-1-yebin10@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.48] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 两个标题一样的可以合并 在 2021/4/9 17:51, Ye Bin 写道: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > fs/dlm/lockspace.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c > index c14cf2b7faab..fa3ae801aa43 100644 > --- a/fs/dlm/lockspace.c > +++ b/fs/dlm/lockspace.c > @@ -26,7 +26,7 @@ > #include "ast.h" > > static int ls_count; > -static struct mutex ls_lock; > +static DEFINE_MUTEX(ls_lock); > static struct list_head lslist; > static spinlock_t lslist_lock; > static struct task_struct * scand_task; > @@ -231,7 +231,6 @@ static const struct kset_uevent_ops dlm_uevent_ops = { > int __init dlm_lockspace_init(void) > { > ls_count = 0; > - mutex_init(&ls_lock); > INIT_LIST_HEAD(&lslist); > spin_lock_init(&lslist_lock); > >