From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099C93624C5 for ; Thu, 24 Sep 2026 18:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275229; cv=none; b=s+vaLX8q5uW4PyMJy6AM3Yz5WJSgTh8qQP0SQkfHxkvTZO85bQ3fEk9QICpJgSom2XwNrSNN3yBlfiO2ONNIjwSf9Oh/DdxOx475rkBoPi3vpbEm/8t/74ML1Jz6DJmwu1NHqFBATJh4v7RexU+HxLREoWTEx46t9DThACDCM/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790275229; c=relaxed/simple; bh=Nk+ZmHul13vItNzxp9WNGq55sqZd0D/SppcIDO2waas=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q20PMRDMKZuG8b7cq0Co45Id3J8hJ/fhFbb7/Ngp73+XrDQ9VciPd91cpHCSSLGExTSDNmYEC+ikYCW0v4ZsnuxzV5QZmLNjfdq5LIJzM17v/bJnQ+ColerabNwLp3LyPXuev4Ti79kD0DTDMVFDd+U45Ao9k68Hj7Y+1y0RTws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SD+yeEOJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ku5/hg8J; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SD+yeEOJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ku5/hg8J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790275222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ax1mvo5VRJQL+OKwaeWHNjbCauQE7swJ+BSz8cvxms8=; b=SD+yeEOJQayHZZU6166zOKzllspTS6Jdjqxxk+4GHavQ9agoEvcEeobZjhd1bnzYoiXggJ JUH1zWBdt16aTtHYwv/xnNqnlfcRnFMtw8XKCtU3iiOftfs98McWD2Pq5NVNYTLmzf/keW VI0Q5dIjrSyheMfliO3SCQ9JPlYFYfE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-wWJJmPYePsSjwSzjMaRrTg-1; Thu, 24 Sep 2026 14:40:20 -0400 X-MC-Unique: wWJJmPYePsSjwSzjMaRrTg-1 X-Mimecast-MFC-AGG-ID: wWJJmPYePsSjwSzjMaRrTg_1790275220 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49ccfad90f1so1289615e9.0 for ; Thu, 24 Sep 2026 11:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790275219; x=1790880019; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ax1mvo5VRJQL+OKwaeWHNjbCauQE7swJ+BSz8cvxms8=; b=Ku5/hg8JOBjbd16z+JyV1FbvI6Qc56Md8ASXoALyh0J7GP7lAL8n/NOIkRoi3qYmaM U30viZQCid42aUw+ju7UWY32nHNrLbjfEFC8ACwnwgG2N9XPcEPwI5Jdl09oJMQkAn74 Yx+60i+jGCEs5R0//ChigNQx8U7UfDSc2pLD682POGLY7T/ZHb3BJpKxZOdk3w8cSHGw CTahRSewHbxcDT4PARRdpAfgwUltLjbrEzICVO9i7/RlgJbvdAy6SpcmC+b22ZMlKTna DRlLoKujg8jntwlBGCA17pdr9Yd/8e3nP31Ep/e/Ha7jqMLEMDWn5fIs6JJzaA2kE/XD kzTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790275219; x=1790880019; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ax1mvo5VRJQL+OKwaeWHNjbCauQE7swJ+BSz8cvxms8=; b=2pKZ72R+09XC+hFu7dh4j1pGXrU01htSYt4IwvjO9Kbh0oweqHXeu9tlHB+wMjwmZb 6lKbIMYHFjD/kc+ZZOVTOLSyOJXPST9JQxzhvBZFKkZqxXWD6nu4apUZxYEnRkyQHbpD SiDax0yeVMcJKVFU6DIMDNG/dybdPkq8Q94TNKppmr2psonL+5RBTxKAcEU9binuLPYF 0Z7EC3hjubYHdXzJABpRclwU2XKhexTZ/wfNaBKSgm4YSe4O6zLCsa3qA99NvzsMaCBH MCNXXct0oXEZjv6VHozHh1rFMx8rbHFtDgmFT3vFTAOjWFB+CIT/3MzQD2Simmwd7DMR k9eQ== X-Forwarded-Encrypted: i=1; AKwUvBy4x7YIWGKjTthv4F1nuPGV/9ryW9vC/qH23x8T+wBaXfPJWZqFI+hZHgstVnUKa6+im3OzabFMVuqzixY=@vger.kernel.org X-Gm-Message-State: AFuF++mb0uHfIRiatwllPI+/p1t1LB/2Thhd5TrL93Nqxvp1V/lrGyZU B6eWy2g17S3jrdTCKdIN3nW4TBBHUv+UG23WvIi2a9RlBNI8k1jEG4tmv85aY2+Y0apY64D2w6c 39NQHohg7FUZ4o8palpUyAFLjYiYViAemEwSuAdk9BN6/EnJxGpmHVzQC864hatt7AQ== X-Gm-Gg: AYBFou3sGC4W8zCuHhQ2Bz12ZBNcqL3j8OQ4UJhDjmZK7FgraeqGvRx8kDAkzyJEHsJ Cvtj0FVJ56H8lJ8/sX9oWCZ3uEudFaaF4C4CwIFFsOnmsRlpsk+HCgvo72QRDrlS62W1SGwsPdT jjFjbfmOpGxY74H1MYbS1Fknow1Ws+A0aD2qWO8HQgmBMD4TVydvhGHqtufQ0TrvPGUB8JYsniD qNVeKmOXKiYYneIZsDmCH1CHatsrtQyZLg8KGKMUvZLN6dlUIB7oDstB+AjwFbxXYWFHFWqticC yBP2dJ8z+QEyaB03EkGnDBRjBEciD5TL1zQFtYAf1Dqva2/C49RW7yhktWks7ZH9SLOIPqR/ X-Received: by 2002:a05:600c:4e86:b0:49c:ffe3:2b3f with SMTP id 5b1f17b1804b1-49fe66c8e13mr56080215e9.3.1790275219648; Thu, 24 Sep 2026 11:40:19 -0700 (PDT) X-Received: by 2002:a05:600c:4e86:b0:49c:ffe3:2b3f with SMTP id 5b1f17b1804b1-49fe66c8e13mr56079965e9.3.1790275219269; Thu, 24 Sep 2026 11:40:19 -0700 (PDT) Received: from [192.168.0.9] ([47.64.113.141]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fef60da94sm139075e9.4.2026.09.24.11.40.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2026 11:40:17 -0700 (PDT) Message-ID: Date: Thu, 24 Sep 2026 20:40:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/13] lib/crypto: sha2: Provide functions for zeroizing SHA2 hmac_sha* structures To: Eric Biggers , Nathan Chancellor Cc: Herbert Xu , "David S. Miller" , "Jason A. Donenfeld" , Ard Biesheuvel , Borislav Petkov , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , Namjae Jeon References: <20260916095022.604354-1-thuth@redhat.com> <20260916095022.604354-12-thuth@redhat.com> <20260924145806.GA1949494@ax162> <20260924174911.GA1978@sol> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20260924174911.GA1978@sol> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/09/2026 19.49, Eric Biggers wrote: > On Thu, Sep 24, 2026 at 10:58:06AM -0400, Nathan Chancellor wrote: >> Hi Thomas, >> >> On Wed, Sep 16, 2026 at 11:50:13AM +0200, Thomas Huth wrote: >>> In certain cases crypto code functions need to zeroize their local SHA2 >>> hmac_sha*_key or hmac_sha*_ctx structures after use to avoid leaking >>> sensitive material on the stack. >>> Provide hmac_sha*_zeroize_key() and hmac_sha*_zeroize_ctx() helper >>> functions that can be used with __cleanup() to automatically zeroize >>> the structure when it goes out of scope. >>> >>> Reviewed-by: Namjae Jeon >>> Signed-off-by: Thomas Huth >>> --- >>> include/crypto/sha2.h | 73 +++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 73 insertions(+) >>> >>> diff --git a/include/crypto/sha2.h b/include/crypto/sha2.h >>> index 7bb8fe169daf2..22fbc37ae8407 100644 >>> --- a/include/crypto/sha2.h >>> +++ b/include/crypto/sha2.h >>> @@ -7,6 +7,7 @@ >>> #define _CRYPTO_SHA2_H >>> >>> #include >>> +#include >> >> I am seeing a build failure with CONFIG_CFI=y after this patch landed in >> -next as commit 09eb210b7deb ("lib/crypto: sha2: Provide functions for >> zeroizing SHA2 hmac_sha* structures"). >> >> $ printf 'CONFIG_%s=y\n' CFI KEXEC_FILE >kernel/configs/repro.config >> >> $ make -skj"$(nproc)" ARCH=x86_64 LLVM=1 mrproper defconfig repro.config arch/x86/purgatory/ >> ld.lld: error: undefined symbol: __memset >> >>> referenced by string.c >> >>> arch/x86/purgatory/purgatory.ro:(__UNIQUE_ID_addressable___memset_5) >> >> ld.lld: error: undefined symbol: __memmove >> >>> referenced by string.c >> >>> arch/x86/purgatory/purgatory.ro:(__UNIQUE_ID_addressable___memmove_6) >> make[6]: *** [arch/x86/purgatory/Makefile:80: arch/x86/purgatory/purgatory.chk] Error 1 >> ... >> >> This comes from the instances of KCFI_REFERENCE in >> arch/x86/include/asm/string_64.h. Maybe __DISABLE_EXPORTS should be set >> for the full purgatory to avoid this? I am juggling a lot of stuff at >> the moment so just this report instead of a full patch. > > To fix linux-next, I dropped patches 10-12 of this series. Thomas, > please resend just those once there is a solution. Yes, thanks, dropping those three patches is the right thing to do right now. I will try to reproduce the problem in the next days and come up with a proper solution (like setting __DISABLE_EXPORTS if that helps...). Thomas