mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	openbmc@lists.ozlabs.org
Cc: Andrew Jeffery <andrew@aj.id.au>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] fsi/scom: Whitespace fixes
Date: Wed, 13 Jun 2018 09:58:34 -0500	[thread overview]
Message-ID: <ea1b383b-8bd9-6d0e-8364-6084f54004d1@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180612051911.20690-3-benh@kernel.crashing.org>



On 06/12/2018 12:19 AM, Benjamin Herrenschmidt wrote:
> No functional changes
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Reviewed-by: Eddie James <eajames@linux.vnet.ibm.com>

> ---
>   drivers/fsi/fsi-scom.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index 3cba0eb645e1..8a608db0aa07 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -49,7 +49,7 @@ static struct list_head scom_devices;
>   static DEFINE_IDA(scom_ida);
>
>   static int put_scom(struct scom_device *scom_dev, uint64_t value,
> -			uint32_t addr)
> +		    uint32_t addr)
>   {
>   	int rc;
>   	uint32_t data;
> @@ -77,7 +77,7 @@ static int put_scom(struct scom_device *scom_dev, uint64_t value,
>   }
>
>   static int get_scom(struct scom_device *scom_dev, uint64_t *value,
> -			uint32_t addr)
> +		    uint32_t addr)
>   {
>   	uint32_t result, data;
>   	int rc;
> @@ -110,7 +110,7 @@ static int get_scom(struct scom_device *scom_dev, uint64_t *value,
>   }
>
>   static ssize_t scom_read(struct file *filep, char __user *buf, size_t len,
> -			loff_t *offset)
> +			 loff_t *offset)
>   {
>   	int rc;
>   	struct miscdevice *mdev =
> @@ -136,7 +136,7 @@ static ssize_t scom_read(struct file *filep, char __user *buf, size_t len,
>   }
>
>   static ssize_t scom_write(struct file *filep, const char __user *buf,
> -			size_t len, loff_t *offset)
> +			  size_t len, loff_t *offset)
>   {
>   	int rc;
>   	struct miscdevice *mdev = filep->private_data;


  reply	other threads:[~2018-06-13 14:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  5:19 [RFC PATCH 0/5] FSI scom driver overhaul Benjamin Herrenschmidt
2018-06-12  5:19 ` [RFC PATCH 1/5] fsi/scom: Add mutex around FSI2PIB accesses Benjamin Herrenschmidt
2018-06-13 14:59   ` Eddie James
2018-06-12  5:19 ` [RFC PATCH 2/5] fsi/scom: Whitespace fixes Benjamin Herrenschmidt
2018-06-13 14:58   ` Eddie James [this message]
2018-06-12  5:19 ` [RFC PATCH 3/5] fsi/scom: Fixup endian annotations Benjamin Herrenschmidt
2018-06-13 14:58   ` Eddie James
2018-06-12  5:19 ` [RFC PATCH 4/5] fsi/scom: Add register definitions Benjamin Herrenschmidt
2018-06-13 14:57   ` Eddie James
2018-06-12  5:19 ` [RFC PATCH 5/5] fsi/scom: Major overhaul Benjamin Herrenschmidt
2018-06-13 14:57   ` Eddie James
2018-06-13 23:00     ` Benjamin Herrenschmidt
2018-06-14 14:12       ` Eddie James
2018-06-16  5:04   ` Joel Stanley
2018-06-17  1:17     ` Benjamin Herrenschmidt
2018-06-17  1:22       ` Benjamin Herrenschmidt
2018-06-18  4:09         ` Alistair Popple
2018-06-18  4:46           ` Benjamin Herrenschmidt
2018-06-18  5:05             ` Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea1b383b-8bd9-6d0e-8364-6084f54004d1@linux.vnet.ibm.com \
    --to=eajames@linux.vnet.ibm.com \
    --cc=andrew@aj.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®