mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Xi Ruoyao" <xry111@xry111.site>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Icenowy Zheng" <icenowy@aosc.io>
Subject: Re: [PATCH] Revert "MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT"
Date: Sat, 11 Jan 2025 10:09:55 +0000	[thread overview]
Message-ID: <ea1fc568-91b7-4781-b870-ae90675214e3@app.fastmail.com> (raw)
In-Reply-To: <20241223092041.257941-1-xry111@xry111.site>



在2024年12月23日十二月 上午9:20,Xi Ruoyao写道:
> This reverts commit 426fa8e4fe7bb914b5977cbce453a9926bf5b2e6.
>
> The commit has caused two issues on Loongson 3A4000:
>
> 1. The timestamp in dmesg become erratic, like:
>
>     [3.736957] amdgpu 0000:04:00.0: ... ...
>     [3.748895] [drm] Initialized amdgpu ... ...
>     [18446744073.381141] amdgpu 0000:04:00:0: ... ...
>     [1.613326] igb 0000:03:00.0 enp3s0: ... ...
>
> 2. More seriously, some workloads (for example, the test
>    stdlib/test-cxa_atexit2 in the Glibc test suite) triggers an RCU
>    stall and hang the system with a high probably (4 hangs out of 5
>    tests).
>
> Revert this commit to use jiffie on Loongson MIPS systems and fix these
> issues for now.  The root cause may need more investigation.
>
> Cc: stable@vger.kernel.org # 6.11+
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: Icenowy Zheng <icenowy@aosc.io>

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

It's indeed problematic in some scenarios.

Let's revert for now.

Thanks
- Jiaxun

> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
>  arch/mips/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 467b10f4361a..5078ebf071ec 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1084,7 +1084,6 @@ config CSRC_IOASIC
> 
>  config CSRC_R4K
>  	select CLOCKSOURCE_WATCHDOG if CPU_FREQ
> -	select HAVE_UNSTABLE_SCHED_CLOCK if SMP && 64BIT
>  	bool
> 
>  config CSRC_SB1250
> -- 
> 2.47.1

-- 
- Jiaxun

  reply	other threads:[~2025-01-11 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-23  9:20 Xi Ruoyao
2025-01-11 10:09 ` Jiaxun Yang [this message]
2025-01-11 12:02 ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea1fc568-91b7-4781-b870-ae90675214e3@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=icenowy@aosc.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®